Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Side by Side Diff: chrome/renderer/safe_browsing/threat_dom_details.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // ThreatDOMDetails iterates over a document's frames and gathers 5 // ThreatDOMDetails iterates over a document's frames and gathers
6 // interesting URLs such as those of scripts and frames. When done, it sends 6 // interesting URLs such as those of scripts and frames. When done, it sends
7 // them to the ThreatDetails that requested them. 7 // them to the ThreatDetails that requested them.
8 8
9 #ifndef CHROME_RENDERER_SAFE_BROWSING_THREAT_DOM_DETAILS_H_ 9 #ifndef CHROME_RENDERER_SAFE_BROWSING_THREAT_DOM_DETAILS_H_
10 #define CHROME_RENDERER_SAFE_BROWSING_THREAT_DOM_DETAILS_H_ 10 #define CHROME_RENDERER_SAFE_BROWSING_THREAT_DOM_DETAILS_H_
(...skipping 23 matching lines...) Expand all
34 std::vector<SafeBrowsingHostMsg_ThreatDOMDetails_Node>* resources); 34 std::vector<SafeBrowsingHostMsg_ThreatDOMDetails_Node>* resources);
35 35
36 private: 36 private:
37 // Creates a ThreatDOMDetails for the specified RenderFrame. 37 // Creates a ThreatDOMDetails for the specified RenderFrame.
38 // The ThreatDOMDetails should be destroyed prior to destroying 38 // The ThreatDOMDetails should be destroyed prior to destroying
39 // the RenderFrame. 39 // the RenderFrame.
40 explicit ThreatDOMDetails(content::RenderFrame* render_frame); 40 explicit ThreatDOMDetails(content::RenderFrame* render_frame);
41 41
42 // RenderFrameObserver implementation. 42 // RenderFrameObserver implementation.
43 bool OnMessageReceived(const IPC::Message& message) override; 43 bool OnMessageReceived(const IPC::Message& message) override;
44 void OnDestruct() override;
44 45
45 void OnGetThreatDOMDetails(); 46 void OnGetThreatDOMDetails();
46 47
47 DISALLOW_COPY_AND_ASSIGN(ThreatDOMDetails); 48 DISALLOW_COPY_AND_ASSIGN(ThreatDOMDetails);
48 }; 49 };
49 50
50 } // namespace safe_browsing 51 } // namespace safe_browsing
51 52
52 #endif // CHROME_RENDERER_SAFE_BROWSING_THREAT_DOM_DETAILS_H_ 53 #endif // CHROME_RENDERER_SAFE_BROWSING_THREAT_DOM_DETAILS_H_
OLDNEW
« no previous file with comments | « chrome/renderer/safe_browsing/phishing_classifier_delegate.cc ('k') | chrome/renderer/safe_browsing/threat_dom_details.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698