components/page_load_metrics/renderer/metrics_render_frame_observer.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/nacl/renderer/nacl_helper.cc ('k') | components/page_load_metrics/renderer/metrics_render_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/renderer/metrics_render_frame_observer.h

diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.h b/components/page_load_metrics/renderer/metrics_render_frame_observer.h

index 7940298a6d0d45c0c50e5cb7a199d1949ea7ceaf..3648c805c8fde1560bd4b078a23563f76e0aabc4 100644

--- a/components/page_load_metrics/renderer/metrics_render_frame_observer.h

+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.h

@@ -33,6 +33,7 @@ class MetricsRenderFrameObserver : public content::RenderFrameObserver {

blink::WebLoadingBehaviorFlag behavior) override;

void DidCommitProvisionalLoad(bool is_new_navigation,

bool is_same_page_navigation) override;

+ void OnDestruct() override;

private:

// Will be null when we're not actively sending metrics.

« no previous file with comments | « components/nacl/renderer/nacl_helper.cc ('k') | components/page_load_metrics/renderer/metrics_render_frame_observer.cc » ('j') | no next file with comments »