Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: content/public/renderer/render_view_observer.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/renderer/render_view_observer.h ('k') | content/public/test/frame_load_waiter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/renderer/render_view_observer.cc
diff --git a/content/public/renderer/render_view_observer.cc b/content/public/renderer/render_view_observer.cc
index 5e876cc1bff979fbb4fd2e8e70a5d00e81b00b02..f90a8058cb44d8cc2a73b0169b7ec5b2f6fe9373 100644
--- a/content/public/renderer/render_view_observer.cc
+++ b/content/public/renderer/render_view_observer.cc
@@ -24,10 +24,6 @@ RenderViewObserver::~RenderViewObserver() {
render_view_->RemoveObserver(this);
}
-void RenderViewObserver::OnDestruct() {
- delete this;
-}
-
bool RenderViewObserver::OnMessageReceived(const IPC::Message& message) {
return false;
}
« no previous file with comments | « content/public/renderer/render_view_observer.h ('k') | content/public/test/frame_load_waiter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698