content/renderer/screen_orientation/screen_orientation_dispatcher.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/screen_orientation/screen_orientation_dispatcher.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/screen_orientation/screen_orientation_dispatcher.h ('k') | content/renderer/shared_worker_repository.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/screen_orientation/screen_orientation_dispatcher.cc

diff --git a/content/renderer/screen_orientation/screen_orientation_dispatcher.cc b/content/renderer/screen_orientation/screen_orientation_dispatcher.cc

index f0060ef0b2127ad16113a5b36b936729f88e2e90..5f2071d377945cab190ed1bfd71ddf2da976e616 100644

--- a/content/renderer/screen_orientation/screen_orientation_dispatcher.cc

+++ b/content/renderer/screen_orientation/screen_orientation_dispatcher.cc

@@ -31,6 +31,10 @@ bool ScreenOrientationDispatcher::OnMessageReceived(

return handled;

}

+void ScreenOrientationDispatcher::OnDestruct() {

+ delete this;

void ScreenOrientationDispatcher::OnLockSuccess(int request_id) {

blink::WebLockOrientationCallback* callback =

pending_callbacks_.Lookup(request_id);

« no previous file with comments | « content/renderer/screen_orientation/screen_orientation_dispatcher.h ('k') | content/renderer/shared_worker_repository.h » ('j') | no next file with comments »