content/renderer/android/renderer_date_time_picker.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/renderer/android/renderer_date_time_picker.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/renderer/accessibility/renderer_accessibility.cc ('k') | content/renderer/android/renderer_date_time_picker.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_RENDERER_ANDROID_RENDERER_DATE_TIME_PICKER_H_	5 #ifndef CONTENT_RENDERER_ANDROID_RENDERER_DATE_TIME_PICKER_H_

6 #define CONTENT_RENDERER_ANDROID_RENDERER_DATE_TIME_PICKER_H_	6 #define CONTENT_RENDERER_ANDROID_RENDERER_DATE_TIME_PICKER_H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "content/public/renderer/render_view_observer.h"	9 #include "content/public/renderer/render_view_observer.h"

10 #include "third_party/WebKit/public/web/WebDateTimeChooserParams.h"	10 #include "third_party/WebKit/public/web/WebDateTimeChooserParams.h"

(...skipping 16 matching lines...) Expand all Loading...
27 ~RendererDateTimePicker() override;	27 ~RendererDateTimePicker() override;

28	28

29 bool Open();	29 bool Open();

30	30

31 private:	31 private:

32 void OnReplaceDateTime(double value);	32 void OnReplaceDateTime(double value);

33 void OnCancel();	33 void OnCancel();

34	34

35 // RenderViewObserver	35 // RenderViewObserver

36 bool OnMessageReceived(const IPC::Message& message) override;	36 bool OnMessageReceived(const IPC::Message& message) override;

	37 void OnDestruct() override;

37	38

38 blink::WebDateTimeChooserParams chooser_params_;	39 blink::WebDateTimeChooserParams chooser_params_;

39 blink::WebDateTimeChooserCompletion* chooser_completion_; // Not owned by us	40 blink::WebDateTimeChooserCompletion* chooser_completion_; // Not owned by us

40	41

41 DISALLOW_COPY_AND_ASSIGN(RendererDateTimePicker);	42 DISALLOW_COPY_AND_ASSIGN(RendererDateTimePicker);

42 };	43 };

43	44

44 } // namespace content	45 } // namespace content

45	46

46 #endif // CONTENT_RENDERER_ANDROID_RENDERER_DATE_TIME_PICKER_H_	47 #endif // CONTENT_RENDERER_ANDROID_RENDERER_DATE_TIME_PICKER_H_

OLD	NEW