Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: android_webview/renderer/print_render_frame_observer.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/renderer/print_render_frame_observer.h ('k') | chrome/renderer/banners/app_banner_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/renderer/print_render_frame_observer.cc
diff --git a/android_webview/renderer/print_render_frame_observer.cc b/android_webview/renderer/print_render_frame_observer.cc
index 0ecc717117cdda40bb57211f06763a8e1a579978..2542d7640bb5a7a0c8dec3868b8a11c88fc1b013 100644
--- a/android_webview/renderer/print_render_frame_observer.cc
+++ b/android_webview/renderer/print_render_frame_observer.cc
@@ -38,4 +38,8 @@ void PrintRenderFrameObserver::OnPrintNodeUnderContextMenu() {
helper->PrintNode(render_frame()->GetWebFrame()->contextMenuNode());
}
+void PrintRenderFrameObserver::OnDestruct() {
+ delete this;
+}
+
} // namespace android_webview
« no previous file with comments | « android_webview/renderer/print_render_frame_observer.h ('k') | chrome/renderer/banners/app_banner_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698