Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Side by Side Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/page_load_metrics/renderer/metrics_render_frame_observer.h" 5 #include "components/page_load_metrics/renderer/metrics_render_frame_observer.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 std::unique_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() const { 142 std::unique_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() const {
143 return base::WrapUnique(new base::OneShotTimer); 143 return base::WrapUnique(new base::OneShotTimer);
144 } 144 }
145 145
146 bool MetricsRenderFrameObserver::HasNoRenderFrame() const { 146 bool MetricsRenderFrameObserver::HasNoRenderFrame() const {
147 bool no_frame = !render_frame() || !render_frame()->GetWebFrame(); 147 bool no_frame = !render_frame() || !render_frame()->GetWebFrame();
148 DCHECK(!no_frame); 148 DCHECK(!no_frame);
149 return no_frame; 149 return no_frame;
150 } 150 }
151 151
152 void MetricsRenderFrameObserver::OnDestruct() {
153 delete this;
154 }
155
152 } // namespace page_load_metrics 156 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698