content/renderer/speech_recognition_dispatcher.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/speech_recognition_dispatcher.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/speech_recognition_dispatcher.cc

diff --git a/content/renderer/speech_recognition_dispatcher.cc b/content/renderer/speech_recognition_dispatcher.cc

index 585b61cd8da0c043c0e7b02551ba07729282c07a..e707f4105df09f624a048118a784ed74838be4a1 100644

--- a/content/renderer/speech_recognition_dispatcher.cc

+++ b/content/renderer/speech_recognition_dispatcher.cc

@@ -66,6 +66,10 @@ bool SpeechRecognitionDispatcher::OnMessageReceived(

return handled;

}

+void SpeechRecognitionDispatcher::OnDestruct() {

+ delete this;

void SpeechRecognitionDispatcher::start(

const WebSpeechRecognitionHandle& handle,

const WebSpeechRecognitionParams& params,

« no previous file with comments | « content/renderer/speech_recognition_dispatcher.h ('k') | content/renderer/stats_collection_observer.h » ('j') | no next file with comments »