Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Side by Side Diff: android_webview/renderer/aw_render_view_ext.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_RENDERER_AW_RENDER_VIEW_EXT_H_ 5 #ifndef ANDROID_WEBVIEW_RENDERER_AW_RENDER_VIEW_EXT_H_
6 #define ANDROID_WEBVIEW_RENDERER_AW_RENDER_VIEW_EXT_H_ 6 #define ANDROID_WEBVIEW_RENDERER_AW_RENDER_VIEW_EXT_H_
7 7
8 #include "base/timer/timer.h" 8 #include "base/timer/timer.h"
9 #include "content/public/renderer/render_view_observer.h" 9 #include "content/public/renderer/render_view_observer.h"
10 #include "ui/gfx/geometry/size.h" 10 #include "ui/gfx/geometry/size.h"
11 11
12 namespace android_webview { 12 namespace android_webview {
13 13
14 // Render process side of AwRenderViewHostExt, this provides cross-process 14 // Render process side of AwRenderViewHostExt, this provides cross-process
15 // implementation of miscellaneous WebView functions that we need to poke 15 // implementation of miscellaneous WebView functions that we need to poke
16 // WebKit directly to implement (and that aren't needed in the chrome app). 16 // WebKit directly to implement (and that aren't needed in the chrome app).
17 class AwRenderViewExt : public content::RenderViewObserver { 17 class AwRenderViewExt : public content::RenderViewObserver {
18 public: 18 public:
19 static void RenderViewCreated(content::RenderView* render_view); 19 static void RenderViewCreated(content::RenderView* render_view);
20 20
21 private: 21 private:
22 AwRenderViewExt(content::RenderView* render_view); 22 AwRenderViewExt(content::RenderView* render_view);
23 ~AwRenderViewExt() override; 23 ~AwRenderViewExt() override;
24 24
25 // RenderViewObserver: 25 // RenderViewObserver:
26 void DidCommitCompositorFrame() override; 26 void DidCommitCompositorFrame() override;
27 void DidUpdateLayout() override; 27 void DidUpdateLayout() override;
28 void OnDestruct() override;
28 29
29 void CheckContentsSize(); 30 void CheckContentsSize();
30 void PostCheckContentsSize(); 31 void PostCheckContentsSize();
31 32
32 gfx::Size last_sent_contents_size_; 33 gfx::Size last_sent_contents_size_;
33 base::OneShotTimer check_contents_size_timer_; 34 base::OneShotTimer check_contents_size_timer_;
34 35
35 DISALLOW_COPY_AND_ASSIGN(AwRenderViewExt); 36 DISALLOW_COPY_AND_ASSIGN(AwRenderViewExt);
36 }; 37 };
37 38
38 } // namespace android_webview 39 } // namespace android_webview
39 40
40 #endif // ANDROID_WEBVIEW_RENDERER_AW_RENDER_VIEW_EXT_H_ 41 #endif // ANDROID_WEBVIEW_RENDERER_AW_RENDER_VIEW_EXT_H_
OLDNEW
« no previous file with comments | « android_webview/renderer/aw_render_frame_ext.cc ('k') | android_webview/renderer/aw_render_view_ext.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698