components/printing/renderer/print_web_view_helper.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/printing/renderer/print_web_view_helper.h ('k') | components/translate/content/renderer/translate_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/printing/renderer/print_web_view_helper.cc

diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc

index cfb1c777bf002b864cd29bb249a82e50cd005d09..1a1fdf0762d925d6fdc24496a1eac6283ced1261 100644

--- a/components/printing/renderer/print_web_view_helper.cc

+++ b/components/printing/renderer/print_web_view_helper.cc

@@ -942,6 +942,10 @@ bool PrintWebViewHelper::OnMessageReceived(const IPC::Message& message) {

return handled;

}

+void PrintWebViewHelper::OnDestruct() {

+ delete this;

bool PrintWebViewHelper::GetPrintFrame(blink::WebLocalFrame** frame) {

DCHECK(frame);

blink::WebView* webView = render_view()->GetWebView();

« no previous file with comments | « components/printing/renderer/print_web_view_helper.h ('k') | components/translate/content/renderer/translate_helper.h » ('j') | no next file with comments »