extensions/renderer/extensions_render_frame_observer.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/extensions_render_frame_observer.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/extensions_render_frame_observer.h

diff --git a/extensions/renderer/extensions_render_frame_observer.h b/extensions/renderer/extensions_render_frame_observer.h

index 55521b2b7b5185242e72b6bb014e3b22f9e5fee7..35f03a9085ea21d810316e1be15748a07e0f1b7d 100644

--- a/extensions/renderer/extensions_render_frame_observer.h

+++ b/extensions/renderer/extensions_render_frame_observer.h

@@ -28,6 +28,7 @@ class ExtensionsRenderFrameObserver

const base::string16& stack_trace,

uint32_t line_number,

int32_t severity_level) override;

+ void OnDestruct() override;

DISALLOW_COPY_AND_ASSIGN(ExtensionsRenderFrameObserver);

};

« no previous file with comments | « extensions/renderer/extension_helper.cc ('k') | extensions/renderer/extensions_render_frame_observer.cc » ('j') | no next file with comments »