content/renderer/media/android/renderer_surface_view_manager.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/renderer/media/android/renderer_surface_view_manager.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/renderer/media/android/renderer_surface_view_manager.h"	5 #include "content/renderer/media/android/renderer_surface_view_manager.h"

6	6

7 #include "content/common/media/surface_view_manager_messages_android.h"	7 #include "content/common/media/surface_view_manager_messages_android.h"

8 #include "ipc/ipc_message_macros.h"	8 #include "ipc/ipc_message_macros.h"

9 #include "ui/gfx/geometry/size.h"	9 #include "ui/gfx/geometry/size.h"

10	10

(...skipping 29 matching lines...) Expand all Loading...
40 Send(new SurfaceViewManagerHostMsg_NaturalSizeChanged(routing_id(), size));	40 Send(new SurfaceViewManagerHostMsg_NaturalSizeChanged(routing_id(), size));

41 }	41 }

42	42

43 void RendererSurfaceViewManager::OnFullscreenSurfaceCreated(int surface_id) {	43 void RendererSurfaceViewManager::OnFullscreenSurfaceCreated(int surface_id) {

44 DVLOG(3) << __FUNCTION__ << ": surface_id: " << surface_id;	44 DVLOG(3) << __FUNCTION__ << ": surface_id: " << surface_id;

45 DCHECK(!pending_surface_created_cb_.is_null());	45 DCHECK(!pending_surface_created_cb_.is_null());

46 pending_surface_created_cb_.Run(surface_id);	46 pending_surface_created_cb_.Run(surface_id);

47 pending_surface_created_cb_.Reset();	47 pending_surface_created_cb_.Reset();

48 }	48 }

49	49

	50 void RendererSurfaceViewManager::OnDestruct() {

	51 delete this;

	52 }

	53

50 } // namespace content	54 } // namespace content

OLD	NEW