components/contextual_search/renderer/overlay_js_render_frame_observer.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/contextual_search/renderer/overlay_js_render_frame_observer.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/contextual_search/renderer/overlay_js_render_frame_observer.h ('k') | components/dom_distiller/content/renderer/distillability_agent.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/contextual_search/renderer/overlay_js_render_frame_observer .h"	5 #include "components/contextual_search/renderer/overlay_js_render_frame_observer .h"

6	6

7 #include <utility>	7 #include <utility>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "components/contextual_search/renderer/contextual_search_wrapper.h"	10 #include "components/contextual_search/renderer/contextual_search_wrapper.h"

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51	51

52 void OverlayJsRenderFrameObserver::DidFinishLoad() {	52 void OverlayJsRenderFrameObserver::DidFinishLoad() {

53 // If no message about the Contextual Search overlay was received at this	53 // If no message about the Contextual Search overlay was received at this

54 // point, there will not be one; remove the OverlayPageNotifierService	54 // point, there will not be one; remove the OverlayPageNotifierService

55 // from the registry.	55 // from the registry.

56 render_frame()	56 render_frame()

57 ->GetServiceRegistry()	57 ->GetServiceRegistry()

58 ->RemoveService<mojom::OverlayPageNotifierService>();	58 ->RemoveService<mojom::OverlayPageNotifierService>();

59 }	59 }

60	60

	61 void OverlayJsRenderFrameObserver::OnDestruct() {

	62 delete this;

	63 }

	64

61 } // namespace contextual_search	65 } // namespace contextual_search

OLD	NEW