FX_BOOL considered harmful.

FX_BOOL considered harmful.

The manual edits fix bool/int mismatches that have existed
throughout the code.  Along the way we convert "bool"
functions returning values outside of 0|1 to int, convert
int functions returning only 0|1 to bool, and make internal
functions take an int* (although a bool* would be saner) to
correspond to a public API.

[Tom Sepez, 2015-07-22 21:53:37]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-07-22 21:54:43]

Lei, for review.

Hmm, was hoping reitveld would show only manually changed files with a "1" link,
but looks like all of them are there.

[Lei Zhang, 2015-07-22 22:21:14]

On 2015/07/22 21:54:43, Tom Sepez wrote:
> Lei, for review.
> 
> Hmm, was hoping reitveld would show only manually changed files with a "1"
link,
> but looks like all of them are there.

Do you have the list of files that changed? All the files have the "1" link. :(

[Tom Sepez, 2015-07-22 23:22:25]

On 2015/07/22 22:21:14, Lei Zhang wrote:
> On 2015/07/22 21:54:43, Tom Sepez wrote:
> > Lei, for review.
> > 
> > Hmm, was hoping reitveld would show only manually changed files with a "1"
> link,
> > but looks like all of them are there.
> 
> Do you have the list of files that changed? All the files have the "1" link.
:(

core/include/fxcrt/fx_system.h
core/include/fxge/fx_dib.h
core/include/fxge/fx_font.h
core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp
core/src/fpdftext/fpdf_text.cpp
core/src/fxcodec/codec/codec_int.h
core/src/fxcodec/codec/fx_codec_flate.cpp
core/src/fxcodec/codec/fx_codec_jpeg.cpp
core/src/fxcodec/jbig2/JBig2_Context.cpp
core/src/fxcodec/jbig2/JBig2_GeneralDecoder.cpp
core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.cpp
core/src/fxcrt/fx_basic_gcc.cpp
core/src/fxge/ge/fx_ge_fontmap.cpp
core/src/fxge/ge/fx_ge_linux.cpp
fpdfsdk/src/fpdf_sysfontinfo.cpp
fpdfsdk/src/fpdf_transformpage.cpp
fpdfsdk/src/javascript/PublicMethods.cpp

[Tom Sepez, 2015-07-23 00:12:10]

On 2015/07/22 23:22:25, Tom Sepez wrote:
> On 2015/07/22 22:21:14, Lei Zhang wrote:
> > On 2015/07/22 21:54:43, Tom Sepez wrote:
> > > Lei, for review.
> > > 
> > > Hmm, was hoping reitveld would show only manually changed files with a "1"
> > link,
> > > but looks like all of them are there.
> > 
> > Do you have the list of files that changed? All the files have the "1" link.
> :(
> 
> core/include/fxcrt/fx_system.h
> core/include/fxge/fx_dib.h
> core/include/fxge/fx_font.h
> core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp
> core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp
> core/src/fpdftext/fpdf_text.cpp
> core/src/fxcodec/codec/codec_int.h
> core/src/fxcodec/codec/fx_codec_flate.cpp
> core/src/fxcodec/codec/fx_codec_jpeg.cpp
> core/src/fxcodec/jbig2/JBig2_Context.cpp
> core/src/fxcodec/jbig2/JBig2_GeneralDecoder.cpp
> core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.cpp
> core/src/fxcrt/fx_basic_gcc.cpp
> core/src/fxge/ge/fx_ge_fontmap.cpp
> core/src/fxge/ge/fx_ge_linux.cpp
> fpdfsdk/src/fpdf_sysfontinfo.cpp
> fpdfsdk/src/fpdf_transformpage.cpp
> fpdfsdk/src/javascript/PublicMethods.cpp

Maybe the thing to do is for me to extract these fixups into their own CL
and land it first.  Then land a purely automatic CL (plus removing the defs
in fx_system.h. I'm having difficulty merging this forward given my prior CL !!!

[Tom Sepez, 2015-07-23 01:19:48]

> Maybe the thing to do is for me to extract these fixups into their own CL
> and land it first.  Then land a purely automatic CL (plus removing the defs
> in fx_system.h. I'm having difficulty merging this forward given my prior CL
!!!

Let's retire this CL in favor of this one first:
 https://codereview.chromium.org/1253603002

[Tom Sepez, 2015-07-23 18:51:05]

On 2015/07/23 01:19:48, Tom Sepez wrote:
> > Maybe the thing to do is for me to extract these fixups into their own CL
> > and land it first.  Then land a purely automatic CL (plus removing the defs
> > in fx_system.h. I'm having difficulty merging this forward given my prior CL
> !!!
> 
> Let's retire this CL in favor of this one first:
>  https://codereview.chromium.org/1253603002

Closing without landing, look for part 2 presently.