FX_BOOL considered harmful.

fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/pdfwindow/PDFWindow.h"
 #include "../../include/pdfwindow/PWL_Wnd.h"
 #include "../../include/pdfwindow/PWL_ListCtrl.h"
 
@@ skipping 34 matching lines @@
         return m_ptScroll;
 }
 
 CPDF_Rect CPWL_ListCtrl::GetScrollArea() const
 {
         return m_rcContent;
 }
 
 void CPWL_ListCtrl::ResetFace()
 {
-        ResetAll(FALSE, 0);
+        ResetAll(false, 0);
 }
 
 void CPWL_ListCtrl::ResetContent(int32_t nStart)
 {
         if (nStart < 0)
                 nStart = 0;
         if (nStart >= 0 && nStart < m_aChildren.GetSize())
-                ResetAll(TRUE, nStart);
+                ResetAll(true, nStart);
 }
 
 FX_FLOAT CPWL_ListCtrl::GetContentsHeight(FX_FLOAT fLimitWidth)
 {
         FX_FLOAT fRet = m_fTopSpace;
 
         FX_FLOAT fBorderWidth = (FX_FLOAT)GetBorderWidth();
 
         if (fLimitWidth > fBorderWidth* 2)
         {
@@ skipping 10 matching lines @@
                 }
 
                 fRet -= m_fItemSpace;
         }
 
         fRet += m_fBottomSpace;
 
         return fRet;
 }
 
-void CPWL_ListCtrl::ResetAll(FX_BOOL bMove, int32_t nStart)
+void CPWL_ListCtrl::ResetAll(bool bMove, int32_t nStart)
 {
         CPDF_Rect rcClient = GetClientRect();
 
         FX_FLOAT fWidth = rcClient.Width();
 
         FX_FLOAT fy = 0.0f - m_fTopSpace;
 
         if (nStart-1 >= 0 && nStart-1 < m_aChildren.GetSize())
                 if (CPWL_Wnd* pChild = m_aChildren.GetAt(nStart-1))
                         fy = pChild->GetWindowRect().bottom - m_fItemSpace;
 
         for (int32_t i=nStart,sz=m_aChildren.GetSize(); i<sz; i++)
         {
                 if (CPWL_Wnd* pChild = m_aChildren.GetAt(i))
                 {
                         FX_FLOAT fLeft = pChild->GetItemLeftMargin();
                         FX_FLOAT fRight = pChild->GetItemRightMargin();
 
                         pChild->SetChildMatrix(
                                 CPDF_Matrix(1,0,0,1,
                                 rcClient.left - m_ptScroll.x,
                                 rcClient.top - m_ptScroll.y)
                                 );
 
                         if (bMove)
                         {
                                 FX_FLOAT fItemHeight = pChild->GetItemHeight(fWidth - fLeft - fRight);
-                                pChild->Move(CPDF_Rect(fLeft, fy-fItemHeight, fWidth - fRight, fy), TRUE, FALSE);
+                                pChild->Move(CPDF_Rect(fLeft, fy-fItemHeight, fWidth - fRight, fy), true, false);
                                 fy -= fItemHeight;
                                 fy -= m_fItemSpace;
                         }
                 }
         }
 
         fy += m_fItemSpace;
 
         fy -= m_fBottomSpace;
 
@@ skipping 103 matching lines @@
 CPDF_Rect CPWL_ListCtrl::OutToIn(const CPDF_Rect& rect) const
 {
         CPDF_Rect rcClient = GetClientRect();
 
         return CPDF_Rect(rect.left - rcClient.left + m_ptScroll.x,
                 rect.bottom - rcClient.top + m_ptScroll.y,
                 rect.right - rcClient.left + m_ptScroll.x,
                 rect.top - rcClient.top + m_ptScroll.y);
 }