FX_BOOL considered harmful.

fpdfsdk/include/fxedit/fxet_list.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FPDFSDK_INCLUDE_FXEDIT_FXET_LIST_H_
 #define FPDFSDK_INCLUDE_FXEDIT_FXET_LIST_H_
 
 #include "../../../core/include/fpdfapi/fpdf_parser.h"  // For CPDF_Point.
@@ skipping 13 matching lines @@
                 x = other_x;
                 y = other_y;
         }
 
         void Default()
         {
                 x = 0.0f;
                 y = 0.0f;
         }
 
-        FX_BOOL operator != (const CLST_Size & size) const
+        bool operator != (const CLST_Size & size) const
         {
                 return FXSYS_memcmp(this, &size, sizeof(CLST_Size)) != 0;
         }
 
         FX_FLOAT x,y;
 };
 
 class CLST_Rect : public CPDF_Rect
 {
 public:
@@ skipping 29 matching lines @@
         const CLST_Rect operator = (const CPDF_Rect & rect)
         {
                 left = rect.left;
                 top = rect.top;
                 right = rect.right;
                 bottom = rect.bottom;
 
                 return *this;
         }
 
-        FX_BOOL operator == (const CLST_Rect & rect) const
+        bool operator == (const CLST_Rect & rect) const
         {
                 return FXSYS_memcmp(this, &rect, sizeof(CLST_Rect)) == 0;
         }
 
-        FX_BOOL operator != (const CLST_Rect & rect) const
+        bool operator != (const CLST_Rect & rect) const
         {
                 return FXSYS_memcmp(this, &rect, sizeof(CLST_Rect)) != 0;
         }
 
         FX_FLOAT Width() const
         {
                 return right - left;
         }
 
         FX_FLOAT Height() const
@@ skipping 55 matching lines @@
 public:
         CFX_ListItem();
         virtual ~CFX_ListItem();
 
         void                                                    SetFontMap(IFX_Edit_FontMap * pFontMap);
         IFX_Edit_Iterator*                              GetIterator() const;
         IFX_Edit*                                               GetEdit() const;
 
 public:
         void                                                    SetRect(const CLST_Rect & rect);
-        void                                                    SetSelect(FX_BOOL bSelected);
-        void                                                    SetCaret(FX_BOOL bCaret);
+        void                                                    SetSelect(bool bSelected);
+        void                                                    SetCaret(bool bCaret);
         void                                                    SetText(const FX_WCHAR* text);
         void                                                    SetFontSize(FX_FLOAT fFontSize);
         CFX_WideString                                  GetText() const;
 
         CLST_Rect                                               GetRect() const;
-        FX_BOOL                                                 IsSelected() const;
-        FX_BOOL                                                 IsCaret() const;
+        bool                                                    IsSelected() const;
+        bool                                                    IsCaret() const;
         FX_FLOAT                                                GetItemHeight() const;
         FX_WORD                                                 GetFirstChar() const;
 
 private:
         IFX_Edit*                                               m_pEdit;
-        FX_BOOL                                                 m_bSelected;
-        FX_BOOL                                                 m_bCaret;
+        bool                                                    m_bSelected;
+        bool                                                    m_bCaret;
         CLST_Rect                                               m_rcListItem;
 };
 
 class CFX_ListContainer
 {
 public:
         CFX_ListContainer() : m_rcPlate(0.0f,0.0f,0.0f,0.0f), m_rcContent(0.0f,0.0f,0.0f,0.0f){}
         virtual ~CFX_ListContainer(){}
         virtual void                                    SetPlateRect(const CPDF_Rect & rect){m_rcPlate = rect;}
         CPDF_Rect                                               GetPlateRect() const{return m_rcPlate;}
@@ skipping 11 matching lines @@
                                                                                                                                                         CPDF_Point ptRightBottom = OuterToInner(CPDF_Point(rect.right,rect.bottom));
                                                                                                                                                         return CLST_Rect(ptLeftTop.x,ptLeftTop.y,ptRightBottom.x,ptRightBottom.y);}
 private:
         CPDF_Rect                                               m_rcPlate;
         CLST_Rect                                               m_rcContent;            //positive forever!
 };
 
 template<class TYPE> class CLST_ArrayTemplate : public CFX_ArrayTemplate<TYPE>
 {
 public:
-        FX_BOOL IsEmpty() { return CFX_ArrayTemplate<TYPE>::GetSize() <= 0; }
+        bool IsEmpty() { return CFX_ArrayTemplate<TYPE>::GetSize() <= 0; }
         TYPE GetAt(int32_t nIndex) const { if (nIndex >= 0 && nIndex < CFX_ArrayTemplate<TYPE>::GetSize()) return CFX_ArrayTemplate<TYPE>::GetAt(nIndex); return NULL;}
         void RemoveAt(int32_t nIndex){if (nIndex >= 0 && nIndex < CFX_ArrayTemplate<TYPE>::GetSize()) CFX_ArrayTemplate<TYPE>::RemoveAt(nIndex);}
 };
 
 class CFX_List : protected CFX_ListContainer , public IFX_List
 {
 public:
         CFX_List();
         virtual ~CFX_List();
 
 public:
         virtual void                                    SetFontMap(IFX_Edit_FontMap * pFontMap);
         virtual void                                    SetFontSize(FX_FLOAT fFontSize);
 
         virtual CPDF_Rect                               GetPlateRect() const;
         virtual CPDF_Rect                               GetContentRect() const;
 
         virtual FX_FLOAT                                GetFontSize() const;
         virtual IFX_Edit*                               GetItemEdit(int32_t nIndex) const;
         virtual int32_t                         GetCount() const;
-        virtual FX_BOOL                                 IsItemSelected(int32_t nIndex) const;
+        virtual bool                                    IsItemSelected(int32_t nIndex) const;
         virtual FX_FLOAT                                GetFirstHeight() const;
 
-        virtual void                                    SetMultipleSel(FX_BOOL bMultiple);
-        virtual FX_BOOL                                 IsMultipleSel() const;
-        virtual FX_BOOL                                 IsValid(int32_t nItemIndex) const;
+        virtual void                                    SetMultipleSel(bool bMultiple);
+        virtual bool                                    IsMultipleSel() const;
+        virtual bool                                    IsValid(int32_t nItemIndex) const;
         virtual int32_t                         FindNext(int32_t nIndex,FX_WCHAR nChar) const;
 
 protected:
         virtual void                                    Empty();
 
         void                                                    AddItem(const FX_WCHAR* str);
         virtual void                                    ReArrange(int32_t nItemIndex);
 
         virtual CPDF_Rect                               GetItemRect(int32_t nIndex) const;
         CFX_WideString                                  GetItemText(int32_t nIndex) const;
 
-        void                                                    SetItemSelect(int32_t nItemIndex, FX_BOOL bSelected);
-        void                                                    SetItemCaret(int32_t nItemIndex, FX_BOOL bCaret);
+        void                                                    SetItemSelect(int32_t nItemIndex, bool bSelected);
+        void                                                    SetItemCaret(int32_t nItemIndex, bool bCaret);
 
         virtual int32_t                         GetItemIndex(const CPDF_Point & point) const;
         int32_t                                         GetFirstSelected() const;
         int32_t                                         GetLastSelected() const;
         FX_WCHAR                                                Toupper(FX_WCHAR c) const;
 
 private:
         CLST_ArrayTemplate<CFX_ListItem*>       m_aListItems;
         FX_FLOAT                                                        m_fFontSize;
         IFX_Edit_FontMap*                                       m_pFontMap;
-        FX_BOOL                                                         m_bMultiple;
+        bool                                                            m_bMultiple;
 };
 
 struct CPLST_Select_Item
 {
         CPLST_Select_Item(int32_t other_nItemIndex, int32_t other_nState)
         {
                 nItemIndex = other_nItemIndex;
                 nState = other_nState;
         }
 
         int32_t         nItemIndex;
         int32_t         nState; //0:normal select -1:to deselect 1: to select
 };
 
 class CPLST_Select
 {
 public:
         CPLST_Select();
         virtual ~CPLST_Select();
 
 public:
         void                                                    Add(int32_t nItemIndex);
         void                                                    Add(int32_t nBeginIndex, int32_t nEndIndex);
         void                                                    Sub(int32_t nItemIndex);
         void                                                    Sub(int32_t nBeginIndex, int32_t nEndIndex);
-        FX_BOOL                                                 IsExist(int32_t nItemIndex) const;
+        bool                                                    IsExist(int32_t nItemIndex) const;
         int32_t                                         Find(int32_t nItemIndex) const;
         int32_t                                         GetCount() const;
         int32_t                                         GetItemIndex(int32_t nIndex) const;
         int32_t                                         GetState(int32_t nIndex) const;
         void                                                    Done();
         void                                                    DeselectAll();
 
 private:
         CFX_ArrayTemplate<CPLST_Select_Item*>   m_aItems;
 };
 
 class CFX_ListCtrl : public CFX_List
 {
 public:
         CFX_ListCtrl();
         virtual ~CFX_ListCtrl();
 
 public:
         void                                                    SetNotify(IFX_List_Notify * pNotify);
 
-        void                                                    OnMouseDown(const CPDF_Point & point,FX_BOOL bShift,FX_BOOL bCtrl);
-        void                                                    OnMouseMove(const CPDF_Point & point,FX_BOOL bShift,FX_BOOL bCtrl);
-        void                                                    OnVK_UP(FX_BOOL bShift,FX_BOOL bCtrl);
-        void                                                    OnVK_DOWN(FX_BOOL bShift,FX_BOOL bCtrl);
-        void                                                    OnVK_LEFT(FX_BOOL bShift,FX_BOOL bCtrl);
-        void                                                    OnVK_RIGHT(FX_BOOL bShift,FX_BOOL bCtrl);
-        void                                                    OnVK_HOME(FX_BOOL bShift,FX_BOOL bCtrl);
-        void                                                    OnVK_END(FX_BOOL bShift,FX_BOOL bCtrl);
-        void                                                    OnVK(int32_t nItemIndex,FX_BOOL bShift,FX_BOOL bCtrl);
-        FX_BOOL                                                 OnChar(FX_WORD nChar,FX_BOOL bShift,FX_BOOL bCtrl);
+        void                                                    OnMouseDown(const CPDF_Point & point,bool bShift,bool bCtrl);
+        void                                                    OnMouseMove(const CPDF_Point & point,bool bShift,bool bCtrl);
+        void                                                    OnVK_UP(bool bShift,bool bCtrl);
+        void                                                    OnVK_DOWN(bool bShift,bool bCtrl);
+        void                                                    OnVK_LEFT(bool bShift,bool bCtrl);
+        void                                                    OnVK_RIGHT(bool bShift,bool bCtrl);
+        void                                                    OnVK_HOME(bool bShift,bool bCtrl);
+        void                                                    OnVK_END(bool bShift,bool bCtrl);
+        void                                                    OnVK(int32_t nItemIndex,bool bShift,bool bCtrl);
+        bool                                                    OnChar(FX_WORD nChar,bool bShift,bool bCtrl);
 
         virtual CPDF_Point                              InToOut(const CPDF_Point & point) const;
         virtual CPDF_Point                              OutToIn(const CPDF_Point & point) const;
         virtual CPDF_Rect                               InToOut(const CPDF_Rect & rect) const;
         virtual CPDF_Rect                               OutToIn(const CPDF_Rect & rect) const;
 
         virtual void                                    SetPlateRect(const CPDF_Rect & rect);
         void                                                    SetScrollPos(const CPDF_Point & point);
         void                                                    ScrollToListItem(int32_t nItemIndex);
         virtual CPDF_Rect                               GetItemRect(int32_t nIndex) const;
         int32_t                                         GetCaret() const {return m_nCaretIndex;}
         int32_t                                         GetSelect() const {return m_nSelItem;}
         int32_t                                         GetTopItem() const;
         virtual CPDF_Rect                               GetContentRect() const;
         virtual int32_t                         GetItemIndex(const CPDF_Point & point) const;
 
         void                                                    AddString(const FX_WCHAR* string);
         void                                                    SetTopItem(int32_t nIndex);
         void                                                    Select(int32_t nItemIndex);
         virtual void                                    SetCaret(int32_t nItemIndex);
         virtual void                                    Empty();
         virtual void                                    Cancel();
         CFX_WideString                                  GetText() const;
 
 private:
-        void                                                    SetMultipleSelect(int32_t nItemIndex, FX_BOOL bSelected);
+        void                                                    SetMultipleSelect(int32_t nItemIndex, bool bSelected);
         void                                                    SetSingleSelect(int32_t nItemIndex);
         void                                                    InvalidateItem(int32_t nItemIndex);
         void                                                    SelectItems();
-        FX_BOOL                                                 IsItemVisible(int32_t nItemIndex) const;
+        bool                                                    IsItemVisible(int32_t nItemIndex) const;
         void                                                    SetScrollInfo();
         void                                                    SetScrollPosY(FX_FLOAT fy);
         virtual void                                    ReArrange(int32_t nItemIndex);
 
 private:
         IFX_List_Notify*                                m_pNotify;
-        FX_BOOL                                                 m_bNotifyFlag;
+        bool                                                    m_bNotifyFlag;
         CPDF_Point                                              m_ptScrollPos;
         CPLST_Select                                    m_aSelItems;    //for multiple
         int32_t                                         m_nSelItem;             //for single
         int32_t                                         m_nFootIndex;   //for multiple
-        FX_BOOL                                                 m_bCtrlSel;             //for multiple
+        bool                                                    m_bCtrlSel;             //for multiple
         int32_t                                         m_nCaretIndex;  //for multiple
 };
 
 #endif  // FPDFSDK_INCLUDE_FXEDIT_FXET_LIST_H_