FX_BOOL considered harmful.

fpdfsdk/src/fxedit/fxet_pageobjs.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fxedit/fxet_stub.h"
 #include "../../include/fxedit/fx_edit.h"
 #include "../../include/fxedit/fxet_edit.h"
 
@@ skipping 114 matching lines @@
                 }
         }
 
         pDevice->RestoreState();
 }
 
 void IFX_Edit::DrawEdit(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device, IFX_Edit* pEdit, FX_COLORREF crTextFill, FX_COLORREF crTextStroke,
                                                 const CPDF_Rect& rcClip, const CPDF_Point& ptOffset, const CPVT_WordRange* pRange, IFX_SystemHandler* pSystemHandler, void* pFFLData)
 {
 
-        FX_BOOL bContinuous = pEdit->GetCharArray() == 0;
+        bool bContinuous = pEdit->GetCharArray() == 0;
         if (pEdit->GetCharSpace() > 0.0f)
-                bContinuous = FALSE;
+                bContinuous = false;
 
         FX_WORD SubWord = pEdit->GetPasswordChar();
         FX_FLOAT fFontSize = pEdit->GetFontSize();
         CPVT_WordRange wrSelect = pEdit->GetSelectWordRange();
         int32_t nHorzScale = pEdit->GetHorzScale();
 
         FX_COLORREF crCurFill = crTextFill;
         FX_COLORREF crOldFill = crCurFill;
 
-        FX_BOOL bSelect = FALSE;
+        bool bSelect = false;
         const FX_COLORREF crWhite = ArgbEncode(255,255,255,255);
         const FX_COLORREF crSelBK = ArgbEncode(255,0,51,113);
 
         CFX_ByteTextBuf sTextBuf;
         int32_t nFontIndex = -1;
         CPDF_Point ptBT(0.0f,0.0f);
 
         pDevice->SaveState();
 
         if (!rcClip.IsEmpty())
@@ skipping 113 matching lines @@
 }
 
 void IFX_Edit::DrawRichEdit(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device, IFX_Edit* pEdit,
                                                 const CPDF_Rect& rcClip, const CPDF_Point& ptOffset, const CPVT_WordRange* pRange)
 {
         //FX_FLOAT fFontSize = pEdit->GetFontSize();
         CPVT_WordRange wrSelect = pEdit->GetSelectWordRange();
 
         FX_COLORREF crCurText = ArgbEncode(255, 0,0,0);
         FX_COLORREF crOld = crCurText;
-        FX_BOOL bSelect = FALSE;
+        bool bSelect = false;
         const FX_COLORREF crWhite = ArgbEncode(255,255,255,255);
         const FX_COLORREF crSelBK = ArgbEncode(255,0,51,113);
 
         CFX_ByteTextBuf sTextBuf;
         CPVT_WordProps wp;
         CPDF_Point ptBT(0.0f,0.0f);
 
         pDevice->SaveState();
 
         if (!rcClip.IsEmpty())
@@ skipping 111 matching lines @@
         CPDF_PathData* pPathData = pPathObj->m_Path.GetModify();
         pPathData->AppendRect(rcFill.left,rcFill.bottom,rcFill.right,rcFill.top);
 
         FX_FLOAT rgb[3];
         rgb[0] = FXARGB_R(crFill) / 255.0f ;
         rgb[1] = FXARGB_G(crFill) / 255.0f;
         rgb[2] = FXARGB_B(crFill) / 255.0f;
         pPathObj->m_ColorState.SetFillColor(CPDF_ColorSpace::GetStockCS(PDFCS_DEVICERGB), rgb, 3);
 
         pPathObj->m_FillType = FXFILL_ALTERNATE;
-        pPathObj->m_bStroke = FALSE;
+        pPathObj->m_bStroke = false;
 
         pPageObjs->InsertObject(pPageObjs->GetLastObjectPosition(),pPathObj);
 }
 
 static CPDF_TextObject* AddTextObjToPageObjects(CPDF_PageObjects* pPageObjs, FX_COLORREF crText,
                                                          CPDF_Font* pFont, FX_FLOAT fFontSize, FX_FLOAT fCharSpace, int32_t nHorzScale,
                                                          const CPDF_Point& point, const CFX_ByteString& text)
 {
         CPDF_TextObject* pTxtObj = new CPDF_TextObject;
 
@@ skipping 208 matching lines @@
                                         rcUnderline.right += ptOffset.x;
                                         rcUnderline.top += ptOffset.y;
                                         rcUnderline.bottom += ptOffset.y;
                                         AddRectToPageObjects(pPageObjects, color, rcUnderline);
                                 }
                         }
                 }
         }
 }