Fix FX_BOOL type mismatches.

Fix FX_BOOL type mismatches.

Extracted from https://codereview.chromium.org/1252613002/

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/065e9321b84fc0490f3da9099e8840c65e06868d

[Tom Sepez, 2015-07-23 01:20:06]

For review.

[Lei Zhang, 2015-07-23 01:42:16]

Do you think we can change MapFont's bExact parameter to be a bool* in
public/fpdf_sysfontinfo.h, and use bools internally for the various MapFont
calls? Also change bItalic while we are at it. I think PDFium embedders can
survive this one time public API change.

[Tom Sepez, 2015-07-23 15:33:03]

On 2015/07/23 01:42:16, Lei Zhang wrote:
> Do you think we can change MapFont's bExact parameter to be a bool* in
> public/fpdf_sysfontinfo.h, and use bools internally for the various MapFont
> calls? Also change bItalic while we are at it. I think PDFium embedders can
> survive this one time public API change.
No, it has to be a C (not C++) API, so bool doesn't exist.  It would need to be
a synonym for an int type that happens to be the same size as bool, so I figured
it was better to sutick with the C conventions.

[Tom Sepez, 2015-07-23 16:59:48]

On 2015/07/23 15:33:03, Tom Sepez wrote:
> On 2015/07/23 01:42:16, Lei Zhang wrote:
> > Do you think we can change MapFont's bExact parameter to be a bool* in
> > public/fpdf_sysfontinfo.h, and use bools internally for the various MapFont
> > calls? Also change bItalic while we are at it. I think PDFium embedders can
> > survive this one time public API change.
> No, it has to be a C (not C++) API, so bool doesn't exist.  It would need to
be
> a synonym for an int type that happens to be the same size as bool, so I
figured
> it was better to sutick with the C conventions.
There is, FPDF_BOOL, however in the API, but it's an int synonym.  We could make
them
be FX_BOOLS rather than ints for the sake of clarity in the public files if you
like.

[Lei Zhang, 2015-07-23 18:24:35]

On 2015/07/23 16:59:48, Tom Sepez wrote:
> On 2015/07/23 15:33:03, Tom Sepez wrote:
> > On 2015/07/23 01:42:16, Lei Zhang wrote:
> > > Do you think we can change MapFont's bExact parameter to be a bool* in
> > > public/fpdf_sysfontinfo.h, and use bools internally for the various
MapFont
> > > calls? Also change bItalic while we are at it. I think PDFium embedders
can
> > > survive this one time public API change.
> > No, it has to be a C (not C++) API, so bool doesn't exist.  It would need to
> be
> > a synonym for an int type that happens to be the same size as bool, so I
> figured
> > it was better to sutick with the C conventions.
> There is, FPDF_BOOL, however in the API, but it's an int synonym.  We could
make
> them
> be FX_BOOLS rather than ints for the sake of clarity in the public files if
you
> like.

lgtm

Oh, right. I keep forgetting about the possibility of using the library with C.
Anyway, FPDF_BOOL in the public API SGTM.

[Tom Sepez, 2015-07-23 18:34:53]

Committed patchset #3 (id:40001) manually as
065e9321b84fc0490f3da9099e8840c65e06868d (presubmit successful).