FX_BOOL considered harmful.

fpdfsdk/src/jsapi/fxjs_v8.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../core/include/fxcrt/fx_basic.h"
 #include "../../../core/include/fxcrt/fx_ext.h"
 #include "../../include/jsapi/fxjs_v8.h"
 #include "../../include/fsdk_define.h"
@@ skipping 24 matching lines @@
         CJS_PrivateData():ObjDefID(-1), pPrivate(NULL) {}
         int ObjDefID;
         void*   pPrivate;
 };
 
 
 class CJS_ObjDefintion
 {
 public:
         CJS_ObjDefintion(v8::Isolate* isolate, const wchar_t* sObjName, FXJSOBJTYPE eObjType, LP_CONSTRUCTOR pConstructor, LP_DESTRUCTOR pDestructor, unsigned bApplyNew):
-          objName(sObjName), objType(eObjType), m_pConstructor(pConstructor), m_pDestructor(pDestructor),m_bApplyNew(bApplyNew),m_bSetAsGlobalObject(FALSE)
+          objName(sObjName), objType(eObjType), m_pConstructor(pConstructor), m_pDestructor(pDestructor),m_bApplyNew(bApplyNew),m_bSetAsGlobalObject(false)
           {
                   v8::Isolate::Scope isolate_scope(isolate);
                   v8::HandleScope handle_scope(isolate);
 
                   v8::Local<v8::ObjectTemplate> objTemplate = v8::ObjectTemplate::New(isolate);
                   objTemplate->SetInternalFieldCount(2);
                   m_objTemplate.Reset(isolate, objTemplate);
 
                  //Document as the global object.
                   if(FXSYS_wcscmp(sObjName, L"Document") == 0)
                   {
-                         m_bSetAsGlobalObject = TRUE;
+                         m_bSetAsGlobalObject = true;
                   }
 
           }
           ~CJS_ObjDefintion()
           {
                   m_objTemplate.Reset();
                   m_StaticObj.Reset();
           }
 public:
         const wchar_t* objName;
         FXJSOBJTYPE objType;
         LP_CONSTRUCTOR m_pConstructor;
         LP_DESTRUCTOR m_pDestructor;
         unsigned m_bApplyNew;
-        FX_BOOL m_bSetAsGlobalObject;
+        bool    m_bSetAsGlobalObject;
 
         v8::Global<v8::ObjectTemplate> m_objTemplate;
         v8::Global<v8::Object> m_StaticObj;
 };
 
 int JS_DefineObj(IJS_Runtime* pJSRuntime, const wchar_t* sObjName, FXJSOBJTYPE eObjType, LP_CONSTRUCTOR pConstructor, LP_DESTRUCTOR pDestructor, unsigned bApplyNew)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::HandleScope handle_scope(isolate);
@@ skipping 979 matching lines @@
 {
         return d != d;
 }
 
 double JS_LocalTime(double d)
 {
         return JS_GetDateTime() + _getDaylightSavingTA(d);
 }
 
 //JavaScript time implement End.