FX_BOOL considered harmful.

fpdfsdk/include/javascript/JS_Value.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FPDFSDK_INCLUDE_JAVASCRIPT_JS_VALUE_H_
 #define FPDFSDK_INCLUDE_JAVASCRIPT_JS_VALUE_H_
 
 #include "../../../core/include/fxcrt/fx_basic.h"
@@ skipping 45 matching lines @@
         void operator = (float);
         void operator = (CJS_Object*);
         void operator = (CJS_Document*);
         void operator = (v8::Local<v8::Object>);
         void operator = (CJS_Array &);
         void operator = (CJS_Date &);
         void operator = (const FX_WCHAR* pWstr);
         void operator = (const FX_CHAR* pStr);
         void operator = (CJS_Value value);
 
-        FX_BOOL IsArrayObject() const;
-        FX_BOOL IsDateObject() const;
+        bool IsArrayObject() const;
+        bool    IsDateObject() const;
         FXJSVALUETYPE GetType() const;
 
-        FX_BOOL ConvertToArray(CJS_Array &) const;
-        FX_BOOL ConvertToDate(CJS_Date &) const;
+        bool ConvertToArray(CJS_Array &) const;
+        bool ConvertToDate(CJS_Date &) const;
 
         v8::Isolate* GetIsolate() {return m_isolate;}
 protected:
         v8::Local<v8::Value> m_pValue;
         FXJSVALUETYPE m_eType;
         v8::Isolate* m_isolate;
 };
 
 class CJS_Parameters : public CFX_ArrayTemplate<CJS_Value>
 {
 public:
         void push_back(const CJS_Value& newElement) {
                 CFX_ArrayTemplate<CJS_Value>::Add(newElement);
         }
         int size() const {
                 return CFX_ArrayTemplate<CJS_Value>::GetSize();
         }
 };
 
 class CJS_PropValue: public CJS_Value
 {
 public:
         CJS_PropValue(const CJS_Value&);
         CJS_PropValue(v8::Isolate* isolate);
         ~CJS_PropValue();
 public:
-        FX_BOOL IsSetting();
-        FX_BOOL IsGetting();
+        bool IsSetting();
+        bool IsGetting();
         void operator<<(int);
         void operator>>(int&) const;
         void operator<<(bool);
         void operator>>(bool&) const;
         void operator<<(double);
         void operator>>(double&) const;
         void operator<<(CJS_Object* pObj);
         void operator>>(CJS_Object*& ppObj) const;
         void operator<<(CJS_Document* pJsDoc);
         void operator>>(CJS_Document*& ppJsDoc) const;
         void operator<<(CFX_ByteString);
         void operator>>(CFX_ByteString&) const;
         void operator<<(CFX_WideString);
         void operator>>(CFX_WideString&) const;
         void operator<<(const FX_WCHAR* c_string);
         void operator<<(JSFXObject);
         void operator>>(JSFXObject&) const;
         void operator>>(CJS_Array& array) const;
         void operator<<(CJS_Array& array);
         void operator<<(CJS_Date& date);
         void operator>>(CJS_Date& date) const;
         operator v8::Local<v8::Value>() const;
         void StartSetting();
         void StartGetting();
 private:
-        FX_BOOL m_bIsSetting;
+        bool m_bIsSetting;
 };
 
 class CJS_Array
 {
 public:
         CJS_Array(v8::Isolate* isolate);
         virtual ~CJS_Array();
 
         void Attach(v8::Local<v8::Array> pArray);
         void GetElement(unsigned index,CJS_Value &value);
         void SetElement(unsigned index,CJS_Value value);
     int GetLength();
-        FX_BOOL IsAttached();
+        bool IsAttached();
         operator v8::Local<v8::Array>();
 
         v8::Isolate* GetIsolate() {return m_isolate;}
 private:
         v8::Local<v8::Array> m_pArray;
         v8::Isolate* m_isolate;
 };
 
 class CJS_Date
 {
@@ skipping 23 matching lines @@
         int     GetSeconds();
         void    SetSeconds(int seconds);
 
         operator v8::Local<v8::Value>();
         operator double() const;
 
         CFX_WideString  ToString() const;
 
         static double   MakeDate(int year, int mon, int mday,int hour, int min, int sec,int ms);
 
-        FX_BOOL IsValidDate();
+        bool    IsValidDate();
 
 protected:
         v8::Local<v8::Value> m_pDate;
         v8::Isolate* m_isolate;
 };
 
 #endif  // FPDFSDK_INCLUDE_JAVASCRIPT_JS_VALUE_H_