FX_BOOL considered harmful.

fpdfsdk/include/javascript/JS_Object.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FPDFSDK_INCLUDE_JAVASCRIPT_JS_OBJECT_H_
 #define FPDFSDK_INCLUDE_JAVASCRIPT_JS_OBJECT_H_
 
 #include "../fsdk_define.h"  // For FX_UINT
@@ skipping 30 matching lines @@
 
 class CJS_Object
 {
 public:
         CJS_Object(JSFXObject pObject);
         virtual ~CJS_Object(void);
 
         void                                            MakeWeak();
         void                                            Dispose();
 
-        virtual FX_BOOL                         IsType(const FX_CHAR* sClassName){return TRUE;};
+        virtual bool                            IsType(const FX_CHAR* sClassName){return true;};
         virtual CFX_ByteString          GetClassName(){return "";};
 
-        virtual FX_BOOL                         InitInstance(IFXJS_Context* cc){return TRUE;};
-        virtual FX_BOOL                         ExitInstance(){return TRUE;};
+        virtual bool                            InitInstance(IFXJS_Context* cc){return true;};
+        virtual bool                            ExitInstance(){return true;};
 
         operator                                        JSFXObject () {return v8::Local<v8::Object>::New(m_pIsolate, m_pObject);}
         operator                                        CJS_EmbedObj* (){return m_pEmbedObj;};
 
         void                                            SetEmbedObject(CJS_EmbedObj* pObj){m_pEmbedObj = pObj;};
         CJS_EmbedObj *                          GetEmbedObject(){return m_pEmbedObj;};
 
         static CPDFSDK_PageView *       JSGetPageView(IFXJS_Context* cc);
         static int                                      MsgBox(CPDFDoc_Environment* pApp, CPDFSDK_PageView* pPageView, const FX_WCHAR* swMsg, const FX_WCHAR* swTitle = NULL, FX_UINT nType = 0,FX_UINT nIcon = 0);
         static void                                     Alert(CJS_Context* pContext, const FX_WCHAR* swMsg);
@@ skipping 99 matching lines @@
 JS_TIMER_MAPARRAY& GetTimeMap();
 
 class CJS_Runtime;
 
 class CJS_Timer
 {
 public:
         CJS_Timer(CJS_EmbedObj * pObj,CPDFDoc_Environment* pApp):
                 m_nTimerID(0),
                 m_pEmbedObj(pObj),
-                m_bProcessing(FALSE),
+                m_bProcessing(false),
                 m_dwStartTime(0),
                 m_dwTimeOut(0),
                 m_dwElapse(0),
                 m_pRuntime(NULL),
                 m_nType(0),
                 m_pApp(pApp)
         {
         }
 
         virtual ~CJS_Timer()
@@ skipping 72 matching lines @@
         {
                 return m_swJScript;
         }
 
         static void TimerProc(int idEvent)
         {
                 if (CJS_Timer * pTimer = GetTimeMap().GetAt(idEvent))
                 {
                         if (!pTimer->m_bProcessing)
                         {
-                                pTimer->m_bProcessing = TRUE;
+                                pTimer->m_bProcessing = true;
                                 if (pTimer->m_pEmbedObj) pTimer->m_pEmbedObj->TimerProc(pTimer);
-                                pTimer->m_bProcessing = FALSE;
+                                pTimer->m_bProcessing = false;
                         }
                         else
                         {
                         //      TRACE(L"BUSY!\n");
                         }
                 }
         };
 
 private:
         FX_UINT                                                 m_nTimerID;
         CJS_EmbedObj*                                   m_pEmbedObj;
-        FX_BOOL                                                 m_bProcessing;
+        bool                                                    m_bProcessing;
 
         //data
         FX_DWORD                                                        m_dwStartTime;
         FX_DWORD                                                        m_dwTimeOut;
         FX_DWORD                                                m_dwElapse;
         CJS_Runtime*                                    m_pRuntime;
         CFX_WideString                                  m_swJScript;
         int                                                             m_nType; //0:Interval; 1:TimeOut
 
         CPDFDoc_Environment*                    m_pApp;
 };
 
 #endif  // FPDFSDK_INCLUDE_JAVASCRIPT_JS_OBJECT_H_