FX_BOOL considered harmful.

core/src/fxge/android/fpf_skiafontmgr.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fx_fpf.h"
 #if _FX_OS_ == _FX_ANDROID_
 #define FPF_SKIAMATCHWEIGHT_NAME1       62
 #define FPF_SKIAMATCHWEIGHT_NAME2       60
@@ skipping 85 matching lines @@
         if (dwHash < pItem->dwFamily) {
             iEnd = iMid - 1;
         } else if (dwHash > pItem->dwFamily) {
             iStart = iMid + 1;
         } else {
             return pItem->dwSubSt;
         }
     }
     return 0;
 }
-static uint32_t FPF_GetHashCode_StringA(const FX_CHAR* pStr, int32_t iLength, FX_BOOL bIgnoreCase = FALSE)
+static uint32_t FPF_GetHashCode_StringA(const FX_CHAR* pStr, int32_t iLength, bool bIgnoreCase = false)
 {
     if (!pStr) {
         return 0;
     }
     if (iLength < 0) {
         iLength = FXSYS_strlen(pStr);
     }
     const FX_CHAR* pStrEnd = pStr + iLength;
     uint32_t uHashCode = 0;
     if (bIgnoreCase) {
@@ skipping 84 matching lines @@
     if (dwStyle & FXFONT_BOLD) {
         bsFont += "Bold";
     }
     if (dwStyle & FXFONT_ITALIC) {
         bsFont += "Italic";
     }
     if (dwStyle & FXFONT_SERIF) {
         bsFont += "Serif";
     }
     bsFont += uCharset;
-    return FPF_GetHashCode_StringA(bsFont.c_str(), bsFont.GetLength(), TRUE);
+    return FPF_GetHashCode_StringA(bsFont.c_str(), bsFont.GetLength(), true);
 }
-static FX_BOOL FPF_SkiaIsCJK(uint8_t uCharset)
+static bool FPF_SkiaIsCJK(uint8_t uCharset)
 {
     return (uCharset == FXFONT_GB2312_CHARSET) || (uCharset == FXFONT_CHINESEBIG5_CHARSET)
            || (uCharset == FXFONT_HANGEUL_CHARSET) || (uCharset == FXFONT_SHIFTJIS_CHARSET);
 }
-static FX_BOOL FPF_SkiaMaybeSymbol(const CFX_ByteStringC& bsFacename)
+static bool FPF_SkiaMaybeSymbol(const CFX_ByteStringC& bsFacename)
 {
     CFX_ByteString bsName = bsFacename;
     bsName.MakeLower();
     return bsName.Find("symbol") > -1;
 }
-static FX_BOOL FPF_SkiaMaybeArabic(const CFX_ByteStringC& bsFacename)
+static bool FPF_SkiaMaybeArabic(const CFX_ByteStringC& bsFacename)
 {
     CFX_ByteString bsName = bsFacename;
     bsName.MakeLower();
     return bsName.Find("arabic") > -1;
 }
 CFPF_SkiaFontMgr::CFPF_SkiaFontMgr()
-    : m_bLoaded(FALSE), m_FTLibrary(NULL)
+    : m_bLoaded(false), m_FTLibrary(NULL)
 {
 }
 CFPF_SkiaFontMgr::~CFPF_SkiaFontMgr()
 {
     void *pkey = NULL;
     CFPF_SkiaFont *pValue = NULL;
     FX_POSITION pos = m_FamilyFonts.GetStartPosition();
     while (pos) {
         m_FamilyFonts.GetNextAssoc(pos, pkey, (void*&)pValue);
         if (pValue) {
             pValue->Release();
         }
     }
     m_FamilyFonts.RemoveAll();
     for (int32_t i = m_FontFaces.GetUpperBound(); i >= 0; i--) {
         CFPF_SkiaFontDescriptor *pFont = (CFPF_SkiaFontDescriptor*)m_FontFaces.ElementAt(i);
         delete pFont;
     }
     m_FontFaces.RemoveAll();
     if (m_FTLibrary) {
         FXFT_Done_FreeType(m_FTLibrary);
     }
 }
-FX_BOOL CFPF_SkiaFontMgr::InitFTLibrary()
+bool CFPF_SkiaFontMgr::InitFTLibrary()
 {
     if (m_FTLibrary == NULL) {
         FXFT_Init_FreeType(&m_FTLibrary);
     }
     return m_FTLibrary != NULL;
 }
 void CFPF_SkiaFontMgr::LoadSystemFonts()
 {
     if (m_bLoaded) {
         return;
     }
     ScanPath(FX_BSTRC("/system/fonts"));
     OutputSystemFonts();
-    m_bLoaded = TRUE;
+    m_bLoaded = true;
 }
 void CFPF_SkiaFontMgr::LoadPrivateFont(IFX_FileRead* pFontFile)
 {
 }
 void CFPF_SkiaFontMgr::LoadPrivateFont(const CFX_ByteStringC& bsFileName)
 {
 }
 void CFPF_SkiaFontMgr::LoadPrivateFont(void* pBuffer, size_t szBuffer)
 {
 }
 IFPF_Font* CFPF_SkiaFontMgr::CreateFont(const CFX_ByteStringC& bsFamilyname, uint8_t uCharset, FX_DWORD dwStyle, FX_DWORD dwMatch)
 {
     FX_DWORD dwHash = FPF_SKIAGetFamilyHash(bsFamilyname, dwStyle, uCharset);
     IFPF_Font *pFont = NULL;
     if (m_FamilyFonts.Lookup((void*)(uintptr_t)dwHash, (void*&)pFont)) {
         if (pFont) {
             return pFont->Retain();
         }
     }
     FX_DWORD dwFaceName = FPF_SKIANormalizeFontName(bsFamilyname);
     FX_DWORD dwSubst = FPF_SkiaGetSubstFont(dwFaceName);
     FX_DWORD dwSubstSans = FPF_SkiaGetSansFont(dwFaceName);
-    FX_BOOL bMaybeSymbol = FPF_SkiaMaybeSymbol(bsFamilyname);
+    bool bMaybeSymbol = FPF_SkiaMaybeSymbol(bsFamilyname);
     if (uCharset != FXFONT_ARABIC_CHARSET && FPF_SkiaMaybeArabic(bsFamilyname)) {
         uCharset = FXFONT_ARABIC_CHARSET;
     } else if (uCharset == FXFONT_ANSI_CHARSET && (dwMatch & FPF_MATCHFONT_REPLACEANSI)) {
         uCharset = FXFONT_DEFAULT_CHARSET;
     }
     int32_t nExpectVal = FPF_SKIAMATCHWEIGHT_NAME1 + FPF_SKIAMATCHWEIGHT_1 * 3 + FPF_SKIAMATCHWEIGHT_2 * 2;
     int32_t nItem = -1;
     int32_t nMax = -1;
     int32_t nGlyphNum = 0;
     for (int32_t i = m_FontFaces.GetUpperBound(); i >= 0; i--) {
         CFPF_SkiaPathFont *pFontDes = (CFPF_SkiaPathFont*)m_FontFaces.ElementAt(i);
         if(!(pFontDes->m_dwCharsets & FPF_SkiaGetCharset(uCharset))) {
             continue;
         }
         int32_t nFind = 0;
         FX_DWORD dwSysFontName = FPF_SKIANormalizeFontName(pFontDes->m_pFamily);
         if (dwFaceName == dwSysFontName) {
             nFind += FPF_SKIAMATCHWEIGHT_NAME1;
         }
-        FX_BOOL bMatchedName = (nFind == FPF_SKIAMATCHWEIGHT_NAME1);
+        bool bMatchedName = (nFind == FPF_SKIAMATCHWEIGHT_NAME1);
         if ((dwStyle & FXFONT_BOLD) == (pFontDes->m_dwStyle & FXFONT_BOLD)) {
             nFind += FPF_SKIAMATCHWEIGHT_1;
         }
         if ((dwStyle & FXFONT_ITALIC) == (pFontDes->m_dwStyle & FXFONT_ITALIC)) {
             nFind += FPF_SKIAMATCHWEIGHT_1;
         }
         if ((dwStyle & FXFONT_FIXED_PITCH) == (pFontDes->m_dwStyle & FXFONT_FIXED_PITCH)) {
             nFind += FPF_SKIAMATCHWEIGHT_2;
         }
         if ((dwStyle & FXFONT_SERIF) == (pFontDes->m_dwStyle & FXFONT_SERIF)) {
             nFind += FPF_SKIAMATCHWEIGHT_1;
         }
         if ((dwStyle & FXFONT_SCRIPT) == (pFontDes->m_dwStyle & FXFONT_SCRIPT)) {
             nFind += FPF_SKIAMATCHWEIGHT_2;
         }
         if (dwSubst == dwSysFontName || dwSubstSans == dwSysFontName) {
             nFind += FPF_SKIAMATCHWEIGHT_NAME2;
-            bMatchedName = TRUE;
+            bMatchedName = true;
         }
         if (uCharset == FXFONT_DEFAULT_CHARSET || bMaybeSymbol) {
             if (nFind > nMax && bMatchedName) {
                 nMax = nFind;
                 nItem = i;
             }
         } else if (FPF_SkiaIsCJK(uCharset)) {
             if (bMatchedName || pFontDes->m_iGlyphNum > nGlyphNum) {
                 nItem = i;
                 nGlyphNum = pFontDes->m_iGlyphNum;
@@ skipping 51 matching lines @@
         return NULL;
     }
     if (iFaceIndex < 0) {
         return NULL;
     }
     FXFT_Open_Args args;
     args.flags = FT_OPEN_PATHNAME;
     args.pathname = (FT_String*)bsFile.GetCStr();
     FXFT_Face face;
     if (FXFT_Open_Face(m_FTLibrary, &args, iFaceIndex, &face)) {
-        return FALSE;
+        return false;
     }
     FXFT_Set_Pixel_Sizes(face, 0, 64);
     return face;
 }
 FXFT_Face CFPF_SkiaFontMgr::GetFontFace(const uint8_t* pBuffer, size_t szBuffer, int32_t iFaceIndex )
 {
     if (!pBuffer || szBuffer < 1) {
         return NULL;
     }
     if (iFaceIndex < 0) {
         return NULL;
     }
     FXFT_Open_Args args;
     args.flags = FT_OPEN_MEMORY;
     args.memory_base = pBuffer;
     args.memory_size = szBuffer;
     FXFT_Face face;
     if (FXFT_Open_Face(m_FTLibrary, &args, iFaceIndex, &face)) {
-        return FALSE;
+        return false;
     }
     FXFT_Set_Pixel_Sizes(face, 0, 64);
     return face;
 }
 void CFPF_SkiaFontMgr::ScanPath(const CFX_ByteStringC& path)
 {
     void *handle = FX_OpenFolder(path.GetCStr());
     if (!handle) {
         return;
     }
     CFX_ByteString filename;
-    FX_BOOL     bFolder = FALSE;
+    bool        bFolder = false;
     while (FX_GetNextFile(handle, filename, bFolder)) {
         if (bFolder) {
             if (filename == FX_BSTRC(".") || filename == FX_BSTRC("..")) {
                 continue;
             }
         } else {
             CFX_ByteString ext = filename.Right(4);
             ext.MakeLower();
             if (ext != FX_BSTRC(".ttf") && ext != FX_BSTRC(".ttc")) {
                 continue;
@@ skipping 99 matching lines @@
         pFontDesc->m_dwStyle |= FXFONT_SYMBOLIC;
     }
     pFontDesc->m_dwCharsets = FPF_SkiaGetFaceCharset(pOS2);
     pFontDesc->m_iFaceIndex = face->face_index;
     pFontDesc->m_iGlyphNum = face->num_glyphs;
 }
 void CFPF_SkiaFontMgr::OutputSystemFonts()
 {
 }
 #endif