FX_BOOL considered harmful.

fpdfsdk/include/formfiller/FFL_Notify.h

Index: fpdfsdk/include/formfiller/FFL_Notify.h
diff --git a/fpdfsdk/include/formfiller/FFL_Notify.h b/fpdfsdk/include/formfiller/FFL_Notify.h
index 961d4b7a7961783b6ebbf797e7354e0e64796f06..8a9c04c5dfa22cae8a5fa79519334409aed6694f 100644
--- a/fpdfsdk/include/formfiller/FFL_Notify.h
+++ b/fpdfsdk/include/formfiller/FFL_Notify.h
@@ -20,35 +20,35 @@ public:
 	virtual ~CFFL_Notify();
 
 public:
-	FX_BOOL									OnSetFocus(FX_BOOL & bExit);
-	FX_BOOL									OnMouseEnter(FX_BOOL & bExit);
-	FX_BOOL									OnMouseDown(FX_BOOL & bExit);
-	FX_BOOL									OnMouseUp(FX_BOOL & bExit);
-	FX_BOOL									OnMouseExit(FX_BOOL & bExit);
-	FX_BOOL									OnKillFocus(FX_BOOL & bExit);
-
-	FX_BOOL									OnCalculate();
-	FX_BOOL									OnFormat(int iCommitKey);
-	FX_BOOL									OnValidate(CPDF_FormField* pFormField, CFX_WideString& strValue, CFX_WideString & strChange,
-											   const CFX_WideString& strChangeEx, FX_BOOL bKeyDown, FX_BOOL bModifier,
-											   FX_BOOL bShift, FX_BOOL & bRC);
-	FX_BOOL									OnKeyStroke(CPDF_FormField* pFormField, int nCommitKey, CFX_WideString& strValue, CFX_WideString& strChange,
-											   const CFX_WideString& strChangeEx, FX_BOOL bKeyDown, FX_BOOL bModifier,
-											   FX_BOOL bShift, FX_BOOL bWillCommit, FX_BOOL bFieldFull,
-											   int& nSelStart, int& nSelEnd, FX_BOOL& bRC);
+	bool									OnSetFocus(bool & bExit);
+	bool									OnMouseEnter(bool & bExit);
+	bool									OnMouseDown(bool & bExit);
+	bool									OnMouseUp(bool & bExit);
+	bool									OnMouseExit(bool & bExit);
+	bool									OnKillFocus(bool & bExit);
+
+	bool									OnCalculate();
+	bool									OnFormat(int iCommitKey);
+	bool									OnValidate(CPDF_FormField* pFormField, CFX_WideString& strValue, CFX_WideString & strChange,
+											   const CFX_WideString& strChangeEx, bool bKeyDown, bool bModifier,
+											   bool bShift, bool & bRC);
+	bool									OnKeyStroke(CPDF_FormField* pFormField, int nCommitKey, CFX_WideString& strValue, CFX_WideString& strChange,
+											   const CFX_WideString& strChangeEx, bool bKeyDown, bool bModifier,
+											   bool bShift, bool bWillCommit, bool bFieldFull,
+											   int& nSelStart, int& nSelEnd, bool& bRC);
 
 	void									BeforeNotify();
 	void									AfterNotify();
-	FX_BOOL									IsNotifying() const {return m_nNotifyFlag > 0;}
+	bool									IsNotifying() const {return m_nNotifyFlag > 0;}
 
 private:
- 	FX_BOOL									DoAAction(CPDF_AAction::AActionType eAAT, FX_BOOL & bExit);
- 	FX_BOOL									FindAAction(CPDF_AAction::AActionType eAAT,CPDF_Action & action);
- 	FX_BOOL									FindAAction(CPDF_AAction aaction,CPDF_AAction::AActionType eAAT,CPDF_Action & action);
- 	FX_BOOL									ExecuteActionTree(CPDF_AAction::AActionType eAAT, CPDF_Action & action, FX_BOOL& bExit);
- 	FX_BOOL									ExecuteAction(CPDF_AAction::AActionType eAAT,CPDF_Action & action,FX_BOOL& bExit);
+ 	bool									DoAAction(CPDF_AAction::AActionType eAAT, bool & bExit);
+ 	bool									FindAAction(CPDF_AAction::AActionType eAAT,CPDF_Action & action);
+ 	bool									FindAAction(CPDF_AAction aaction,CPDF_AAction::AActionType eAAT,CPDF_Action & action);
+ 	bool									ExecuteActionTree(CPDF_AAction::AActionType eAAT, CPDF_Action & action, bool& bExit);
+ 	bool									ExecuteAction(CPDF_AAction::AActionType eAAT,CPDF_Action & action,bool& bExit);
 
-	FX_BOOL									m_bDoActioning;
+	bool									m_bDoActioning;
 	int32_t								m_nNotifyFlag;
 };