core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.cpp - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.cpp

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.cpp

diff --git a/core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.cpp b/core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.cpp

index dd820ae4ca58f17389d2666f385f1b7cbdfc3c46..ef8454799289dd612710122b9dfd9f4124469756 100644

--- a/core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.cpp

+++ b/core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.cpp

@@ -14,9 +14,10 @@ CJBig2_HuffmanDecoder::~CJBig2_HuffmanDecoder()

}

int CJBig2_HuffmanDecoder::decodeAValue(CJBig2_HuffmanTable *pTable, int *nResult)

{

- int nVal, nTmp, i, nBits;

- nVal = 0;

- nBits = 0;

+ int i;

+ int nVal = 0;

+ int nBits = 0;

+ FX_DWORD nTmp;

while(1) {

if(m_pStream->read1Bit(&nTmp) == -1) {

return -1;