fpdfsdk/include/javascript/Icon.h - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/javascript/Icon.h

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/javascript/Icon.h

diff --git a/fpdfsdk/include/javascript/Icon.h b/fpdfsdk/include/javascript/Icon.h

index 0298005f00e829595f1ce201bfccdd50deab1907..367db7bc49acc4ccb2c576e15e24f6dc9be46099 100644

--- a/fpdfsdk/include/javascript/Icon.h

+++ b/fpdfsdk/include/javascript/Icon.h

@@ -14,7 +14,7 @@ class Icon : public CJS_EmbedObj

public:

Icon(CJS_Object* pJSObject);

virtual ~Icon();

- FX_BOOL name(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError);

+ bool name(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError);

void SetStream(CPDF_Stream* pIconStream);

CPDF_Stream* GetStream();

void SetIconName(CFX_WideString name);

« no previous file with comments | « fpdfsdk/include/javascript/IJavaScript.h ('k') | fpdfsdk/include/javascript/JS_Context.h » ('j') | no next file with comments »