FX_BOOL considered harmful.

core/src/fxcodec/jbig2/JBig2_Context.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <map>
 #include <list>
 #include "JBig2_Context.h"
 
@@ skipping 29 matching lines @@
                     JBIG2_EMBED_STREAM, pSymbolDictCache, pPause));
     } else {
         m_pGlobalContext = NULL;
     }
     JBIG2_ALLOC(m_pStream, CJBig2_BitStream(pData, dwLength));
     m_nStreamType = nStreamType;
     m_nState = JBIG2_OUT_OF_PAGE;
     JBIG2_ALLOC(m_pSegmentList, CJBig2_List<CJBig2_Segment>);
     JBIG2_ALLOC(m_pPageInfoList, CJBig2_List<JBig2PageInfo>(1));
     m_pPage = NULL;
-    m_bBufSpecified = FALSE;
+    m_bBufSpecified = false;
     m_pPause = pPause;
     m_nSegmentDecoded = 0;
     m_PauseStep = 10;
     m_pArithDecoder = NULL;
     m_pGRD = NULL;
     m_gbContext = NULL;
     m_pSegment = NULL;
     m_dwOffset = 0;
     m_ProcessiveStatus = FXCODEC_STATUS_FRAME_READY;
     m_pSymbolDictCache = pSymbolDictCache;
@@ skipping 163 matching lines @@
 int32_t CJBig2_Context::getFirstPage(uint8_t *pBuf, int32_t width, int32_t height, int32_t stride, IFX_Pause* pPause)
 {
     int32_t nRet = 0;
     if(m_pGlobalContext) {
         nRet = m_pGlobalContext->decode_EmbedOrgnazation(pPause);
         if(nRet != JBIG2_SUCCESS) {
             m_ProcessiveStatus = FXCODEC_STATUS_ERROR;
             return nRet;
         }
     }
-    m_bFirstPage = TRUE;
+    m_bFirstPage = true;
     m_PauseStep = 0;
     delete m_pPage;
     JBIG2_ALLOC(m_pPage, CJBig2_Image(width, height, stride, pBuf));
-    m_bBufSpecified = TRUE;
+    m_bBufSpecified = true;
     if(m_pPage && pPause && pPause->NeedToPauseNow()) {
         m_PauseStep = 1;
         m_ProcessiveStatus = FXCODEC_STATUS_DECODE_TOBECONTINUE;
         return nRet;
     }
     int ret = Continue(pPause);
     return ret;
 }
 int32_t CJBig2_Context::Continue(IFX_Pause* pPause)
 {
@@ skipping 42 matching lines @@
     if(nRet == JBIG2_SUCCESS) {
         m_ProcessiveStatus = FXCODEC_STATUS_DECODE_FINISH;
     } else {
         m_ProcessiveStatus = FXCODEC_STATUS_ERROR;
     }
     return nRet;
 }
 int32_t CJBig2_Context::getNextPage(uint8_t *pBuf, int32_t width, int32_t height, int32_t stride, IFX_Pause* pPause)
 {
     int32_t nRet = JBIG2_ERROR_STREAM_TYPE;
-    m_bFirstPage = FALSE;
+    m_bFirstPage = false;
     m_PauseStep = 0;
     delete m_pPage;
     JBIG2_ALLOC(m_pPage, CJBig2_Image(width, height, stride, pBuf));
-    m_bBufSpecified = TRUE;
+    m_bBufSpecified = true;
     if(m_pPage && pPause && pPause->NeedToPauseNow()) {
         m_PauseStep = 1;
         m_ProcessiveStatus = FXCODEC_STATUS_DECODE_TOBECONTINUE;
         return nRet;
     }
     return Continue(pPause);
     switch(m_nStreamType) {
         case JBIG2_FILE_STREAM:
             nRet = decodeFile(pPause);
             break;
         case JBIG2_SQUENTIAL_STREAM:
             nRet = decode_SquentialOrgnazation(pPause);
             break;
         case JBIG2_RANDOM_STREAM:
             nRet = decode_RandomOrgnazation(pPause);
             break;
         case JBIG2_EMBED_STREAM:
             nRet = decode_EmbedOrgnazation(pPause);
             break;
         default:
             return JBIG2_ERROR_STREAM_TYPE;
     }
     return nRet;
 }
 int32_t CJBig2_Context::getFirstPage(CJBig2_Image **image, IFX_Pause* pPause)
 {
     int32_t nRet;
-    m_bFirstPage = TRUE;
+    m_bFirstPage = true;
     m_PauseStep = 0;
     if(m_pGlobalContext) {
         nRet = m_pGlobalContext->decode_EmbedOrgnazation(pPause);
         if(nRet != JBIG2_SUCCESS) {
             return nRet;
         }
     }
-    m_bBufSpecified = FALSE;
+    m_bBufSpecified = false;
     return Continue(pPause);
 }
 int32_t CJBig2_Context::getNextPage(CJBig2_Image **image, IFX_Pause* pPause)
 {
     int32_t nRet;
-    m_bBufSpecified = FALSE;
-    m_bFirstPage = FALSE;
+    m_bBufSpecified = false;
+    m_bFirstPage = false;
     m_PauseStep = 0;
     switch(m_nStreamType) {
         case JBIG2_FILE_STREAM:
             nRet = decodeFile(pPause);
             break;
         case JBIG2_SQUENTIAL_STREAM:
             nRet = decode_SquentialOrgnazation(pPause);
             break;
         case JBIG2_RANDOM_STREAM:
             nRet = decode_RandomOrgnazation(pPause);
@@ skipping 235 matching lines @@
     return JBIG2_ERROR_FATAL;
 }
 int32_t CJBig2_Context::parseSymbolDict(CJBig2_Segment *pSegment, IFX_Pause* pPause)
 {
     FX_DWORD dwTemp;
     FX_WORD wFlags;
     uint8_t cSDHUFFDH, cSDHUFFDW, cSDHUFFBMSIZE, cSDHUFFAGGINST;
     CJBig2_HuffmanTable *Table_B1 = NULL, *Table_B2 = NULL, *Table_B3 = NULL, *Table_B4 = NULL, *Table_B5 = NULL;
     int32_t i, nIndex, nRet;
     CJBig2_Segment *pSeg = NULL, *pLRSeg = NULL;
-    FX_BOOL bUsed;
+    bool bUsed;
     CJBig2_Image ** SDINSYMS = NULL;
     CJBig2_SDDProc *pSymbolDictDecoder;
     JBig2ArithCtx *gbContext = NULL, *grContext = NULL;
     CJBig2_ArithDecoder *pArithDecoder;
     JBIG2_ALLOC(pSymbolDictDecoder, CJBig2_SDDProc());
     uint8_t *key = pSegment->m_pData;
-    FX_BOOL cache_hit = false;
+    bool cache_hit = false;
     if(m_pStream->readShortInteger(&wFlags) != 0) {
         m_pModule->JBig2_Error("symbol dictionary segment : data header too short.");
         nRet = JBIG2_ERROR_TOO_SHORT;
         goto failed;
     }
     pSymbolDictDecoder->SDHUFF = wFlags & 0x0001;
     pSymbolDictDecoder->SDREFAGG = (wFlags >> 1) & 0x0001;
     pSymbolDictDecoder->SDTEMPLATE = (wFlags >> 10) & 0x0003;
     pSymbolDictDecoder->SDRTEMPLATE = (wFlags >> 12) & 0x0003;
     cSDHUFFDH = (wFlags >> 2) & 0x0003;
@@ skipping 196 matching lines @@
         CJBig2_SymbolDict *value = pSegment->m_Result.sd->DeepCopy();
         if (value && kSymbolDictCacheMaxSize > 0) {
             while (m_pSymbolDictCache->size() >= kSymbolDictCacheMaxSize) {
                 delete m_pSymbolDictCache->back().second;
                 m_pSymbolDictCache->pop_back();
             }
             m_pSymbolDictCache->push_front(CJBig2_CachePair(key, value));
         }
     }
     if(wFlags & 0x0200) {
-        pSegment->m_Result.sd->m_bContextRetained = TRUE;
+        pSegment->m_Result.sd->m_bContextRetained = true;
         if(pSymbolDictDecoder->SDHUFF == 0) {
             pSegment->m_Result.sd->m_gbContext = gbContext;
         }
         if(pSymbolDictDecoder->SDREFAGG == 1) {
             pSegment->m_Result.sd->m_grContext = grContext;
         }
-        bUsed = TRUE;
+        bUsed = true;
     } else {
-        bUsed = FALSE;
+        bUsed = false;
     }
     delete pSymbolDictDecoder;
     if(SDINSYMS) {
         m_pModule->JBig2_Free(SDINSYMS);
     }
     delete Table_B1;
     delete Table_B2;
     delete Table_B3;
     delete Table_B4;
     delete Table_B5;
-    if(bUsed == FALSE) {
+    if(bUsed == false) {
         if(gbContext) {
             m_pModule->JBig2_Free(gbContext);
         }
         if(grContext) {
             m_pModule->JBig2_Free(grContext);
         }
     }
     return JBIG2_SUCCESS;
 failed:
     delete pSymbolDictDecoder;
     if(SDINSYMS) {
         m_pModule->JBig2_Free(SDINSYMS);
     }
     delete Table_B1;
     delete Table_B2;
     delete Table_B3;
     delete Table_B4;
     delete Table_B5;
     if(gbContext) {
         m_pModule->JBig2_Free(gbContext);
     }
     if(grContext) {
         m_pModule->JBig2_Free(grContext);
     }
     return nRet;
 }
 
-FX_BOOL CJBig2_Context::parseTextRegion(CJBig2_Segment *pSegment)
+int32_t CJBig2_Context::parseTextRegion(CJBig2_Segment *pSegment)
 {
     FX_DWORD dwTemp;
     FX_WORD wFlags;
     int32_t i, nIndex, nRet;
     JBig2RegionInfo ri;
     CJBig2_Segment *pSeg;
     CJBig2_Image **SBSYMS = NULL;
     JBig2HuffmanCode *SBSYMCODES = NULL;
     uint8_t cSBHUFFFS, cSBHUFFDS, cSBHUFFDT, cSBHUFFRDW, cSBHUFFRDH, cSBHUFFRDX, cSBHUFFRDY, cSBHUFFRSIZE;
     CJBig2_HuffmanTable *Table_B1 = NULL,
@@ skipping 345 matching lines @@
     delete Table_B9;
     delete Table_B10;
     delete Table_B11;
     delete Table_B12;
     delete Table_B13;
     delete Table_B14;
     delete Table_B15;
     return nRet;
 }
 
-FX_BOOL CJBig2_Context::parsePatternDict(CJBig2_Segment *pSegment, IFX_Pause* pPause)
+int32_t CJBig2_Context::parsePatternDict(CJBig2_Segment *pSegment, IFX_Pause* pPause)
 {
     FX_DWORD dwTemp;
     uint8_t cFlags;
     JBig2ArithCtx *gbContext;
     CJBig2_ArithDecoder *pArithDecoder;
     CJBig2_PDDProc *pPDD;
     int32_t nRet;
     JBIG2_ALLOC(pPDD, CJBig2_PDDProc());
     if((m_pStream->read1Byte(&cFlags) != 0)
             || (m_pStream->read1Byte(&pPDD->HDPW) != 0)
@@ skipping 33 matching lines @@
             goto failed;
         }
         m_pStream->alignByte();
     }
     delete pPDD;
     return JBIG2_SUCCESS;
 failed:
     delete pPDD;
     return nRet;
 }
-FX_BOOL CJBig2_Context::parseHalftoneRegion(CJBig2_Segment *pSegment, IFX_Pause* pPause)
+int32_t CJBig2_Context::parseHalftoneRegion(CJBig2_Segment *pSegment, IFX_Pause* pPause)
 {
     FX_DWORD dwTemp;
     uint8_t cFlags;
     JBig2RegionInfo ri;
     CJBig2_Segment *pSeg;
     CJBig2_PatternDict *pPatternDict;
     JBig2ArithCtx *gbContext;
     CJBig2_ArithDecoder *pArithDecoder;
     CJBig2_HTRDProc *pHRD;
     int32_t nRet;
@@ skipping 73 matching lines @@
         delete pSegment->m_Result.im;
         pSegment->m_Result.im = NULL;
     }
     delete pHRD;
     return JBIG2_SUCCESS;
 failed:
     delete pHRD;
     return nRet;
 }
 
-FX_BOOL CJBig2_Context::parseGenericRegion(CJBig2_Segment *pSegment, IFX_Pause* pPause)
+int32_t CJBig2_Context::parseGenericRegion(CJBig2_Segment *pSegment, IFX_Pause* pPause)
 {
     FX_DWORD dwTemp;
     uint8_t cFlags;
     int32_t i, nRet;
     if(m_pGRD == NULL) {
         JBIG2_ALLOC(m_pGRD, CJBig2_GRDProc());
         if((parseRegionInfo(&m_ri) != JBIG2_SUCCESS)
                 || (m_pStream->read1Byte(&cFlags) != 0)) {
             m_pModule->JBig2_Error("generic region segment : data header too short.");
             nRet = JBIG2_ERROR_TOO_SHORT;
@@ skipping 96 matching lines @@
     }
     delete m_pGRD;
     m_pGRD = NULL;
     return JBIG2_SUCCESS;
 failed:
     delete m_pGRD;
     m_pGRD = NULL;
     return nRet;
 }
 
-FX_BOOL CJBig2_Context::parseGenericRefinementRegion(CJBig2_Segment *pSegment)
+int32_t CJBig2_Context::parseGenericRefinementRegion(CJBig2_Segment *pSegment)
 {
     FX_DWORD dwTemp;
     JBig2RegionInfo ri;
     CJBig2_Segment *pSeg;
     int32_t i, nRet;
     uint8_t cFlags;
     JBig2ArithCtx *grContext;
     CJBig2_GRRDProc *pGRRD;
     CJBig2_ArithDecoder *pArithDecoder;
     JBIG2_ALLOC(pGRRD, CJBig2_GRRDProc());
@@ skipping 66 matching lines @@
         m_pPage->composeFrom(ri.x, ri.y, pSegment->m_Result.im, (JBig2ComposeOp)(ri.flags & 0x03));
         delete pSegment->m_Result.im;
         pSegment->m_Result.im = NULL;
     }
     delete pGRRD;
     return JBIG2_SUCCESS;
 failed:
     delete pGRRD;
     return nRet;
 }
-FX_BOOL CJBig2_Context::parseTable(CJBig2_Segment *pSegment)
+int32_t CJBig2_Context::parseTable(CJBig2_Segment *pSegment)
 {
     pSegment->m_nResultType = JBIG2_HUFFMAN_TABLE_POINTER;
     JBIG2_ALLOC(pSegment->m_Result.ht, CJBig2_HuffmanTable(m_pStream));
     if(!pSegment->m_Result.ht->isOK()) {
         delete pSegment->m_Result.ht;
         pSegment->m_Result.ht = NULL;
         return JBIG2_ERROR_FATAL;
     }
     m_pStream->alignByte();
     return JBIG2_SUCCESS;
 }
 int32_t CJBig2_Context::parseRegionInfo(JBig2RegionInfo *pRI)
 {
     if((m_pStream->readInteger((FX_DWORD*)&pRI->width) != 0)
             || (m_pStream->readInteger((FX_DWORD*)&pRI->height) != 0)
             || (m_pStream->readInteger((FX_DWORD*)&pRI->x) != 0)
             || (m_pStream->readInteger((FX_DWORD*)&pRI->y) != 0)
             || (m_pStream->read1Byte(&pRI->flags) != 0)) {
         return JBIG2_ERROR_TOO_SHORT;
     }
     return JBIG2_SUCCESS;
 }
 JBig2HuffmanCode *CJBig2_Context::decodeSymbolIDHuffmanTable(CJBig2_BitStream *pStream,
         FX_DWORD SBNUMSYMS)
 {
     JBig2HuffmanCode *SBSYMCODES;
-    int32_t runcodes[35], runcodes_len[35], runcode;
-    int32_t i, j, nTemp, nVal, nBits;
+    int32_t runcodes[35];
+    int32_t runcodes_len[35];
+    int32_t runcode;
+    int32_t i;
+    int32_t j;
+    int32_t nVal;
+    int32_t nBits;
     int32_t run;
+    FX_DWORD nTemp;
     SBSYMCODES = (JBig2HuffmanCode*)m_pModule->JBig2_Malloc2(sizeof(JBig2HuffmanCode), SBNUMSYMS);
     for (i = 0; i < 35; i ++) {
         if(pStream->readNBits(4, &runcodes_len[i]) != 0) {
             goto failed;
         }
     }
     huffman_assign_code(runcodes, runcodes_len, 35);
     i = 0;
     while(i < (int)SBNUMSYMS) {
         nVal = 0;
@@ skipping 120 matching lines @@
                 SBSYMCODES[CURTEMP].code = CURCODE;
                 CURCODE = CURCODE + 1;
             }
             CURTEMP = CURTEMP + 1;
         }
         CURLEN = CURLEN + 1;
     }
     m_pModule->JBig2_Free(LENCOUNT);
     m_pModule->JBig2_Free(FIRSTCODE);
 }