FX_BOOL considered harmful.

core/src/fxge/apple/apple_int.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_SRC_FXGE_APPLE_APPLE_INT_H_
 #define CORE_SRC_FXGE_APPLE_APPLE_INT_H_
 
 #if _FXM_PLATFORM_  == _FXM_PLATFORM_APPLE_
@@ skipping 33 matching lines @@
 } IOS_FONTDATA;
 class CQuartz2D
 {
 public:
     void*       createGraphics(CFX_DIBitmap* bitmap);
     void        destroyGraphics(void* graphics);
 
     void*       CreateFont(const uint8_t* pFontData, FX_DWORD dwFontSize);
     void        DestroyFont(void* pFont);
     void        setGraphicsTextMatrix(void* graphics, CFX_AffineMatrix* matrix);
-    FX_BOOL     drawGraphicsString(void*                graphics,
+    bool        drawGraphicsString(void*                graphics,
                                void*                font,
                                FX_FLOAT             fontSize,
                                FX_WORD*             glyphIndices,
                                CGPoint*          glyphPositions,
                                int32_t             chars,
                                FX_ARGB              argb,
                                CFX_AffineMatrix*    matrix = NULL);
     void saveGraphicsState(void* graphics);
     void restoreGraphicsState(void* graphics);
 };
@@ skipping 20 matching lines @@
     virtual int         GetDeviceCaps(int caps_id);
     virtual CFX_Matrix  GetCTM() const;
     virtual CFX_DIBitmap*   GetBackDrop()
     {
         return NULL;
     }
     virtual void*       GetPlatformSurface()
     {
         return NULL;
     }
-    virtual FX_BOOL IsPSPrintDriver()
+    virtual bool IsPSPrintDriver()
     {
-        return FALSE;
+        return false;
     }
-    virtual FX_BOOL     StartRendering()
+    virtual bool        StartRendering()
     {
-        return TRUE;
+        return true;
     }
     virtual void        EndRendering() {}
     virtual void        SaveState();
-    virtual void        RestoreState(FX_BOOL bKeepSaved);
-    virtual FX_BOOL     SetClip_PathFill(const CFX_PathData* pPathData,
+    virtual void        RestoreState(bool bKeepSaved);
+    virtual bool        SetClip_PathFill(const CFX_PathData* pPathData,
                                      const CFX_AffineMatrix* pObject2Device,
                                      int fill_mode
                                     );
-    virtual FX_BOOL     SetClip_PathStroke(const CFX_PathData* pPathData,
+    virtual bool        SetClip_PathStroke(const CFX_PathData* pPathData,
                                        const CFX_AffineMatrix* pObject2Device,
                                        const CFX_GraphStateData* pGraphState
                                       );
-    virtual FX_BOOL     DrawPath(const CFX_PathData* pPathData,
+    virtual bool        DrawPath(const CFX_PathData* pPathData,
                              const CFX_AffineMatrix* pObject2Device,
                              const CFX_GraphStateData* pGraphState,
                              FX_DWORD fill_color,
                              FX_DWORD stroke_color,
                              int fill_mode,
                              int alpha_flag = 0,
                              void* pIccTransform = NULL,
                              int blend_type = FXDIB_BLEND_NORMAL
                             );
-    virtual FX_BOOL     SetPixel(int x, int y, FX_DWORD color,
+    virtual bool        SetPixel(int x, int y, FX_DWORD color,
                              int alpha_flag = 0, void* pIccTransform = NULL)
     {
-        return FALSE;
+        return false;
     }
-    virtual FX_BOOL FillRect(const FX_RECT* pRect, FX_DWORD fill_color,
+    virtual bool FillRect(const FX_RECT* pRect, FX_DWORD fill_color,
                              int alpha_flag = 0, void* pIccTransform = NULL, int blend_type = FXDIB_BLEND_NORMAL);
-    virtual FX_BOOL     DrawCosmeticLine(FX_FLOAT x1, FX_FLOAT y1, FX_FLOAT x2, FX_FLOAT y2, FX_DWORD color,
+    virtual bool        DrawCosmeticLine(FX_FLOAT x1, FX_FLOAT y1, FX_FLOAT x2, FX_FLOAT y2, FX_DWORD color,
                                      int alpha_flag = 0, void* pIccTransform = NULL, int blend_type = FXDIB_BLEND_NORMAL);
-    virtual FX_BOOL GetClipBox(FX_RECT* pRect);
-    virtual FX_BOOL     GetDIBits(CFX_DIBitmap* pBitmap, int left, int top, void* pIccTransform = NULL, FX_BOOL bDEdge = FALSE);
-    virtual FX_BOOL     SetDIBits(const CFX_DIBSource* pBitmap, FX_DWORD color, const FX_RECT* pSrcRect,
+    virtual bool GetClipBox(FX_RECT* pRect);
+    virtual bool        GetDIBits(CFX_DIBitmap* pBitmap, int left, int top, void* pIccTransform = NULL, bool bDEdge = false);
+    virtual bool        SetDIBits(const CFX_DIBSource* pBitmap, FX_DWORD color, const FX_RECT* pSrcRect,
                               int dest_left, int dest_top, int blend_type,
                               int alpha_flag = 0, void* pIccTransform = NULL);
-    virtual FX_BOOL     StretchDIBits(const CFX_DIBSource* pBitmap, FX_DWORD color, int dest_left, int dest_top,
+    virtual bool        StretchDIBits(const CFX_DIBSource* pBitmap, FX_DWORD color, int dest_left, int dest_top,
                                   int dest_width, int dest_height, const FX_RECT* pClipRect, FX_DWORD flags,
                                   int alpha_flag = 0, void* pIccTransform = NULL, int blend_type = FXDIB_BLEND_NORMAL);
-    virtual FX_BOOL     StartDIBits(const CFX_DIBSource* pBitmap, int bitmap_alpha, FX_DWORD color,
+    virtual bool        StartDIBits(const CFX_DIBSource* pBitmap, int bitmap_alpha, FX_DWORD color,
                                 const CFX_AffineMatrix* pMatrix, FX_DWORD flags, void*& handle,
                                 int alpha_flag = 0, void* pIccTransform = NULL,
                                 int blend_type = FXDIB_BLEND_NORMAL)
     {
-        return FALSE;
+        return false;
     }
-    virtual FX_BOOL     ContinueDIBits(void* handle, IFX_Pause* pPause)
+    virtual bool        ContinueDIBits(void* handle, IFX_Pause* pPause)
     {
-        return FALSE;
+        return false;
     }
     virtual void        CancelDIBits(void* handle) {}
-    virtual FX_BOOL DrawDeviceText(int nChars, const FXTEXT_CHARPOS* pCharPos, CFX_Font* pFont,
+    virtual bool DrawDeviceText(int nChars, const FXTEXT_CHARPOS* pCharPos, CFX_Font* pFont,
                                    CFX_FontCache* pCache, const CFX_AffineMatrix* pObject2Device, FX_FLOAT font_size, FX_DWORD color,
                                    int alpha_flag = 0, void* pIccTransform = NULL);
     virtual void    ClearDriver();
 protected:
     void setStrokeInfo(const CFX_GraphStateData * graphState, FX_ARGB argb, FX_FLOAT lineWidth);
     void setFillInfo(FX_ARGB argb);
     void setPathToContext(const CFX_PathData * pathData);
     FX_FLOAT getLineWidth(const CFX_GraphStateData * graphState, CGAffineTransform ctm);
-    FX_BOOL CG_DrawGlypRun(int                        nChars,
+    bool CG_DrawGlypRun(int                        nChars,
                            const FXTEXT_CHARPOS*      pCharPos,
                            CFX_Font*                  pFont,
                            CFX_FontCache*             pCache,
                            const CFX_AffineMatrix*    pGlyphMatrix,
                            const CFX_AffineMatrix*    pObject2Device,
                            FX_FLOAT                   font_size,
                            FX_DWORD                   argb,
                            int                        alpha_flag,
                            void*                      pIccTransform);
     void    CG_SetImageTransform(int dest_left, int dest_top, int dest_width, int dest_height, CGRect* rect = NULL);
@@ skipping 15 matching lines @@
 {
 public:
     virtual void                        Release() override
     {
         delete this;
     }
     virtual FX_FILESIZE         GetSize() override
     {
         return (FX_FILESIZE)_totalSize;
     }
-    virtual FX_BOOL                     ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) override;
+    virtual bool                        ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) override;
 
-    virtual FX_BOOL                     IsEOF() override
+    virtual bool                        IsEOF() override
     {
         return _offSet == _totalSize;
     }
     virtual FX_FILESIZE         GetPosition() override
     {
         return (FX_FILESIZE)_offSet;
     }
     virtual size_t                      ReadBlock(void* buffer, size_t size) override;
 public:
     CFX_FontProvider(CGFontRef cgFont);
@@ skipping 26 matching lines @@
     int _tableCount;
     int _totalSize;
 };
 uint32_t FX_GetHashCode( const FX_CHAR* pStr);
 FX_DWORD  FX_IOSGetMatchFamilyNameHashcode(const FX_CHAR* pFontName);
 uint32_t FX_IOSGetFamilyNamesCount();
 const FX_CHAR* FX_IOSGetFamilyName( uint32_t uIndex);
 #endif
 
 #endif  // CORE_SRC_FXGE_APPLE_APPLE_INT_H_