FX_BOOL considered harmful.

core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_page.h"
 #include "pageint.h"
 
 CPDF_Pattern::CPDF_Pattern(const CFX_AffineMatrix* pParentMatrix) :
-    m_pPatternObj(NULL), m_PatternType(PATTERN_TILING), m_pDocument(NULL), m_bForceClear(FALSE)
+    m_pPatternObj(NULL), m_PatternType(PATTERN_TILING), m_pDocument(NULL), m_bForceClear(false)
 {
     if (pParentMatrix) {
         m_ParentMatrix = *pParentMatrix;
     }
 }
 CPDF_Pattern::~CPDF_Pattern()
 {
 }
 CPDF_TilingPattern::CPDF_TilingPattern(CPDF_Document* pDoc, CPDF_Object* pPatternObj, const CFX_AffineMatrix* parentMatrix) :
     CPDF_Pattern(parentMatrix)
 {
     m_PatternType = PATTERN_TILING;
     m_pPatternObj = pPatternObj;
     m_pDocument = pDoc;
     CPDF_Dictionary* pDict = m_pPatternObj->GetDict();
     ASSERT(pDict != NULL);
     m_Pattern2Form = pDict->GetMatrix(FX_BSTRC("Matrix"));
     m_bColored = pDict->GetInteger(FX_BSTRC("PaintType")) == 1;
     if (parentMatrix) {
         m_Pattern2Form.Concat(*parentMatrix);
     }
     m_pForm = NULL;
 }
 CPDF_TilingPattern::~CPDF_TilingPattern()
 {
     delete m_pForm;
     m_pForm = NULL;
 }
-FX_BOOL CPDF_TilingPattern::Load()
+bool CPDF_TilingPattern::Load()
 {
     if (m_pForm != NULL) {
-        return TRUE;
+        return true;
     }
     CPDF_Dictionary* pDict = m_pPatternObj->GetDict();
     if (pDict == NULL) {
-        return FALSE;
+        return false;
     }
     m_bColored = pDict->GetInteger(FX_BSTRC("PaintType")) == 1;
     m_XStep = (FX_FLOAT)FXSYS_fabs(pDict->GetNumber(FX_BSTRC("XStep")));
     m_YStep = (FX_FLOAT)FXSYS_fabs(pDict->GetNumber(FX_BSTRC("YStep")));
     if (m_pPatternObj->GetType() != PDFOBJ_STREAM) {
-        return FALSE;
+        return false;
     }
     CPDF_Stream* pStream = (CPDF_Stream*)m_pPatternObj;
     m_pForm = new CPDF_Form(m_pDocument, NULL, pStream);
     m_pForm->ParseContent(NULL, &m_ParentMatrix, NULL, NULL);
     m_BBox = pDict->GetRect(FX_BSTRC("BBox"));
-    return TRUE;
+    return true;
 }
-CPDF_ShadingPattern::CPDF_ShadingPattern(CPDF_Document* pDoc, CPDF_Object* pPatternObj, FX_BOOL bShading, const CFX_AffineMatrix* parentMatrix) : CPDF_Pattern(parentMatrix)
+CPDF_ShadingPattern::CPDF_ShadingPattern(CPDF_Document* pDoc, CPDF_Object* pPatternObj, bool bShading, const CFX_AffineMatrix* parentMatrix) : CPDF_Pattern(parentMatrix)
 {
     m_PatternType = PATTERN_SHADING;
     m_pPatternObj = bShading ? NULL : pPatternObj;
     m_pDocument = pDoc;
     m_bShadingObj = bShading;
     if (!bShading) {
         CPDF_Dictionary* pDict = m_pPatternObj->GetDict();
         ASSERT(pDict != NULL);
         m_Pattern2Form = pDict->GetMatrix(FX_BSTRC("Matrix"));
         m_pShadingObj = pDict->GetElementValue(FX_BSTRC("Shading"));
@@ skipping 23 matching lines @@
     }
     CPDF_ColorSpace* pCS = m_pCountedCS ? m_pCountedCS->get() : NULL;
     if (pCS && m_pDocument) {
         m_pDocument->GetPageData()->ReleaseColorSpace(pCS->GetArray());
     }
     m_ShadingType = 0;
     m_pCS = NULL;
     m_pCountedCS = NULL;
     m_nFuncs = 0;
 }
-FX_BOOL CPDF_ShadingPattern::Load()
+bool CPDF_ShadingPattern::Load()
 {
     if (m_ShadingType != 0) {
-        return TRUE;
+        return true;
     }
     CPDF_Dictionary* pShadingDict = m_pShadingObj ? m_pShadingObj->GetDict() : NULL;
     if (pShadingDict == NULL) {
-        return FALSE;
+        return false;
     }
     if (m_nFuncs) {
         for (int i = 0; i < m_nFuncs; i ++)
             delete m_pFunctions[i];
         m_nFuncs = 0;
     }
     CPDF_Object* pFunc = pShadingDict->GetElementValue(FX_BSTRC("Function"));
     if (pFunc) {
         if (pFunc->GetType() == PDFOBJ_ARRAY) {
             m_nFuncs = ((CPDF_Array*)pFunc)->GetCount();
             if (m_nFuncs > 4) {
                 m_nFuncs = 4;
             }
             for (int i = 0; i < m_nFuncs; i ++) {
                 m_pFunctions[i] = CPDF_Function::Load(((CPDF_Array*)pFunc)->GetElementValue(i));
             }
         } else {
             m_pFunctions[0] = CPDF_Function::Load(pFunc);
             m_nFuncs = 1;
         }
     }
     CPDF_Object* pCSObj = pShadingDict->GetElementValue(FX_BSTRC("ColorSpace"));
     if (pCSObj == NULL) {
-        return FALSE;
+        return false;
     }
     CPDF_DocPageData* pDocPageData = m_pDocument->GetPageData();
     m_pCS = pDocPageData->GetColorSpace(pCSObj, NULL);
     if (m_pCS) {
         m_pCountedCS = pDocPageData->FindColorSpacePtr(m_pCS->GetArray());
     }
     m_ShadingType = pShadingDict->GetInteger(FX_BSTRC("ShadingType"));
-    return TRUE;
+    return true;
 }
-FX_BOOL CPDF_ShadingPattern::Reload()
+bool CPDF_ShadingPattern::Reload()
 {
     Clear();
     return Load();
 }
-FX_BOOL CPDF_MeshStream::Load(CPDF_Stream* pShadingStream, CPDF_Function** pFuncs, int nFuncs, CPDF_ColorSpace* pCS)
+bool CPDF_MeshStream::Load(CPDF_Stream* pShadingStream, CPDF_Function** pFuncs, int nFuncs, CPDF_ColorSpace* pCS)
 {
     m_Stream.LoadAllData(pShadingStream);
     m_BitStream.Init(m_Stream.GetData(), m_Stream.GetSize());
     m_pFuncs = pFuncs;
     m_nFuncs = nFuncs;
     m_pCS = pCS;
     CPDF_Dictionary* pDict = pShadingStream->GetDict();
     m_nCoordBits = pDict->GetInteger(FX_BSTRC("BitsPerCoordinate"));
     m_nCompBits = pDict->GetInteger(FX_BSTRC("BitsPerComponent"));
     m_nFlagBits = pDict->GetInteger(FX_BSTRC("BitsPerFlag"));
     if (!m_nCoordBits || !m_nCompBits) {
-        return FALSE;
+        return false;
     }
     int nComps = pCS->CountComponents();
     if (nComps > 8) {
-        return FALSE;
+        return false;
     }
     m_nComps = nFuncs ? 1 : nComps;
     if (((int)m_nComps < 0) || m_nComps > 8) {
-        return FALSE;
+        return false;
     }
     m_CoordMax = m_nCoordBits == 32 ? -1 : (1 << m_nCoordBits) - 1;
     m_CompMax = (1 << m_nCompBits) - 1;
     CPDF_Array* pDecode = pDict->GetArray(FX_BSTRC("Decode"));
     if (pDecode == NULL || pDecode->GetCount() != 4 + m_nComps * 2) {
-        return FALSE;
+        return false;
     }
     m_xmin = pDecode->GetNumber(0);
     m_xmax = pDecode->GetNumber(1);
     m_ymin = pDecode->GetNumber(2);
     m_ymax = pDecode->GetNumber(3);
     for (FX_DWORD i = 0; i < m_nComps; i ++) {
         m_ColorMin[i] = pDecode->GetNumber(i * 2 + 4);
         m_ColorMax[i] = pDecode->GetNumber(i * 2 + 5);
     }
-    return TRUE;
+    return true;
 }
 FX_DWORD CPDF_MeshStream::GetFlag()
 {
     return m_BitStream.GetBits(m_nFlagBits) & 0x03;
 }
 void CPDF_MeshStream::GetCoords(FX_FLOAT& x, FX_FLOAT& y)
 {
     if (m_nCoordBits == 32) {
         x = m_xmin + (FX_FLOAT)(m_BitStream.GetBits(m_nCoordBits) * (m_xmax - m_xmin) / (double)m_CoordMax);
         y = m_ymin + (FX_FLOAT)(m_BitStream.GetBits(m_nCoordBits) * (m_ymax - m_ymin) / (double)m_CoordMax);
@@ skipping 26 matching lines @@
 }
 FX_DWORD CPDF_MeshStream::GetVertex(CPDF_MeshVertex& vertex, CFX_AffineMatrix* pObject2Bitmap)
 {
     FX_DWORD flag = GetFlag();
     GetCoords(vertex.x, vertex.y);
     pObject2Bitmap->Transform(vertex.x, vertex.y);
     GetColor(vertex.r, vertex.g, vertex.b);
     m_BitStream.ByteAlign();
     return flag;
 }
-FX_BOOL CPDF_MeshStream::GetVertexRow(CPDF_MeshVertex* vertex, int count, CFX_AffineMatrix* pObject2Bitmap)
+bool CPDF_MeshStream::GetVertexRow(CPDF_MeshVertex* vertex, int count, CFX_AffineMatrix* pObject2Bitmap)
 {
     for (int i = 0; i < count; i ++) {
         if (m_BitStream.IsEOF()) {
-            return FALSE;
+            return false;
         }
         GetCoords(vertex[i].x, vertex[i].y);
         pObject2Bitmap->Transform(vertex[i].x, vertex[i].y);
         GetColor(vertex[i].r, vertex[i].g, vertex[i].b);
         m_BitStream.ByteAlign();
     }
-    return TRUE;
+    return true;
 }
 CFX_FloatRect _GetShadingBBox(CPDF_Stream* pStream, int type, const CFX_AffineMatrix* pMatrix,
                               CPDF_Function** pFuncs, int nFuncs, CPDF_ColorSpace* pCS)
 {
     if (pStream == NULL || pStream->GetType() != PDFOBJ_STREAM || pFuncs == NULL || pCS == NULL) {
         return CFX_FloatRect(0, 0, 0, 0);
     }
     CPDF_MeshStream stream;
     if (!stream.Load(pStream, pFuncs, nFuncs, pCS)) {
         return CFX_FloatRect(0, 0, 0, 0);
     }
     CFX_FloatRect rect;
-    FX_BOOL bStarted = FALSE;
-    FX_BOOL bGouraud = type == 4 || type == 5;
+    bool bStarted = false;
+    bool bGouraud = type == 4 || type == 5;
     int full_point_count = type == 7 ? 16 : (type == 6 ? 12 : 1);
     int full_color_count = (type == 6 || type == 7) ? 4 : 1;
     while (!stream.m_BitStream.IsEOF()) {
         FX_DWORD flag = 0;
         if (type != 5) {
             flag = stream.GetFlag();
         }
         int point_count = full_point_count, color_count = full_color_count;
         if (!bGouraud && flag) {
             point_count -= 4;
             color_count -= 2;
         }
         for (int i = 0; i < point_count; i ++) {
             FX_FLOAT x, y;
             stream.GetCoords(x, y);
             if (bStarted) {
                 rect.UpdateRect(x, y);
             } else {
                 rect.InitRect(x, y);
-                bStarted = TRUE;
+                bStarted = true;
             }
         }
         stream.m_BitStream.SkipBits(stream.m_nComps * stream.m_nCompBits * color_count);
         if (bGouraud) {
             stream.m_BitStream.ByteAlign();
         }
     }
     rect.Transform(pMatrix);
     return rect;
 }