FX_BOOL considered harmful.

core/src/fxcrt/xml_int.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_SRC_FXCRT_XML_INT_H_
 #define CORE_SRC_FXCRT_XML_INT_H_
 
 #include "../../include/fxcrt/fx_stream.h"
 
 class CXML_DataBufAcc : public IFX_BufferRead
 {
 public:
     CXML_DataBufAcc(const uint8_t* pBuffer, size_t size)
         : m_pBuffer(pBuffer)
         , m_dwSize(size)
         , m_dwCurPos(0)
     {
     }
     virtual ~CXML_DataBufAcc() {}
     virtual void                        Release()
     {
         delete this;
     }
-    virtual FX_BOOL                     IsEOF()
+    virtual bool                        IsEOF()
     {
         return m_dwCurPos >= m_dwSize;
     }
     virtual FX_FILESIZE         GetPosition()
     {
         return (FX_FILESIZE)m_dwCurPos;
     }
     virtual size_t                      ReadBlock(void* buffer, size_t size)
     {
         return 0;
     }
-    virtual FX_BOOL                     ReadNextBlock(FX_BOOL bRestart = FALSE)
+    virtual bool                        ReadNextBlock(bool bRestart = false)
     {
         if (bRestart) {
             m_dwCurPos = 0;
         }
         if (m_dwCurPos < m_dwSize) {
             m_dwCurPos = m_dwSize;
-            return TRUE;
+            return true;
         }
-        return FALSE;
+        return false;
     }
     virtual const uint8_t*              GetBlockBuffer()
     {
         return m_pBuffer;
     }
     virtual size_t                      GetBlockSize()
     {
         return m_dwSize;
     }
     virtual FX_FILESIZE         GetBlockOffset()
@@ skipping 20 matching lines @@
     virtual ~CXML_DataStmAcc()
     {
         if (m_pBuffer) {
             FX_Free(m_pBuffer);
         }
     }
     virtual void                        Release()
     {
         delete this;
     }
-    virtual FX_BOOL                     IsEOF()
+    virtual bool                        IsEOF()
     {
         return m_nStart + (FX_FILESIZE)m_dwSize >= m_pFileRead->GetSize();
     }
     virtual FX_FILESIZE         GetPosition()
     {
         return m_nStart + (FX_FILESIZE)m_dwSize;
     }
     virtual size_t                      ReadBlock(void* buffer, size_t size)
     {
         return 0;
     }
-    virtual FX_BOOL                     ReadNextBlock(FX_BOOL bRestart = FALSE)
+    virtual bool                        ReadNextBlock(bool bRestart = false)
     {
         if (bRestart) {
             m_nStart = 0;
         }
         FX_FILESIZE nLength = m_pFileRead->GetSize();
         m_nStart += (FX_FILESIZE)m_dwSize;
         if (m_nStart >= nLength) {
-            return FALSE;
+            return false;
         }
         m_dwSize = (size_t)FX_MIN(FX_XMLDATASTREAM_BufferSize, nLength - m_nStart);
         if (!m_pBuffer) {
             m_pBuffer = FX_Alloc(uint8_t, m_dwSize);
         }
         return m_pFileRead->ReadBlock(m_pBuffer, m_nStart, m_dwSize);
     }
     virtual const uint8_t*              GetBlockBuffer()
     {
         return (const uint8_t*)m_pBuffer;
@@ skipping 10 matching lines @@
     IFX_FileRead        *m_pFileRead;
     uint8_t*            m_pBuffer;
     FX_FILESIZE         m_nStart;
     size_t                      m_dwSize;
 };
 class CXML_Parser
 {
 public:
     ~CXML_Parser();
     IFX_BufferRead*     m_pDataAcc;
-    FX_BOOL                     m_bOwnedStream;
+    bool                        m_bOwnedStream;
     FX_FILESIZE         m_nOffset;
-    FX_BOOL                     m_bSaveSpaceChars;
+    bool                        m_bSaveSpaceChars;
     const uint8_t*              m_pBuffer;
     size_t                      m_dwBufferSize;
     FX_FILESIZE         m_nBufferOffset;
     size_t                      m_dwIndex;
-    FX_BOOL                     Init(uint8_t* pBuffer, size_t size);
-    FX_BOOL                     Init(IFX_FileRead *pFileRead);
-    FX_BOOL                     Init(IFX_BufferRead *pBuffer);
-    FX_BOOL                     Init(FX_BOOL bOwndedStream);
-    FX_BOOL                     ReadNextBlock();
-    FX_BOOL                     IsEOF();
-    FX_BOOL                     HaveAvailData();
+    bool                        Init(uint8_t* pBuffer, size_t size);
+    bool                        Init(IFX_FileRead *pFileRead);
+    bool                        Init(IFX_BufferRead *pBuffer);
+    bool                        Init(bool bOwndedStream);
+    bool                        ReadNextBlock();
+    bool                        IsEOF();
+    bool                        HaveAvailData();
     void                        SkipWhiteSpaces();
     void                        GetName(CFX_ByteString& space, CFX_ByteString& name);
     void                        GetAttrValue(CFX_WideString &value);
     FX_DWORD            GetCharRef();
-    void                        GetTagName(CFX_ByteString &space, CFX_ByteString &name, FX_BOOL &bEndTag, FX_BOOL bStartTag = FALSE);
+    void                        GetTagName(CFX_ByteString &space, CFX_ByteString &name, bool &bEndTag, bool bStartTag = false);
     void                        SkipLiterals(const CFX_ByteStringC& str);
-    CXML_Element*       ParseElement(CXML_Element* pParent, FX_BOOL bStartTag = FALSE);
-    void                        InsertContentSegment(FX_BOOL bCDATA, const CFX_WideStringC& content, CXML_Element* pElement);
+    CXML_Element*       ParseElement(CXML_Element* pParent, bool bStartTag = false);
+    void                        InsertContentSegment(bool bCDATA, const CFX_WideStringC& content, CXML_Element* pElement);
     void                        InsertCDATASegment(CFX_UTF8Decoder& decoder, CXML_Element* pElement);
 };
 void FX_XML_SplitQualifiedName(const CFX_ByteStringC& bsFullName, CFX_ByteStringC &bsSpace, CFX_ByteStringC &bsName);
 
 #endif  // CORE_SRC_FXCRT_XML_INT_H_