FX_BOOL considered harmful.

core/include/fpdfapi/fpdf_objects.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_INCLUDE_FPDFAPI_FPDF_OBJECTS_H_
 #define CORE_INCLUDE_FPDFAPI_FPDF_OBJECTS_H_
 
 #include "../fxcrt/fx_coordinates.h"
@@ skipping 39 matching lines @@
     FX_DWORD                            GetObjNum() const
     {
         return m_ObjNum;
     }
 
     FX_DWORD                            GetGenNum() const
     {
         return m_GenNum;
     }
 
-    FX_BOOL                             IsIdentical(CPDF_Object* pObj) const;
+    bool                             IsIdentical(CPDF_Object* pObj) const;
 
-    CPDF_Object*                        Clone(FX_BOOL bDirect = FALSE) const;
+    CPDF_Object*                        Clone(bool bDirect = false) const;
 
     CPDF_Object*                        CloneRef(CPDF_IndirectObjects* pObjs) const;
 
     CPDF_Object*                        GetDirect() const;
 
     void                                Release();
 
     CFX_ByteString                      GetString() const;
 
     CFX_ByteStringC                     GetConstString() const;
 
     CFX_WideString                      GetUnicodeText(CFX_CharMap* pCharMap = NULL) const;
     FX_FLOAT                            GetNumber() const;
 
     FX_FLOAT                            GetNumber16() const;
 
     int                                 GetInteger() const;
 
     CPDF_Dictionary*                    GetDict() const;
 
     CPDF_Array*                         GetArray() const;
 
     void                                SetString(const CFX_ByteString& str);
 
     void                                SetUnicodeText(const FX_WCHAR* pUnicodes, int len = -1);
 
     int                                 GetDirectType() const;
 
-    FX_BOOL                             IsModified() const
+    bool                             IsModified() const
     {
-        return FALSE;
+        return false;
     }
 protected:
     CPDF_Object(FX_DWORD type) : m_Type(type), m_ObjNum(0), m_GenNum(0) { }
     ~CPDF_Object() { }
     void                                Destroy();
 
     static const int                    OBJECT_REF_MAX_DEPTH = 128;
     static int                          s_nCurRefDepth;
     FX_DWORD                            m_Type;
     FX_DWORD                            m_ObjNum;
     FX_DWORD                            m_GenNum;
 
     friend class                        CPDF_IndirectObjects;
     friend class                        CPDF_Parser;
     friend class                        CPDF_SyntaxParser;
 private:
     CPDF_Object(const CPDF_Object& src) {}
-    CPDF_Object* CloneInternal(FX_BOOL bDirect, CFX_MapPtrToPtr* visited) const;
+    CPDF_Object* CloneInternal(bool bDirect, CFX_MapPtrToPtr* visited) const;
 };
 class CPDF_Boolean : public CPDF_Object
 {
 public:
 
-    static CPDF_Boolean*        Create(FX_BOOL value)
+    static CPDF_Boolean*        Create(bool value)
     {
         return new CPDF_Boolean(value);
     }
 
     CPDF_Boolean() : CPDF_Object(PDFOBJ_BOOLEAN), m_bValue(false) { }
-    CPDF_Boolean(FX_BOOL value) : CPDF_Object(PDFOBJ_BOOLEAN), m_bValue(value) { }
+    CPDF_Boolean(bool value) : CPDF_Object(PDFOBJ_BOOLEAN), m_bValue(value) { }
 
-    FX_BOOL                                     Identical(CPDF_Boolean* pOther) const
+    bool                                        Identical(CPDF_Boolean* pOther) const
     {
         return m_bValue == pOther->m_bValue;
     }
 protected:
 
-    FX_BOOL                                     m_bValue;
+    bool                                        m_bValue;
     friend class                        CPDF_Object;
 };
 class CPDF_Number : public CPDF_Object
 {
 public:
 
     static CPDF_Number*         Create(int value)
     {
         return new CPDF_Number(value);
     }
 
     static CPDF_Number*         Create(FX_FLOAT value)
     {
         return new CPDF_Number(value);
     }
 
     static CPDF_Number*         Create(const CFX_ByteStringC& str)
     {
         return new CPDF_Number(str);
     }
 
-    static CPDF_Number*         Create(FX_BOOL bInteger, void* pData)
+    static CPDF_Number*         Create(bool bInteger, void* pData)
     {
         return new CPDF_Number(bInteger, pData);
     }
 
     CPDF_Number() : CPDF_Object(PDFOBJ_NUMBER), m_bInteger(false), m_Integer(0) { }
 
-    CPDF_Number(FX_BOOL bInteger, void* pData);
+    CPDF_Number(bool bInteger, void* pData);
 
     CPDF_Number(int value);
 
     CPDF_Number(FX_FLOAT value);
 
     CPDF_Number(const CFX_ByteStringC& str);
 
-    FX_BOOL                                     Identical(CPDF_Number* pOther) const;
+    bool                                        Identical(CPDF_Number* pOther) const;
 
     CFX_ByteString                      GetString() const;
 
     void                                        SetString(const CFX_ByteStringC& str);
 
-    FX_BOOL                                     IsInteger() const
+    bool                                        IsInteger() const
     {
         return m_bInteger;
     }
 
     int                                         GetInteger() const
     {
         return m_bInteger ? m_Integer : (int)m_Float;
     }
 
     FX_FLOAT                            GetNumber() const
     {
         return m_bInteger ? (FX_FLOAT)m_Integer : m_Float;
     }
 
     void                                        SetNumber(FX_FLOAT value);
 
     FX_FLOAT                    GetNumber16() const
     {
         return GetNumber();
     }
 
     FX_FLOAT                            GetFloat() const
     {
         return m_bInteger ? (FX_FLOAT)m_Integer : m_Float;
     }
 protected:
 
-    FX_BOOL                                     m_bInteger;
+    bool                                        m_bInteger;
 
     union {
 
         int                                     m_Integer;
 
         FX_FLOAT                        m_Float;
     };
     friend class                        CPDF_Object;
 };
 class CPDF_String : public CPDF_Object
 {
 public:
 
-    static CPDF_String*         Create(const CFX_ByteString& str, FX_BOOL bHex = FALSE)
+    static CPDF_String*         Create(const CFX_ByteString& str, bool bHex = false)
     {
         return new CPDF_String(str, bHex);
     }
 
     static CPDF_String*         Create(const CFX_WideString& str)
     {
         return new CPDF_String(str);
     }
 
-    CPDF_String() : CPDF_Object(PDFOBJ_STRING), m_bHex(FALSE) { }
+    CPDF_String() : CPDF_Object(PDFOBJ_STRING), m_bHex(false) { }
 
-    CPDF_String(const CFX_ByteString& str, FX_BOOL bHex = FALSE)
+    CPDF_String(const CFX_ByteString& str, bool bHex = false)
         : CPDF_Object(PDFOBJ_STRING), m_String(str), m_bHex(bHex) {
     }
 
     CPDF_String(const CFX_WideString& str);
 
     CFX_ByteString&                     GetString()
     {
         return m_String;
     }
 
-    FX_BOOL                                     Identical(CPDF_String* pOther) const
+    bool                                        Identical(CPDF_String* pOther) const
     {
         return m_String == pOther->m_String;
     }
 
-    FX_BOOL                                     IsHex() const
+    bool                                        IsHex() const
     {
         return m_bHex;
     }
 protected:
 
     CFX_ByteString                      m_String;
 
-    FX_BOOL                                     m_bHex;
+    bool                                        m_bHex;
     friend class                        CPDF_Object;
 };
 class CPDF_Name : public CPDF_Object
 {
 public:
 
     static CPDF_Name*           Create(const CFX_ByteString& str)
     {
         return new CPDF_Name(str);
     }
@@ skipping 10 matching lines @@
 
     CPDF_Name(const CFX_ByteString& str) : CPDF_Object(PDFOBJ_NAME), m_Name(str) { }
     CPDF_Name(const CFX_ByteStringC& str) : CPDF_Object(PDFOBJ_NAME), m_Name(str) { }
     CPDF_Name(const FX_CHAR* str) : CPDF_Object(PDFOBJ_NAME), m_Name(str) { }
 
     CFX_ByteString&                     GetString()
     {
         return m_Name;
     }
 
-    FX_BOOL                                     Identical(CPDF_Name* pOther) const
+    bool                                        Identical(CPDF_Name* pOther) const
     {
         return m_Name == pOther->m_Name;
     }
 protected:
 
     CFX_ByteString                      m_Name;
     friend class                        CPDF_Object;
 };
 class CPDF_Array : public CPDF_Object
 {
@@ skipping 77 matching lines @@
     FX_FLOAT                    GetNumber16(FX_DWORD index) const
     {
         return GetNumber(index);
     }
 
     void                                        AddNumber16(FX_FLOAT value)
     {
         AddNumber(value);
     }
 
-    FX_BOOL                                     Identical(CPDF_Array* pOther) const;
+    bool                                        Identical(CPDF_Array* pOther) const;
 protected:
 
     ~CPDF_Array();
 
     CFX_PtrArray                        m_Objects;
     friend class                        CPDF_Object;
 };
 class CPDF_Dictionary : public CPDF_Object
 {
 public:
@@ skipping 20 matching lines @@
     CFX_ByteString                      GetString(const CFX_ByteStringC& key, const CFX_ByteStringC& default_str) const;
 
     CFX_ByteStringC                     GetConstString(const CFX_ByteStringC& key, const CFX_ByteStringC& default_str) const;
 
     CFX_WideString                      GetUnicodeText(const CFX_ByteStringC& key, CFX_CharMap* pCharMap = NULL) const;
 
     int                                         GetInteger(const CFX_ByteStringC& key) const;
 
     int                                         GetInteger(const CFX_ByteStringC& key, int default_int) const;
 
-    FX_BOOL                                     GetBoolean(const CFX_ByteStringC& key, FX_BOOL bDefault = FALSE) const;
+    bool                                        GetBoolean(const CFX_ByteStringC& key, bool bDefault = false) const;
 
     FX_FLOAT                            GetNumber(const CFX_ByteStringC& key) const;
 
     CPDF_Dictionary*            GetDict(const CFX_ByteStringC& key) const;
 
     CPDF_Stream*                        GetStream(const CFX_ByteStringC& key) const;
 
     CPDF_Array*                         GetArray(const CFX_ByteStringC& key) const;
 
     CFX_FloatRect                       GetRect(const CFX_ByteStringC& key) const;
 
     CFX_AffineMatrix            GetMatrix(const CFX_ByteStringC& key) const;
 
     FX_FLOAT                            GetFloat(const CFX_ByteStringC& key) const
     {
         return GetNumber(key);
     }
 
 
-    FX_BOOL                                     KeyExist(const CFX_ByteStringC& key) const;
+    bool                                        KeyExist(const CFX_ByteStringC& key) const;
 
     FX_POSITION                         GetStartPos() const;
 
     CPDF_Object*                        GetNextElement(FX_POSITION& pos, CFX_ByteString& key) const;
 
     void                                        SetAt(const CFX_ByteStringC& key, CPDF_Object* pObj, CPDF_IndirectObjects* pObjs = NULL);
 
 
 
     void                                        SetAtName(const CFX_ByteStringC& key, const CFX_ByteString& name);
@@ skipping 18 matching lines @@
 
     void                                        AddReference(const CFX_ByteStringC& key, CPDF_IndirectObjects* pDoc, CPDF_Object* obj)
     {
         AddReference(key, pDoc, obj->GetObjNum());
     }
 
     void                                        SetAtRect(const CFX_ByteStringC& key, const CFX_FloatRect& rect);
 
     void                                        SetAtMatrix(const CFX_ByteStringC& key, const CFX_AffineMatrix& matrix);
 
-    void                                        SetAtBoolean(const CFX_ByteStringC& key, FX_BOOL bValue);
+    void                                        SetAtBoolean(const CFX_ByteStringC& key, bool bValue);
 
 
 
     void                                        RemoveAt(const CFX_ByteStringC& key);
 
 
     void                                        ReplaceKey(const CFX_ByteStringC& oldkey, const CFX_ByteStringC& newkey);
 
-    FX_BOOL                                     Identical(CPDF_Dictionary* pDict) const;
+    bool                                        Identical(CPDF_Dictionary* pDict) const;
 
     int                                         GetCount() const
     {
         return m_Map.GetCount();
     }
 
     void                                        AddValue(const CFX_ByteStringC& key, CPDF_Object* pObj);
 protected:
 
     ~CPDF_Dictionary();
@@ skipping 11 matching lines @@
         return new CPDF_Stream(pData, size, pDict);
     }
 
     CPDF_Stream(uint8_t* pData, FX_DWORD size, CPDF_Dictionary* pDict);
 
     CPDF_Dictionary*            GetDict() const
     {
         return m_pDict;
     }
 
-    void                                        SetData(const uint8_t* pData, FX_DWORD size, FX_BOOL bCompressed, FX_BOOL bKeepBuf);
+    void                                        SetData(const uint8_t* pData, FX_DWORD size, bool bCompressed, bool bKeepBuf);
 
     void                                        InitStream(uint8_t* pData, FX_DWORD size, CPDF_Dictionary* pDict);
 
     void                                        InitStream(IFX_FileRead *pFile, CPDF_Dictionary* pDict);
 
-    FX_BOOL                                     Identical(CPDF_Stream* pOther) const;
+    bool                                        Identical(CPDF_Stream* pOther) const;
 
-    CPDF_StreamFilter*          GetStreamFilter(FX_BOOL bRaw = FALSE) const;
+    CPDF_StreamFilter*          GetStreamFilter(bool bRaw = false) const;
 
 
 
     FX_DWORD                            GetRawSize() const
     {
         return m_dwSize;
     }
 
-    FX_BOOL                                     ReadRawData(FX_FILESIZE start_pos, uint8_t* pBuf, FX_DWORD buf_size) const;
+    bool                                        ReadRawData(FX_FILESIZE start_pos, uint8_t* pBuf, FX_DWORD buf_size) const;
 
 
-    FX_BOOL                                     IsMemoryBased() const
+    bool                                        IsMemoryBased() const
     {
         return m_GenNum == (FX_DWORD) - 1;
     }
 
-    CPDF_Stream*                        Clone(FX_BOOL bDirect, FPDF_LPFCloneStreamCallback lpfCallback, void* pUserData) const;
+    CPDF_Stream*                        Clone(bool bDirect, FPDF_LPFCloneStreamCallback lpfCallback, void* pUserData) const;
 protected:
 
     ~CPDF_Stream();
 
     CPDF_Dictionary*            m_pDict;
 
     FX_DWORD                            m_dwSize;
 
     FX_DWORD                            m_GenNum;
 
@@ skipping 14 matching lines @@
     friend class                        CPDF_AttachmentAcc;
 };
 class CPDF_StreamAcc
 {
 public:
 
     CPDF_StreamAcc();
 
     ~CPDF_StreamAcc();
 
-    void                                        LoadAllData(const CPDF_Stream* pStream, FX_BOOL bRawAccess = FALSE,
-                                        FX_DWORD estimated_size = 0, FX_BOOL bImageAcc = FALSE);
+    void                                        LoadAllData(const CPDF_Stream* pStream, bool bRawAccess = false,
+                                        FX_DWORD estimated_size = 0, bool bImageAcc = false);
 
     const CPDF_Stream*          GetStream() const
     {
         return m_pStream;
     }
 
     CPDF_Dictionary*            GetDict() const
     {
         return m_pStream? m_pStream->GetDict() : NULL;
     }
@@ skipping 12 matching lines @@
     const CPDF_Dictionary*      GetImageParam()
     {
         return m_pImageParam;
     }
 protected:
 
     uint8_t*                            m_pData;
 
     FX_DWORD                            m_dwSize;
 
-    FX_BOOL                                     m_bNewBuf;
+    bool                                        m_bNewBuf;
 
     CFX_ByteString                      m_ImageDecoder;
 
     CPDF_Dictionary*            m_pImageParam;
 
     const CPDF_Stream*          m_pStream;
 
     uint8_t*                            m_pSrcData;
 };
 CFX_DataFilter* FPDF_CreateFilter(const CFX_ByteStringC& name, const CPDF_Dictionary* pParam, int width = 0, int height = 0);
@@ skipping 57 matching lines @@
         return m_pObjList;
     }
 
     FX_DWORD                            GetRefObjNum() const
     {
         return m_RefObjNum;
     }
 
     void                                        SetRef(CPDF_IndirectObjects* pDoc, FX_DWORD objnum);
 
-    FX_BOOL                                     Identical(CPDF_Reference* pOther) const
+    bool                                        Identical(CPDF_Reference* pOther) const
     {
         return m_RefObjNum == pOther->m_RefObjNum;
     }
 protected:
 
     CPDF_IndirectObjects*       m_pObjList;
 
     FX_DWORD                            m_RefObjNum;
     friend class                        CPDF_Object;
 };
@@ skipping 29 matching lines @@
 protected:
 
     CFX_MapPtrToPtr                     m_IndirectObjs;
 
     CPDF_Parser*                        m_pParser;
 
     FX_DWORD                            m_LastObjNum;
 };
 
 #endif  // CORE_INCLUDE_FPDFAPI_FPDF_OBJECTS_H_