FX_BOOL considered harmful.

core/src/fxge/skia/fx_skia_blitter_new.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "../../../include/fxge/fx_ge.h"
 //#define _SKIA_SUPPORT_
 #if defined(_SKIA_SUPPORT_)
 #include "../../../include/fxcodec/fx_codec.h"
 #include "SkBlitter.h"
 #include "fx_skia_blitter_new.h"
@@ skipping 1280 matching lines @@
                                         }
                                 }
                                 dest_scan += 4;
                         }
                 }
         }
 
 
 
         //--------------------------------------------------------------------
-        FX_BOOL CFX_SkiaRenderer::Init(CFX_DIBitmap* pDevice, CFX_DIBitmap* pOriDevice, const CFX_ClipRgn* pClipRgn, FX_DWORD color, FX_BOOL bFullCover, FX_BOOL bRgbByteOrder,
+        bool CFX_SkiaRenderer::Init(CFX_DIBitmap* pDevice, CFX_DIBitmap* pOriDevice, const CFX_ClipRgn* pClipRgn, FX_DWORD color, bool bFullCover, bool bRgbByteOrder,
                 int alpha_flag, void* pIccTransform) //The alpha flag must be fill_flag if exist.
         {
                 m_pDevice = pDevice;
                 m_pClipRgn = pClipRgn;
                 m_bRgbByteOrder = bRgbByteOrder;
                 m_pOriDevice = pOriDevice;
                 m_pDestScan = NULL;
                 m_pDestExtraAlphaScan = NULL;
                 m_pOriScan = NULL;
                 m_pClipScan = NULL;
@@ skipping 12 matching lines @@
                         m_pClipScan = m_pClipMask->GetBuffer();
                 }
                 if (m_pDevice->m_pAlphaMask)
                         m_pDestExtraAlphaScan = m_pDevice->m_pAlphaMask->GetBuffer();
                 if (m_pOriDevice)
                         m_pOriScan = m_pOriDevice->GetBuffer();
                 m_pDestScan = m_pDevice->GetBuffer();
 
                 m_bFullCover = bFullCover;
 
-                FX_BOOL bObjectCMYK = FXGETFLAG_COLORTYPE(alpha_flag);
-                FX_BOOL bDeviceCMYK = pDevice->IsCmykImage();
+                bool bObjectCMYK = FXGETFLAG_COLORTYPE(alpha_flag);
+                bool bDeviceCMYK = pDevice->IsCmykImage();
 
                 m_Alpha = bObjectCMYK ? FXGETFLAG_ALPHA_FILL(alpha_flag) : FXARGB_A(color);
 
                 ICodec_IccModule* pIccModule = NULL;
                 // No lcms engine, we skip the transform
                 if (!CFX_GEModule::Get()->GetCodecModule() || !CFX_GEModule::Get()->GetCodecModule()->GetIccModule())
                         pIccTransform = NULL;
                 else
                         pIccModule = CFX_GEModule::Get()->GetCodecModule()->GetIccModule();
 
@@ skipping 24 matching lines @@
                         if (bDeviceCMYK) { // Cmyk(a) Device
                                 ASSERT(!m_bRgbByteOrder);
                                 //TODO... opt for cmyk
                                 composite_span = &CFX_SkiaRenderer::CompositeSpanCMYK;
                                 if (bObjectCMYK) {
                                         m_Color = FXCMYK_TODIB(color);
                                         if (pIccTransform)
                                                 pIccModule->TranslateScanline(pIccTransform, (uint8_t*)&m_Color, (const uint8_t*)&m_Color, 1);
                                 } else { // Object RGB
                                         if (!pIccTransform)
-                                                return FALSE;
+                                                return false;
                                         color = FXARGB_TODIB(color);
                                         pIccModule->TranslateScanline(pIccTransform, (uint8_t*)&m_Color, (const uint8_t*)&color, 1);
                                 }
                                 m_Red   = ((uint8_t*)&m_Color)[0];
                                 m_Green = ((uint8_t*)&m_Color)[1];
                                 m_Blue  = ((uint8_t*)&m_Color)[2];
                                 m_Gray  = ((uint8_t*)&m_Color)[3];
-                                return TRUE;
+                                return true;
                         } else {
                                 if (pIccTransform) {
                                         color = bObjectCMYK ? FXCMYK_TODIB(color) : FXARGB_TODIB(color);
                                         pIccModule->TranslateScanline(pIccTransform, (uint8_t*)&m_Color, (const uint8_t*)&color, 1);
                                         ((uint8_t*)&m_Color)[3] = m_Alpha;
                                         m_Red = ((uint8_t*)&m_Color)[2];
                                         m_Green = ((uint8_t*)&m_Color)[1];
                                         m_Blue = ((uint8_t*)&m_Color)[0];
                                         // Need Johnson to improvement it.
                                         if (m_bRgbByteOrder) {
@@ skipping 91 matching lines @@
                                 //TODO...
                                 break;
                         case 10:
                                 composite_span = &CFX_SkiaRenderer::CompositeSpanRGB24_10;
                                 break;
                         case 14:
                                 composite_span = &CFX_SkiaRenderer::CompositeSpanRGB24_14;
                                 break;
                 }
                 if (composite_span == NULL)
-                        return FALSE;
-                return TRUE;
+                        return false;
+                return true;
         }
 
         /*----------------------------------------------------------------------------------------------------*/
         void CFX_SkiaA8Renderer::blitAntiH(int x, int y, const SkAlpha antialias[], const int16_t runs[])
         {
                 FXSYS_assert(m_pDevice);
                 int dst_y = y - m_Top;
                 if (dst_y < 0 || dst_y >=  m_pDevice->GetHeight())
                         return;
 
@@ skipping 77 matching lines @@
                              SkAlpha leftAlpha, SkAlpha rightAlpha)
         {
                 blitV(x++, y, height, leftAlpha);
                 if (width > 0) {
                         blitRect(x, y, width, height);
                         x += width;
                 }
                 blitV(x, y, height, rightAlpha);
         }
 
-        FX_BOOL CFX_SkiaA8Renderer::Init(CFX_DIBitmap* pDevice, int Left, int Top)
+        bool CFX_SkiaA8Renderer::Init(CFX_DIBitmap* pDevice, int Left, int Top)
         {
                 m_pDevice = pDevice;
                 m_Left = Left;
                 m_Top = Top;
                 if (pDevice){
                         m_dstWidth = m_Left + pDevice->GetWidth();
                         m_dstHeight = m_Top + pDevice->GetHeight();
                 }
-                return TRUE;
+                return true;
         }
 #endif