fpdfsdk/include/pdfwindow/PWL_Button.h - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/pdfwindow/PWL_Button.h

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/pdfwindow/PWL_Button.h

diff --git a/fpdfsdk/include/pdfwindow/PWL_Button.h b/fpdfsdk/include/pdfwindow/PWL_Button.h

index 2bf2eea8653bf656e2f0f31f3c8522b3e61a5fe4..322b9d43661a53ca6fa6fd3a1509420a633a052e 100644

--- a/fpdfsdk/include/pdfwindow/PWL_Button.h

+++ b/fpdfsdk/include/pdfwindow/PWL_Button.h

@@ -17,11 +17,11 @@ public:

virtual CFX_ByteString GetClassName() const;

virtual void OnCreate(PWL_CREATEPARAM & cp);

- virtual FX_BOOL OnLButtonDown(const CPDF_Point & point, FX_DWORD nFlag);

- virtual FX_BOOL OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag);

+ virtual bool OnLButtonDown(const CPDF_Point & point, FX_DWORD nFlag);

+ virtual bool OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag);

protected:

- FX_BOOL m_bMouseDown;

+ bool m_bMouseDown;

};

#endif // FPDFSDK_INCLUDE_PDFWINDOW_PWL_BUTTON_H_

« no previous file with comments | « fpdfsdk/include/javascript/util.h ('k') | fpdfsdk/include/pdfwindow/PWL_Caret.h » ('j') | no next file with comments »