FX_BOOL considered harmful.

core/src/fxge/win32/fx_win32_dwrite.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fxge/fx_ge.h"
 #if _FX_OS_ == _FX_WIN32_DESKTOP_ || _FX_OS_ == _FX_WIN64_DESKTOP_
 #include "../../../include/fxge/fx_ge_win32.h"
 #include "dwrite_int.h"
@@ skipping 115 matching lines @@
 }
 CDWriteExt::~CDWriteExt()
 {
     Unload();
 }
 LPVOID  CDWriteExt::DwCreateFontFaceFromStream(uint8_t* pData, FX_DWORD size, int simulation_style)
 {
     IDWriteFactory* pDwFactory = (IDWriteFactory*)m_pDWriteFactory;
     IDWriteFontFile* pDwFontFile = NULL;
     IDWriteFontFace* pDwFontFace = NULL;
-    BOOL isSupportedFontType = FALSE;
+    BOOL isSupportedFontType = false;
     DWRITE_FONT_FILE_TYPE fontFileType;
     DWRITE_FONT_FACE_TYPE fontFaceType;
     UINT32 numberOfFaces;
     DWRITE_FONT_SIMULATIONS fontStyle = (DWRITE_FONT_SIMULATIONS)(simulation_style & 3);
     HRESULT hr = S_OK;
     hr = pDwFactory->CreateCustomFontFileReference(
              (void const*)pData,
              (UINT32)size,
              CDwFontFileLoader::GetLoader(),
              &pDwFontFile
@@ skipping 20 matching lines @@
          );
     if (FAILED(hr)) {
         goto failed;
     }
     SafeRelease(&pDwFontFile);
     return pDwFontFace;
 failed:
     SafeRelease(&pDwFontFile);
     return NULL;
 }
-FX_BOOL CDWriteExt::DwCreateRenderingTarget(CFX_DIBitmap* pBitmap, void** renderTarget)
+bool CDWriteExt::DwCreateRenderingTarget(CFX_DIBitmap* pBitmap, void** renderTarget)
 {
     if (pBitmap->GetFormat() > FXDIB_Argb) {
-        return FALSE;
+        return false;
     }
     IDWriteFactory* pDwFactory = (IDWriteFactory*)m_pDWriteFactory;
     IDWriteGdiInterop* pGdiInterop = NULL;
     IDWriteBitmapRenderTarget* pBitmapRenderTarget = NULL;
     IDWriteRenderingParams* pRenderingParams = NULL;
     HRESULT hr = S_OK;
     hr = pDwFactory->GetGdiInterop(&pGdiInterop);
     if (FAILED(hr)) {
         goto failed;
     }
@@ skipping 14 matching lines @@
         goto failed;
     }
     hr = pBitmapRenderTarget->SetPixelsPerDip(1.0f);
     if (FAILED(hr)) {
         goto failed;
     }
     *(CDwGdiTextRenderer**)renderTarget = new CDwGdiTextRenderer(pBitmap, pBitmapRenderTarget, pRenderingParams);
     SafeRelease(&pGdiInterop);
     SafeRelease(&pBitmapRenderTarget);
     SafeRelease(&pRenderingParams);
-    return TRUE;
+    return true;
 failed:
     SafeRelease(&pGdiInterop);
     SafeRelease(&pBitmapRenderTarget);
     SafeRelease(&pRenderingParams);
-    return FALSE;
+    return false;
 }
-FX_BOOL CDWriteExt::DwRendingString(void* renderTarget, CFX_ClipRgn* pClipRgn, FX_RECT& stringRect, CFX_AffineMatrix* pMatrix,
+bool    CDWriteExt::DwRendingString(void* renderTarget, CFX_ClipRgn* pClipRgn, FX_RECT& stringRect, CFX_AffineMatrix* pMatrix,
                                     void *font, FX_FLOAT font_size, FX_ARGB text_color,
                                     int glyph_count, unsigned short* glyph_indices,
                                     FX_FLOAT baselineOriginX, FX_FLOAT baselineOriginY,
                                     void* glyph_offsets,
                                     FX_FLOAT* glyph_advances)
 {
     if (renderTarget == NULL) {
-        return TRUE;
+        return true;
     }
     CDwGdiTextRenderer* pTextRenderer = (CDwGdiTextRenderer*)renderTarget;
     DWRITE_MATRIX transform;
     DWRITE_GLYPH_RUN glyphRun;
     HRESULT hr = S_OK;
     if (pMatrix) {
         transform.m11 = pMatrix->a;
         transform.m12 = pMatrix->b;
         transform.m21 = pMatrix->c;
         transform.m22 = pMatrix->d;
         transform.dx = pMatrix->e;
         transform.dy = pMatrix->f;
     }
     glyphRun.fontFace = (IDWriteFontFace*)font;
     glyphRun.fontEmSize = font_size;
     glyphRun.glyphCount = glyph_count;
     glyphRun.glyphIndices = glyph_indices;
     glyphRun.glyphAdvances = glyph_advances;
     glyphRun.glyphOffsets = (DWRITE_GLYPH_OFFSET*)glyph_offsets;
-    glyphRun.isSideways = FALSE;
+    glyphRun.isSideways = false;
     glyphRun.bidiLevel = 0;
     hr = pTextRenderer->DrawGlyphRun(
              stringRect,
              pClipRgn,
              pMatrix ? &transform : NULL,
              baselineOriginX, baselineOriginY,
              DWRITE_MEASURING_MODE_NATURAL,
              &glyphRun,
              RGB(FXARGB_R(text_color), FXARGB_G(text_color), FXARGB_B(text_color))
          );
-    return SUCCEEDED(hr) ? TRUE : FALSE;
+    return SUCCEEDED(hr) ? true : false;
 }
 void CDWriteExt::DwDeleteRenderingTarget(void* renderTarget)
 {
     delete (CDwGdiTextRenderer*)renderTarget;
 }
 void CDWriteExt::DwDeleteFont(void* pFont)
 {
     if (pFont) {
         SafeRelease((IDWriteFontFace**)&pFont);
     }
@@ skipping 190 matching lines @@
         text_bbox.Height(),
         &dib,
         text_bbox.left,
         text_bbox.top,
         FXDIB_BLEND_NORMAL,
         pClipRgn
     );
     return hr;
 }
 #endif