FX_BOOL considered harmful.

core/include/fxcrt/fx_xml.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_INCLUDE_FXCRT_FX_XML_H_
 #define CORE_INCLUDE_FXCRT_FX_XML_H_
 
 #include "fx_basic.h"
@@ skipping 20 matching lines @@
     void                                        SetAt(const CFX_ByteStringC& space, const CFX_ByteStringC& name, const CFX_WideStringC& value);
     void                                        RemoveAt(const CFX_ByteStringC& space, const CFX_ByteStringC& name);
     void                                        RemoveAll();
     int                                         GetSize() const;
     CXML_AttrItem&                      GetAt(int index) const;
     CFX_ObjectArray<CXML_AttrItem>*     m_pMap;
 };
 class CXML_Content
 {
 public:
-    CXML_Content() : m_bCDATA(FALSE), m_Content() {}
-    void        Set(FX_BOOL bCDATA, const CFX_WideStringC& content)
+    CXML_Content() : m_bCDATA(false), m_Content() {}
+    void        Set(bool bCDATA, const CFX_WideStringC& content)
     {
         m_bCDATA = bCDATA;
         m_Content = content;
     }
-    FX_BOOL                     m_bCDATA;
+    bool                        m_bCDATA;
     CFX_WideString      m_Content;
 };
 class CXML_Element
 {
 public:
-    static CXML_Element*        Parse(const void* pBuffer, size_t size, FX_BOOL bSaveSpaceChars = FALSE, FX_FILESIZE* pParsedSize = NULL);
-    static CXML_Element*        Parse(IFX_FileRead *pFile, FX_BOOL bSaveSpaceChars = FALSE, FX_FILESIZE* pParsedSize = NULL);
-    static CXML_Element*        Parse(IFX_BufferRead *pBuffer, FX_BOOL bSaveSpaceChars = FALSE, FX_FILESIZE* pParsedSize = NULL);
+    static CXML_Element*        Parse(const void* pBuffer, size_t size, bool bSaveSpaceChars = false, FX_FILESIZE* pParsedSize = NULL);
+    static CXML_Element*        Parse(IFX_FileRead *pFile, bool bSaveSpaceChars = false, FX_FILESIZE* pParsedSize = NULL);
+    static CXML_Element*        Parse(IFX_BufferRead *pBuffer, bool bSaveSpaceChars = false, FX_FILESIZE* pParsedSize = NULL);
     CXML_Element(const CFX_ByteStringC& qSpace, const CFX_ByteStringC& tagName);
     CXML_Element(const CFX_ByteStringC& qTagName);
     CXML_Element();
 
     ~CXML_Element();
 
     void        Empty();
 
 
 
-    CFX_ByteString                      GetTagName(FX_BOOL bQualified = FALSE) const;
+    CFX_ByteString                      GetTagName(bool bQualified = false) const;
 
-    CFX_ByteString                      GetNamespace(FX_BOOL bQualified = FALSE) const;
+    CFX_ByteString                      GetNamespace(bool bQualified = false) const;
 
     CFX_ByteString                      GetNamespaceURI(const CFX_ByteStringC& qName) const;
 
     CXML_Element*                       GetParent() const
     {
         return m_pParent;
     }
 
     FX_DWORD                            CountAttrs() const
     {
         return m_AttrMap.GetSize();
     }
 
     void                                        GetAttrByIndex(int index, CFX_ByteString &space, CFX_ByteString &name, CFX_WideString &value) const;
 
-    FX_BOOL                                     HasAttr(const CFX_ByteStringC& qName) const;
+    bool                                        HasAttr(const CFX_ByteStringC& qName) const;
 
-    FX_BOOL                                     GetAttrValue(const CFX_ByteStringC& name, CFX_WideString& attribute) const;
+    bool                                        GetAttrValue(const CFX_ByteStringC& name, CFX_WideString& attribute) const;
     CFX_WideString                      GetAttrValue(const CFX_ByteStringC& name) const
     {
         CFX_WideString attr;
         GetAttrValue(name, attr);
         return attr;
     }
 
-    FX_BOOL                                     GetAttrValue(const CFX_ByteStringC& space, const CFX_ByteStringC& name, CFX_WideString& attribute) const;
+    bool                                        GetAttrValue(const CFX_ByteStringC& space, const CFX_ByteStringC& name, CFX_WideString& attribute) const;
     CFX_WideString                      GetAttrValue(const CFX_ByteStringC& space, const CFX_ByteStringC& name) const
     {
         CFX_WideString attr;
         GetAttrValue(space, name, attr);
         return attr;
     }
 
-    FX_BOOL                                     GetAttrInteger(const CFX_ByteStringC& name, int& attribute) const;
+    bool                                        GetAttrInteger(const CFX_ByteStringC& name, int& attribute) const;
     int                                         GetAttrInteger(const CFX_ByteStringC& name) const
     {
         int attr = 0;
         GetAttrInteger(name, attr);
         return attr;
     }
 
-    FX_BOOL                                     GetAttrInteger(const CFX_ByteStringC& space, const CFX_ByteStringC& name, int& attribute) const;
+    bool                                        GetAttrInteger(const CFX_ByteStringC& space, const CFX_ByteStringC& name, int& attribute) const;
     int                                         GetAttrInteger(const CFX_ByteStringC& space, const CFX_ByteStringC& name) const
     {
         int attr = 0;
         GetAttrInteger(space, name, attr);
         return attr;
     }
 
-    FX_BOOL                                     GetAttrFloat(const CFX_ByteStringC& name, FX_FLOAT& attribute) const;
+    bool                                        GetAttrFloat(const CFX_ByteStringC& name, FX_FLOAT& attribute) const;
     FX_FLOAT                            GetAttrFloat(const CFX_ByteStringC& name) const
     {
         FX_FLOAT attr = 0;
         GetAttrFloat(name, attr);
         return attr;
     }
 
-    FX_BOOL                                     GetAttrFloat(const CFX_ByteStringC& space, const CFX_ByteStringC& name, FX_FLOAT& attribute) const;
+    bool                                        GetAttrFloat(const CFX_ByteStringC& space, const CFX_ByteStringC& name, FX_FLOAT& attribute) const;
     FX_FLOAT                            GetAttrFloat(const CFX_ByteStringC& space, const CFX_ByteStringC& name) const
     {
         FX_FLOAT attr = 0;
         GetAttrFloat(space, name, attr);
         return attr;
     }
 
     FX_DWORD                            CountChildren() const;
 
     enum ChildType { Invalid, Element, Content};
@@ skipping 34 matching lines @@
     CFX_ByteString                      m_TagName;
 
     CXML_AttrMap                        m_AttrMap;
 
     CFX_PtrArray                        m_Children;
     friend class CXML_Parser;
     friend class CXML_Composer;
 };
 
 #endif  // CORE_INCLUDE_FXCRT_FX_XML_H_