FX_BOOL considered harmful.

core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_serial.h"
 CFDF_Document::CFDF_Document() : CPDF_IndirectObjects(NULL)
 {
     m_pRootDict = NULL;
     m_pFile = NULL;
-    m_bOwnFile = FALSE;
+    m_bOwnFile = false;
 }
 CFDF_Document::~CFDF_Document()
 {
     if (m_bOwnFile && m_pFile) {
         m_pFile->Release();
     }
 }
 CFDF_Document* CFDF_Document::CreateNewDoc()
 {
     CFDF_Document* pDoc = new CFDF_Document;
     pDoc->m_pRootDict = new CPDF_Dictionary;
     pDoc->AddIndirectObject(pDoc->m_pRootDict);
     CPDF_Dictionary* pFDFDict = new CPDF_Dictionary;
     pDoc->m_pRootDict->SetAt(FX_BSTRC("FDF"), pFDFDict);
     return pDoc;
 }
-CFDF_Document* CFDF_Document::ParseFile(IFX_FileRead *pFile, FX_BOOL bOwnFile)
+CFDF_Document* CFDF_Document::ParseFile(IFX_FileRead *pFile, bool bOwnFile)
 {
   if (!pFile) {
     return NULL;
   }
   CFDF_Document* pDoc = new CFDF_Document;
   pDoc->ParseStream(pFile, bOwnFile);
   if (pDoc->m_pRootDict == NULL) {
     delete pDoc;
     return NULL;
   }
   return pDoc;
 }
 CFDF_Document* CFDF_Document::ParseMemory(const uint8_t* pData, FX_DWORD size)
 {
-    return CFDF_Document::ParseFile(FX_CreateMemoryStream((uint8_t*)pData, size), TRUE);
+    return CFDF_Document::ParseFile(FX_CreateMemoryStream((uint8_t*)pData, size), true);
 }
-void CFDF_Document::ParseStream(IFX_FileRead *pFile, FX_BOOL bOwnFile)
+void CFDF_Document::ParseStream(IFX_FileRead *pFile, bool bOwnFile)
 {
     m_pFile = pFile;
     m_bOwnFile = bOwnFile;
     CPDF_SyntaxParser parser;
     parser.InitParser(m_pFile, 0);
     while (1) {
-        FX_BOOL bNumber;
+        bool bNumber;
         CFX_ByteString word = parser.GetNextWord(bNumber);
         if (bNumber) {
             FX_DWORD objnum = FXSYS_atoi(word);
             word = parser.GetNextWord(bNumber);
             if (!bNumber) {
                 break;
             }
             word = parser.GetNextWord(bNumber);
             if (word != FX_BSTRC("obj")) {
                 break;
             }
-            CPDF_Object* pObj = parser.GetObject(this, objnum, 0, FALSE);
+            CPDF_Object* pObj = parser.GetObject(this, objnum, 0, 0);
             if (pObj == NULL) {
                 break;
             }
             InsertIndirectObject(objnum, pObj);
             word = parser.GetNextWord(bNumber);
             if (word != FX_BSTRC("endobj")) {
                 break;
             }
         } else {
             if (word != FX_BSTRC("trailer")) {
                 break;
             }
             CPDF_Dictionary* pMainDict = (CPDF_Dictionary*)parser.GetObject(this, 0, 0, 0);
             if (pMainDict == NULL || pMainDict->GetType() != PDFOBJ_DICTIONARY) {
                 break;
             }
             m_pRootDict = pMainDict->GetDict(FX_BSTRC("Root"));
             pMainDict->Release();
             break;
         }
     }
 }
-FX_BOOL CFDF_Document::WriteBuf(CFX_ByteTextBuf& buf) const
+bool CFDF_Document::WriteBuf(CFX_ByteTextBuf& buf) const
 {
     if (m_pRootDict == NULL) {
-        return FALSE;
+        return false;
     }
     buf << FX_BSTRC("%FDF-1.2\r\n");
     FX_POSITION pos = m_IndirectObjs.GetStartPosition();
     while(pos) {
         size_t objnum;
         CPDF_Object* pObj;
         m_IndirectObjs.GetNextAssoc(pos, (void*&)objnum, (void*&)pObj);
         buf << (FX_DWORD)objnum << FX_BSTRC(" 0 obj\r\n") << pObj << FX_BSTRC("\r\nendobj\r\n\r\n");
     }
     buf << FX_BSTRC("trailer\r\n<</Root ") << m_pRootDict->GetObjNum() << FX_BSTRC(" 0 R>>\r\n%%EOF\r\n");
-    return TRUE;
+    return true;
 }
 CFX_WideString CFDF_Document::GetWin32Path() const
 {
     CPDF_Dictionary* pDict = m_pRootDict ? m_pRootDict->GetDict(FX_BSTRC("FDF")) : NULL;
     CPDF_Object* pFileSpec = pDict ? pDict->GetElementValue(FX_BSTRC("F")) : NULL;
     if (pFileSpec == NULL) {
         return CFX_WideString();
     }
     if (pFileSpec->GetType() == PDFOBJ_STRING) {
         return FPDF_FileSpec_GetWin32Path(m_pRootDict->GetDict(FX_BSTRC("FDF")));
@@ skipping 68 matching lines @@
         result += ':';
         result += ChangeSlash(wsFileName.c_str() + 2);
         return result;
     } else {
         CFX_WideString result;
         result += '\\';
         result += ChangeSlash(wsFileName.c_str());
         return result;
     }
 }