FX_BOOL considered harmful.

fpdfsdk/src/pdfwindow/PWL_EditCtrl.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/pdfwindow/PDFWindow.h"
 #include "../../include/pdfwindow/PWL_Wnd.h"
 #include "../../include/pdfwindow/PWL_EditCtrl.h"
 #include "../../include/pdfwindow/PWL_ScrollBar.h"
 #include "../../include/pdfwindow/PWL_Utils.h"
 #include "../../include/pdfwindow/PWL_Caret.h"
 #include "../../include/pdfwindow/PWL_FontMap.h"
 
 #define IsFloatZero(f)                                          ((f) < 0.0001 && (f) > -0.0001)
 #define IsFloatBigger(fa,fb)                            ((fa) > (fb) && !IsFloatZero((fa) - (fb)))
 #define IsFloatSmaller(fa,fb)                           ((fa) < (fb) && !IsFloatZero((fa) - (fb)))
 #define IsFloatEqual(fa,fb)                                     IsFloatZero((fa)-(fb))
 
 /* ---------------------------- CPWL_EditCtrl ------------------------------ */
 
 CPWL_EditCtrl::CPWL_EditCtrl() :
         m_pEdit(NULL),
         m_pEditCaret(NULL),
-        m_bMouseDown(FALSE),
+        m_bMouseDown(false),
         m_pEditNotify(NULL),
         m_nCharSet(DEFAULT_CHARSET),
         m_nCodePage(0)
 {
         m_pEdit = IFX_Edit::NewEdit();
         ASSERT(m_pEdit != NULL);
 }
 
 CPWL_EditCtrl::~CPWL_EditCtrl()
 {
         IFX_Edit::DelEdit(m_pEdit);
 }
 
 void CPWL_EditCtrl::OnCreate(PWL_CREATEPARAM & cp)
 {
         cp.eCursorType = FXCT_VBEAM;
 }
 
 void CPWL_EditCtrl::OnCreated()
 {
         SetFontSize(GetCreationParam().fFontSize);
 
         m_pEdit->SetFontMap(GetFontMap());
         m_pEdit->SetNotify(this);
         m_pEdit->Initialize();
 }
 
-FX_BOOL CPWL_EditCtrl::IsWndHorV()
+bool CPWL_EditCtrl::IsWndHorV()
 {
         CPDF_Matrix mt = GetWindowMatrix();
         CPDF_Point point1(0,1);
         CPDF_Point point2(1,1);
 
         mt.Transform(point1.x, point1.y);
         mt.Transform(point2.x, point2.y);
 
         return point2.y == point1.y;
 }
@@ skipping 96 matching lines @@
 void CPWL_EditCtrl::SetFontSize(FX_FLOAT fFontSize)
 {
         m_pEdit->SetFontSize(fFontSize);
 }
 
 FX_FLOAT CPWL_EditCtrl::GetFontSize() const
 {
         return m_pEdit->GetFontSize();
 }
 
-FX_BOOL CPWL_EditCtrl::OnKeyDown(FX_WORD nChar, FX_DWORD nFlag)
+bool CPWL_EditCtrl::OnKeyDown(FX_WORD nChar, FX_DWORD nFlag)
 {
-        if (m_bMouseDown) return TRUE;
+        if (m_bMouseDown) return true;
 
-        FX_BOOL bRet = CPWL_Wnd::OnKeyDown(nChar,nFlag);
+        bool bRet = CPWL_Wnd::OnKeyDown(nChar,nFlag);
 
         //FILTER
         switch (nChar)
         {
         default:
-                return FALSE;
+                return false;
         case FWL_VKEY_Delete:
         case FWL_VKEY_Up:
         case FWL_VKEY_Down:
         case FWL_VKEY_Left:
         case FWL_VKEY_Right:
         case FWL_VKEY_Home:
         case FWL_VKEY_End:
         case FWL_VKEY_Insert:
         case 'C':
         case 'V':
@@ skipping 11 matching lines @@
         if (nChar == FWL_VKEY_Delete)
         {
                 if (m_pEdit->IsSelected())
                         nChar = FWL_VKEY_Unknown;
         }
 
         switch (nChar)
         {
                 case FWL_VKEY_Delete:
                         Delete();
-                        return TRUE;
+                        return true;
                 case FWL_VKEY_Insert:
                         if (IsSHIFTpressed(nFlag))
                                 PasteText();
-                        return TRUE;
+                        return true;
                 case FWL_VKEY_Up:
-                        m_pEdit->OnVK_UP(IsSHIFTpressed(nFlag),FALSE);
-                        return TRUE;
+                        m_pEdit->OnVK_UP(IsSHIFTpressed(nFlag),false);
+                        return true;
                 case FWL_VKEY_Down:
-                        m_pEdit->OnVK_DOWN(IsSHIFTpressed(nFlag),FALSE);
-                        return TRUE;
+                        m_pEdit->OnVK_DOWN(IsSHIFTpressed(nFlag),false);
+                        return true;
                 case FWL_VKEY_Left:
-                        m_pEdit->OnVK_LEFT(IsSHIFTpressed(nFlag),FALSE);
-                        return TRUE;
+                        m_pEdit->OnVK_LEFT(IsSHIFTpressed(nFlag),false);
+                        return true;
                 case FWL_VKEY_Right:
-                        m_pEdit->OnVK_RIGHT(IsSHIFTpressed(nFlag),FALSE);
-                        return TRUE;
+                        m_pEdit->OnVK_RIGHT(IsSHIFTpressed(nFlag),false);
+                        return true;
                 case FWL_VKEY_Home:
                         m_pEdit->OnVK_HOME(IsSHIFTpressed(nFlag),IsCTRLpressed(nFlag));
-                        return TRUE;
+                        return true;
                 case FWL_VKEY_End:
                         m_pEdit->OnVK_END(IsSHIFTpressed(nFlag),IsCTRLpressed(nFlag));
-                        return TRUE;
+                        return true;
                 case FWL_VKEY_Unknown:
                         if (!IsSHIFTpressed(nFlag))
                                 Clear();
                         else
                                 CutText();
-                        return TRUE;
+                        return true;
                 default:
                         break;
         }
 
         return bRet;
 }
 
-FX_BOOL CPWL_EditCtrl::OnChar(FX_WORD nChar, FX_DWORD nFlag)
+bool CPWL_EditCtrl::OnChar(FX_WORD nChar, FX_DWORD nFlag)
 {
-        if (m_bMouseDown) return TRUE;
+        if (m_bMouseDown) return true;
 
         CPWL_Wnd::OnChar(nChar,nFlag);
 
         //FILTER
         switch (nChar)
         {
                 case 0x0A:
                 case 0x1B:
-                        return FALSE;
+                        return false;
                 default:
                         break;
         }
 
-        FX_BOOL bCtrl = IsCTRLpressed(nFlag);
-        FX_BOOL bAlt = IsALTpressed(nFlag);
-        FX_BOOL bShift = IsSHIFTpressed(nFlag);
+        bool bCtrl = IsCTRLpressed(nFlag);
+        bool bAlt = IsALTpressed(nFlag);
+        bool bShift = IsSHIFTpressed(nFlag);
 
         FX_WORD word = nChar;
 
         if (bCtrl && !bAlt)
         {
                 switch (nChar)
                 {
                         case 'C' - 'A' + 1:
                                 CopyText();
-                                return TRUE;
+                                return true;
                         case 'V' - 'A' + 1:
                                 PasteText();
-                                return TRUE;
+                                return true;
                         case 'X' - 'A' + 1:
                                 CutText();
-                                return TRUE;
+                                return true;
                         case 'A' - 'A' + 1:
                                 SelectAll();
-                                return TRUE;
+                                return true;
                         case 'Z' - 'A' + 1:
                                 if (bShift)
                                         Redo();
                                 else
                                         Undo();
-                                return TRUE;
+                                return true;
                         default:
                                 if (nChar < 32)
-                                        return FALSE;
+                                        return false;
                 }
         }
 
-        if (IsReadOnly()) return TRUE;
+        if (IsReadOnly()) return true;
 
         if (m_pEdit->IsSelected() && word ==  FWL_VKEY_Back)
                 word = FWL_VKEY_Unknown;
 
         Clear();
 
         switch (word)
         {
         case FWL_VKEY_Back:
                 Backspace();
                 break;
         case FWL_VKEY_Return:
                 InsertReturn();
                 break;
         case FWL_VKEY_Unknown:
                 break;
         default:
                 if (IsINSERTpressed(nFlag))
                         Delete();
                 InsertWord(word, GetCharSet());
                 break;
         }
 
-        return TRUE;
+        return true;
 }
 
-FX_BOOL CPWL_EditCtrl::OnLButtonDown(const CPDF_Point & point, FX_DWORD nFlag)
+bool CPWL_EditCtrl::OnLButtonDown(const CPDF_Point & point, FX_DWORD nFlag)
 {
         CPWL_Wnd::OnLButtonDown(point,nFlag);
 
         if (ClientHitTest(point))
         {
                 if (m_bMouseDown)
                         InvalidateRect();
 
-                m_bMouseDown = TRUE;
+                m_bMouseDown = true;
                 SetCapture();
 
                 m_pEdit->OnMouseDown(point,IsSHIFTpressed(nFlag),IsCTRLpressed(nFlag));
         }
 
-        return TRUE;
+        return true;
 }
 
-FX_BOOL CPWL_EditCtrl::OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag)
+bool CPWL_EditCtrl::OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag)
 {
         CPWL_Wnd::OnLButtonUp(point,nFlag);
 
         if (m_bMouseDown)
         {
                 //can receive keybord message
                 if (ClientHitTest(point) && !IsFocused())
                         SetFocus();
 
                 ReleaseCapture();
-                m_bMouseDown = FALSE;
+                m_bMouseDown = false;
         }
 
-        return TRUE;
+        return true;
 }
 
-FX_BOOL CPWL_EditCtrl::OnMouseMove(const CPDF_Point & point, FX_DWORD nFlag)
+bool CPWL_EditCtrl::OnMouseMove(const CPDF_Point & point, FX_DWORD nFlag)
 {
         CPWL_Wnd::OnMouseMove(point,nFlag);
 
         if (m_bMouseDown)
-                m_pEdit->OnMouseMove(point,FALSE,FALSE);
+                m_pEdit->OnMouseMove(point,false,false);
 
-        return TRUE;
+        return true;
 }
 
 CPDF_Rect CPWL_EditCtrl::GetContentRect() const
 {
         return m_pEdit->GetContentRect();
 }
 
-void CPWL_EditCtrl::SetEditCaret(FX_BOOL bVisible)
+void CPWL_EditCtrl::SetEditCaret(bool bVisible)
 {
         CPDF_Point ptHead(0,0),ptFoot(0,0);
 
         if (bVisible)
         {
                 GetCaretInfo(ptHead,ptFoot);
         }
 
         CPVT_WordPlace wpTemp = m_pEdit->GetCaretWordPlace();
         IOnSetCaret(bVisible,ptHead,ptFoot,wpTemp);
@@ skipping 25 matching lines @@
 
 void CPWL_EditCtrl::GetCaretPos(int32_t& x, int32_t& y) const
 {
         CPDF_Point ptHead(0,0), ptFoot(0,0);
 
         GetCaretInfo(ptHead,ptFoot);
 
         PWLtoWnd(ptHead, x, y);
 }
 
-void CPWL_EditCtrl::SetCaret(FX_BOOL bVisible, const CPDF_Point & ptHead, const CPDF_Point & ptFoot)
+void CPWL_EditCtrl::SetCaret(bool bVisible, const CPDF_Point & ptHead, const CPDF_Point & ptFoot)
 {
         if (m_pEditCaret)
         {
                 if (!IsFocused() || m_pEdit->IsSelected())
-                        bVisible = FALSE;
+                        bVisible = false;
 
                 m_pEditCaret->SetCaret(bVisible, ptHead, ptFoot);
         }
 }
 
-FX_BOOL CPWL_EditCtrl::IsModified() const
+bool    CPWL_EditCtrl::IsModified() const
 {
         return m_pEdit->IsModified();
 }
 
 CFX_WideString CPWL_EditCtrl::GetText() const
 {
         return m_pEdit->GetText();
 }
 
 void CPWL_EditCtrl::SetSel(int32_t nStartChar,int32_t nEndChar)
@@ skipping 16 matching lines @@
 {
         m_pEdit->SelectAll();
 }
 
 void CPWL_EditCtrl::Paint()
 {
         if (m_pEdit)
                 m_pEdit->Paint();
 }
 
-void CPWL_EditCtrl::EnableRefresh(FX_BOOL bRefresh)
+void CPWL_EditCtrl::EnableRefresh(bool bRefresh)
 {
         if (m_pEdit)
                 m_pEdit->EnableRefresh(bRefresh);
 }
 
 int32_t CPWL_EditCtrl::GetCaret() const
 {
         if (m_pEdit)
                 return m_pEdit->GetCaret();
 
@@ skipping 91 matching lines @@
 }
 
 void CPWL_EditCtrl::PasteText()
 {
 }
 
 void CPWL_EditCtrl::CutText()
 {
 }
 
-void CPWL_EditCtrl::ShowVScrollBar(FX_BOOL bShow)
+void CPWL_EditCtrl::ShowVScrollBar(bool bShow)
 {
 }
 
 void CPWL_EditCtrl::InsertText(const FX_WCHAR* csText)
 {
         if (!IsReadOnly())
                 m_pEdit->InsertText(csText);
 }
 
 void CPWL_EditCtrl::InsertWord(FX_WORD word, int32_t nCharset)
@@ skipping 13 matching lines @@
         if (!IsReadOnly())
                 m_pEdit->Delete();
 }
 
 void CPWL_EditCtrl::Backspace()
 {
         if (!IsReadOnly())
                 m_pEdit->Backspace();
 }
 
-FX_BOOL CPWL_EditCtrl::CanUndo() const
+bool    CPWL_EditCtrl::CanUndo() const
 {
         return !IsReadOnly() && m_pEdit->CanUndo();
 }
 
-FX_BOOL CPWL_EditCtrl::CanRedo() const
+bool    CPWL_EditCtrl::CanRedo() const
 {
         return !IsReadOnly() && m_pEdit->CanRedo();
 }
 
 void CPWL_EditCtrl::Redo()
 {
         if (CanRedo())
                 m_pEdit->Redo();
 }
 
@@ skipping 13 matching lines @@
         Info.fContentMin = fContentMin;
         Info.fContentMax = fContentMax;
         Info.fSmallStep = fSmallStep;
         Info.fBigStep = fBigStep;
 
         OnNotify(this,PNM_SETSCROLLINFO,SBT_VSCROLL,(intptr_t)&Info);
 
         if (IsFloatBigger(Info.fPlateWidth,Info.fContentMax-Info.fContentMin)
                 || IsFloatEqual(Info.fPlateWidth,Info.fContentMax-Info.fContentMin))
         {
-                ShowVScrollBar(FALSE);
+                ShowVScrollBar(false);
         }
         else
         {
-                ShowVScrollBar(TRUE);
+                ShowVScrollBar(true);
         }
 }
 
 void CPWL_EditCtrl::IOnSetScrollPosY(FX_FLOAT fy)
 {
     OnNotify(this, PNM_SETSCROLLPOS,SBT_VSCROLL, (intptr_t)&fy);
 }
 
-void CPWL_EditCtrl::IOnSetCaret(FX_BOOL bVisible, const CPDF_Point & ptHead, const CPDF_Point & ptFoot, const CPVT_WordPlace& place)
+void CPWL_EditCtrl::IOnSetCaret(bool bVisible, const CPDF_Point & ptHead, const CPDF_Point & ptFoot, const CPVT_WordPlace& place)
 {
         PWL_CARET_INFO cInfo;
         cInfo.bVisible = bVisible;
         cInfo.ptHead = ptHead;
         cInfo.ptFoot = ptFoot;
 
         OnNotify(this, PNM_SETCARETINFO, (intptr_t)&cInfo, (intptr_t)NULL);
 }
 
 void CPWL_EditCtrl::IOnCaretChange(const CPVT_SecProps & secProps, const CPVT_WordProps & wordProps)
@@ skipping 32 matching lines @@
         CPVT_WordPlace wpStart = m_pEdit->WordIndexToWordPlace(nStartChar);
         CPVT_WordPlace wpEnd = m_pEdit->WordIndexToWordPlace(nEndChar);
         return m_pEdit->GetRangeText(CPVT_WordRange(wpStart, wpEnd));
 }
 
 void    CPWL_EditCtrl::SetReadyToInput()
 {
         if (m_bMouseDown)
         {
                 ReleaseCapture();
-                m_bMouseDown = FALSE;
+                m_bMouseDown = false;
         }
 }