FX_BOOL considered harmful.

core/src/fpdfapi/fpdf_font/ttgsubtable.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../../third_party/base/nonstd_unique_ptr.h"
 #include "../../../include/fxge/fx_ge.h"
 #include "../../../include/fxge/fx_freetype.h"
 #include "ttgsubtable.h"
@@ skipping 30 matching lines @@
             low = mid + 1;
         } else if (buf[mid].key > key) {
             high = mid - 1;
         } else {
             buf[mid].value = value;
             return;
         }
     }
     m_Buffer.InsertBlock(low * sizeof(_IntPair), &pair, sizeof(_IntPair));
 }
-FX_BOOL CFX_GlyphMap::Lookup(int key, int &value)
+bool CFX_GlyphMap::Lookup(int key, int &value)
 {
     void* pResult = FXSYS_bsearch(&key, m_Buffer.GetBuffer(), m_Buffer.GetSize() / sizeof(_IntPair),
                                       sizeof(_IntPair), _CompareInt);
     if (pResult == NULL) {
-        return FALSE;
+        return false;
     }
     value = ((FX_DWORD*)pResult)[1];
-    return TRUE;
+    return true;
 }
 bool CFX_CTTGSUBTable::LoadGSUBTable(FT_Bytes gsub)
 {
     header.Version = gsub[0] << 24 | gsub[1] << 16 | gsub[2] << 8 | gsub[3];
     if(header.Version != 0x00010000) {
         return false;
     }
     header.ScriptList  = gsub[4] << 8 | gsub[5];
     header.FeatureList = gsub[6] << 8 | gsub[7];
     header.LookupList  = gsub[8] << 8 | gsub[9];
@@ skipping 31 matching lines @@
         if (!m_featureMap.GetStartPosition()) {
             for (int i = 0; i < FeatureList.FeatureCount; i ++) {
                 if (FeatureList.FeatureRecord[i].FeatureTag == tag[0] || FeatureList.FeatureRecord[i].FeatureTag == tag[1]) {
                     FX_DWORD value;
                     if (!m_featureMap.Lookup(i, value)) {
                         m_featureMap.SetAt(i, i);
                     }
                 }
             }
         }
-        m_bFeautureMapLoad = TRUE;
+        m_bFeautureMapLoad = true;
     }
     FX_POSITION pos = m_featureMap.GetStartPosition();
     while (pos) {
         FX_DWORD index, value;
         m_featureMap.GetNextAssoc(pos, index, value);
         if(GetVerticalGlyphSub(glyphnum, vglyphnum,     &FeatureList.FeatureRecord[value].Feature)) {
             return true;
         }
     }
     return false;
@@ skipping 291 matching lines @@
         &rec->Coverage);
     rec->GlyphCount = GetUInt16(sp);
     if(rec->GlyphCount <= 0) {
         return;
     }
     rec->Substitute = new TT_uint16_t[rec->GlyphCount];
     for(i = 0; i < rec->GlyphCount; i++) {
         rec->Substitute[i] = GetUInt16(sp);
     }
 }
-FX_BOOL CFX_GSUBTable::GetVerticalGlyph(FX_DWORD glyphnum, FX_DWORD* vglyphnum)
+bool CFX_GSUBTable::GetVerticalGlyph(FX_DWORD glyphnum, FX_DWORD* vglyphnum)
 {
     return m_GsubImp.GetVerticalGlyph(glyphnum, vglyphnum);
 }
 // static
 IFX_GSUBTable* IFX_GSUBTable::Create(CFX_Font* pFont)
 {
     if (!pFont) {
         return NULL;
     }
     if (NULL == pFont->m_pGsubData) {
         unsigned long length = 0;
         int error = FXFT_Load_Sfnt_Table(pFont->m_Face, FT_MAKE_TAG('G', 'S', 'U', 'B'), 0, NULL, &length);
         if (!error) {
             pFont->m_pGsubData = (unsigned char*)FX_Alloc(uint8_t, length);
         }
         if (!pFont->m_pGsubData) {
             return NULL;
         }
     }
     int error = FXFT_Load_Sfnt_Table(pFont->m_Face, FT_MAKE_TAG('G', 'S', 'U', 'B'), 0, pFont->m_pGsubData, NULL);
     if (!error && pFont->m_pGsubData) {
         nonstd::unique_ptr<CFX_GSUBTable> pGsubTable(new CFX_GSUBTable);
         if (pGsubTable->m_GsubImp.LoadGSUBTable((FT_Bytes)pFont->m_pGsubData)) {
             return pGsubTable.release();
         }
     }
     return NULL;
 }