fpdfsdk/include/fx_systemhandler.h - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/fx_systemhandler.h

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/include/fx_systemhandler.h

diff --git a/fpdfsdk/include/fx_systemhandler.h b/fpdfsdk/include/fx_systemhandler.h

index bf59e452ea89c94234337072bf9797a87a823884..30168d48b6ad3b67c0dd6e5bf7c7c5f4a1f475e5 100644

--- a/fpdfsdk/include/fx_systemhandler.h

+++ b/fpdfsdk/include/fx_systemhandler.h

@@ -47,10 +47,10 @@ public:

virtual void InvalidateRect(FX_HWND hWnd, FX_RECT rect) = 0;

virtual void OutputSelectedRect(void* pFormFiller, CPDF_Rect&rect) = 0;

- virtual FX_BOOL IsSelectionImplemented() = 0;

+ virtual bool IsSelectionImplemented() = 0;

virtual CFX_WideString GetClipboardText(FX_HWND hWnd) = 0;

- virtual FX_BOOL SetClipboardText(FX_HWND hWnd, CFX_WideString string) = 0;

+ virtual bool SetClipboardText(FX_HWND hWnd, CFX_WideString string) = 0;

virtual void ClientToScreen(FX_HWND hWnd, int32_t& x, int32_t& y) = 0;

virtual void ScreenToClient(FX_HWND hWnd, int32_t& x, int32_t& y) = 0;

@@ -66,23 +66,23 @@ public:

virtual void SetCursor(int32_t nCursorType) = 0;

virtual FX_HMENU CreatePopupMenu() = 0;

- virtual FX_BOOL AppendMenuItem(FX_HMENU hMenu, int32_t nIDNewItem, CFX_WideString string) = 0;

- virtual FX_BOOL EnableMenuItem(FX_HMENU hMenu, int32_t nIDItem, FX_BOOL bEnabled) = 0;

+ virtual bool AppendMenuItem(FX_HMENU hMenu, int32_t nIDNewItem, CFX_WideString string) = 0;

+ virtual bool EnableMenuItem(FX_HMENU hMenu, int32_t nIDItem, bool bEnabled) = 0;

virtual int32_t TrackPopupMenu(FX_HMENU hMenu, int32_t x, int32_t y, FX_HWND hParent) = 0;

virtual void DestroyMenu(FX_HMENU hMenu) = 0;

virtual CFX_ByteString GetNativeTrueTypeFont(int32_t nCharset) = 0;

- virtual FX_BOOL FindNativeTrueTypeFont(int32_t nCharset, CFX_ByteString sFontFaceName) = 0;

+ virtual bool FindNativeTrueTypeFont(int32_t nCharset, CFX_ByteString sFontFaceName) = 0;

virtual CPDF_Font* AddNativeTrueTypeFontToPDF(CPDF_Document* pDoc, CFX_ByteString sFontFaceName, uint8_t nCharset) = 0;

virtual int32_t SetTimer(int32_t uElapse, TimerCallback lpTimerFunc) = 0;

virtual void KillTimer(int32_t nID) = 0;

- virtual FX_BOOL IsSHIFTKeyDown(FX_DWORD nFlag) = 0;

- virtual FX_BOOL IsCTRLKeyDown(FX_DWORD nFlag) = 0;

- virtual FX_BOOL IsALTKeyDown(FX_DWORD nFlag) = 0;

- virtual FX_BOOL IsINSERTKeyDown(FX_DWORD nFlag) = 0;

+ virtual bool IsSHIFTKeyDown(FX_DWORD nFlag) = 0;

+ virtual bool IsCTRLKeyDown(FX_DWORD nFlag) = 0;

+ virtual bool IsALTKeyDown(FX_DWORD nFlag) = 0;

+ virtual bool IsINSERTKeyDown(FX_DWORD nFlag) = 0;

virtual FX_SYSTEMTIME GetLocalTime() = 0;

« no previous file with comments | « fpdfsdk/include/fsdk_rendercontext.h ('k') | fpdfsdk/include/fxedit/fx_edit.h » ('j') | no next file with comments »