core/src/fxge/android/fpf_skiafont.h - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/android/fpf_skiafont.h

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxge/android/fpf_skiafont.h

diff --git a/core/src/fxge/android/fpf_skiafont.h b/core/src/fxge/android/fpf_skiafont.h

index 49819d4c11f7732b10d139746228e97428bd3afb..90cf5cb29c6a31011951f9f20a1f2038fef83cb9 100644

--- a/core/src/fxge/android/fpf_skiafont.h

+++ b/core/src/fxge/android/fpf_skiafont.h

@@ -39,13 +39,13 @@ public:

virtual int32_t GetAscent() const;

virtual int32_t GetDescent() const;

- virtual FX_BOOL GetGlyphBBox(int32_t iGlyphIndex, FX_RECT &rtBBox);

- virtual FX_BOOL GetBBox(FX_RECT &rtBBox);

+ virtual bool GetGlyphBBox(int32_t iGlyphIndex, FX_RECT &rtBBox);

+ virtual bool GetBBox(FX_RECT &rtBBox);

virtual int32_t GetHeight() const;

virtual int32_t GetItalicAngle() const;

virtual FX_DWORD GetFontData(FX_DWORD dwTable, uint8_t* pBuffer, FX_DWORD dwSize);

- FX_BOOL InitFont(CFPF_SkiaFontMgr *pFontMgr, CFPF_SkiaFontDescriptor *pFontDes, const CFX_ByteStringC& bsFamily, FX_DWORD dwStyle, uint8_t uCharset);

+ bool InitFont(CFPF_SkiaFontMgr *pFontMgr, CFPF_SkiaFontDescriptor *pFontDes, const CFX_ByteStringC& bsFamily, FX_DWORD dwStyle, uint8_t uCharset);

protected:

CFPF_SkiaFontMgr *m_pFontMgr;

CFPF_SkiaFontDescriptor *m_pFontDes;

« no previous file with comments | « core/src/fxge/agg/src/fx_agg_driver.cpp ('k') | core/src/fxge/android/fpf_skiafont.cpp » ('j') | no next file with comments »