fpdfsdk/include/javascript/JS_GlobalData.h - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/javascript/JS_GlobalData.h

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/javascript/JS_GlobalData.h

diff --git a/fpdfsdk/include/javascript/JS_GlobalData.h b/fpdfsdk/include/javascript/JS_GlobalData.h

index b3637b93d567d9b91cb7c86bd145219f7a9732ea..987de9566681b4929f0f89bba735eddaf5572d5c 100644

--- a/fpdfsdk/include/javascript/JS_GlobalData.h

+++ b/fpdfsdk/include/javascript/JS_GlobalData.h

@@ -56,7 +56,7 @@ public:

virtual ~CJS_GlobalData_Element(){}

CJS_KeyValue data;

- FX_BOOL bPersistent;

+ bool bPersistent;

};

class CJS_GlobalData

@@ -72,8 +72,8 @@ public:

void SetGlobalVariableObject(const FX_CHAR* propname, const CJS_GlobalVariableArray& array);

void SetGlobalVariableNull(const FX_CHAR* propname);

- FX_BOOL SetGlobalVariablePersistent(const FX_CHAR* propname, FX_BOOL bPersistent);

- FX_BOOL DeleteGlobalVariable(const FX_CHAR* propname);

+ bool SetGlobalVariablePersistent(const FX_CHAR* propname, bool bPersistent);

+ bool DeleteGlobalVariable(const FX_CHAR* propname);

int32_t GetSize() const;

CJS_GlobalData_Element* GetAt(int index) const;

« no previous file with comments | « fpdfsdk/include/javascript/JS_EventHandler.h ('k') | fpdfsdk/include/javascript/JS_Object.h » ('j') | no next file with comments »