FX_BOOL considered harmful.

fpdfsdk/src/fpdfsave.cpp

Index: fpdfsdk/src/fpdfsave.cpp
diff --git a/fpdfsdk/src/fpdfsave.cpp b/fpdfsdk/src/fpdfsave.cpp
index 4b9d7acecff417d976cb81df3e01462d5eaf14bb..4c54176810497cdb85be69285e589c3d4c608767 100644
--- a/fpdfsdk/src/fpdfsave.cpp
+++ b/fpdfsdk/src/fpdfsave.cpp
@@ -19,8 +19,8 @@ class CFX_IFileWrite final : public IFX_StreamWrite
 
 public:
 	CFX_IFileWrite();
-	FX_BOOL				Init( FPDF_FILEWRITE * pFileWriteStruct );
-	virtual	FX_BOOL		WriteBlock(const void* pData, size_t size) override;
+	bool				Init( FPDF_FILEWRITE * pFileWriteStruct );
+	virtual	bool		WriteBlock(const void* pData, size_t size) override;
 	virtual void		Release() override {}
 
 protected:
@@ -32,26 +32,26 @@ CFX_IFileWrite::CFX_IFileWrite()
 	m_pFileWriteStruct = NULL;
 }
 
-FX_BOOL CFX_IFileWrite::Init( FPDF_FILEWRITE * pFileWriteStruct )
+bool CFX_IFileWrite::Init( FPDF_FILEWRITE * pFileWriteStruct )
 {
 	if (!pFileWriteStruct)
-		return FALSE;
+		return false;
 	else
 	{
 		m_pFileWriteStruct = pFileWriteStruct;
 	}
-	return TRUE;
+	return true;
 }
 
-FX_BOOL CFX_IFileWrite::WriteBlock(const void* pData, size_t size)
+bool CFX_IFileWrite::WriteBlock(const void* pData, size_t size)
 {
 	if (m_pFileWriteStruct)
 	{
 		m_pFileWriteStruct->WriteBlock( m_pFileWriteStruct, pData, size );
-		return TRUE;
+		return true;
 	}
 	else
-		return FALSE;
+		return false;
 }
 
 FPDF_BOOL _FPDF_Doc_Save(FPDF_DOCUMENT document,FPDF_FILEWRITE * pFileWrite,FPDF_DWORD flags, FPDF_BOOL bSetVersion,
@@ -75,7 +75,7 @@ FPDF_BOOL _FPDF_Doc_Save(FPDF_DOCUMENT document,FPDF_FILEWRITE * pFileWrite,FPDF
 		FileMaker.RemoveSecurity();
 	}
 	CFX_IFileWrite* pStreamWrite = NULL;
-	FX_BOOL bRet;
+	bool bRet;
 	pStreamWrite = new CFX_IFileWrite;
 	pStreamWrite->Init( pFileWrite );
 	bRet = FileMaker.Create(pStreamWrite, flags);
@@ -86,12 +86,12 @@ FPDF_BOOL _FPDF_Doc_Save(FPDF_DOCUMENT document,FPDF_FILEWRITE * pFileWrite,FPDF
 DLLEXPORT FPDF_BOOL STDCALL FPDF_SaveAsCopy(	FPDF_DOCUMENT document,FPDF_FILEWRITE * pFileWrite,
 												FPDF_DWORD flags )
 {
-	return _FPDF_Doc_Save(document, pFileWrite, flags, FALSE , 0);
+	return _FPDF_Doc_Save(document, pFileWrite, flags, false , 0);
 }
 
 
 DLLEXPORT FPDF_BOOL STDCALL FPDF_SaveWithVersion(	FPDF_DOCUMENT document,FPDF_FILEWRITE * pFileWrite,
 	FPDF_DWORD flags, int fileVersion)
 {
-	return _FPDF_Doc_Save(document, pFileWrite, flags, TRUE , fileVersion);
+	return _FPDF_Doc_Save(document, pFileWrite, flags, true , fileVersion);
 }