fpdfsdk/include/pdfwindow/PWL_SpecialButton.h - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/pdfwindow/PWL_SpecialButton.h

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/pdfwindow/PWL_SpecialButton.h

diff --git a/fpdfsdk/include/pdfwindow/PWL_SpecialButton.h b/fpdfsdk/include/pdfwindow/PWL_SpecialButton.h

index f6659dfb001be5e7ee56db4511ff1979b0cc8652..14e576d86894e03fe263963e4bf3433d49956007 100644

--- a/fpdfsdk/include/pdfwindow/PWL_SpecialButton.h

+++ b/fpdfsdk/include/pdfwindow/PWL_SpecialButton.h

@@ -26,14 +26,14 @@ public:

virtual ~CPWL_CheckBox();

virtual CFX_ByteString GetClassName() const;

- virtual FX_BOOL OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag);

- virtual FX_BOOL OnChar(FX_WORD nChar, FX_DWORD nFlag);

+ virtual bool OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag);

+ virtual bool OnChar(FX_WORD nChar, FX_DWORD nFlag);

- void SetCheck(FX_BOOL bCheck);

- FX_BOOL IsChecked() const;

+ void SetCheck(bool bCheck);

+ bool IsChecked() const;

private:

- FX_BOOL m_bChecked;

+ bool m_bChecked;

};

class PWL_CLASS CPWL_RadioButton : public CPWL_Button

@@ -43,14 +43,14 @@ public:

virtual ~CPWL_RadioButton();