fpdfsdk/include/formfiller/FFL_ListBox.h - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/formfiller/FFL_ListBox.h

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: fpdfsdk/include/formfiller/FFL_ListBox.h

diff --git a/fpdfsdk/include/formfiller/FFL_ListBox.h b/fpdfsdk/include/formfiller/FFL_ListBox.h

index 4c0813f5c84a3619a5c2670dbaec444e0537065d..59e3d6c689f6f462e41085293a292bdecbc421e9 100644

--- a/fpdfsdk/include/formfiller/FFL_ListBox.h

+++ b/fpdfsdk/include/formfiller/FFL_ListBox.h

@@ -23,10 +23,10 @@ public:

virtual CPWL_Wnd* NewPDFWindow(const PWL_CREATEPARAM& cp,

CPDFSDK_PageView* pPageView);

- virtual FX_BOOL OnChar(CPDFSDK_Annot* pAnnot, FX_UINT nChar,

+ virtual bool OnChar(CPDFSDK_Annot* pAnnot, FX_UINT nChar,

FX_UINT nFlags);

- virtual FX_BOOL IsDataChanged(CPDFSDK_PageView* pPageView);

+ virtual bool IsDataChanged(CPDFSDK_PageView* pPageView);

virtual void SaveData(CPDFSDK_PageView* pPageView);

virtual void GetActionData(CPDFSDK_PageView* pPageView,

@@ -40,8 +40,8 @@ public:

virtual void RestoreState(CPDFSDK_PageView* pPageView);

virtual CPWL_Wnd* ResetPDFWindow(CPDFSDK_PageView* pPageView,

- FX_BOOL bRestoreValue);

- virtual void OnKeyStroke(FX_BOOL bKeyDown, FX_DWORD nFlag);

+ bool bRestoreValue);

+ virtual void OnKeyStroke(bool bKeyDown, FX_DWORD nFlag);

private:

CBA_FontMap* m_pFontMap;