FX_BOOL considered harmful.

core/src/fpdfdoc/pdf_vt.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_SRC_FPDFDOC_PDF_VT_H_
 #define CORE_SRC_FPDFDOC_PDF_VT_H_
 
 class CPVT_Size;
@@ skipping 173 matching lines @@
     }
     FX_FLOAT Range() const
     {
         return fMax - fMin;
     }
     FX_FLOAT fMin, fMax;
 };
 template<class TYPE> class CPVT_ArrayTemplate : public CFX_ArrayTemplate<TYPE>
 {
 public:
-    FX_BOOL IsEmpty()
+    bool IsEmpty()
     {
         return CFX_ArrayTemplate<TYPE>::GetSize() <= 0;
     }
     TYPE GetAt(int nIndex) const
     {
         if (nIndex >= 0 && nIndex < CFX_ArrayTemplate<TYPE>::GetSize()) {
             return CFX_ArrayTemplate<TYPE>::GetAt(nIndex);
         }
         return NULL;
     }
@@ skipping 104 matching lines @@
 };
 class CTypeset
 {
 public:
     CTypeset(CSection * pSection);
     virtual ~CTypeset();
     CPVT_Size                                                           GetEditSize(FX_FLOAT fFontSize);
     CPVT_FloatRect                                                      Typeset();
     CPVT_FloatRect                                                      CharArray();
 private:
-    void                                                                        SplitLines(FX_BOOL bTypeset, FX_FLOAT fFontSize);
+    void                                                                        SplitLines(bool bTypeset, FX_FLOAT fFontSize);
     void                                                                        OutputLines();
 
     CPVT_FloatRect                                                      m_rcRet;
     CPDF_VariableText                                           * m_pVT;
     CSection                                                            * m_pSection;
 };
 class CPDF_EditContainer
 {
 public:
     CPDF_EditContainer(): m_rcPlate(0, 0, 0, 0), m_rcContent(0, 0, 0, 0) {};
@@ skipping 86 matching lines @@
         m_nLimitChar = nLimitChar;
     }
     void                                                                        SetCharSpace(FX_FLOAT fCharSpace = 0.0f)
     {
         m_fCharSpace = fCharSpace;
     }
     void                                                                        SetHorzScale(int32_t nHorzScale = 100)
     {
         m_nHorzScale = nHorzScale;
     }
-    void                                                                        SetMultiLine(FX_BOOL bMultiLine = TRUE)
+    void                                                                        SetMultiLine(bool bMultiLine = true)
     {
         m_bMultiLine = bMultiLine;
     }
-    void                                                                        SetAutoReturn(FX_BOOL bAuto = TRUE)
+    void                                                                        SetAutoReturn(bool bAuto = true)
     {
         m_bLimitWidth = bAuto;
     }
     void                                                                        SetFontSize(FX_FLOAT fFontSize)
     {
         m_fFontSize = fFontSize;
     }
     void                                                                        SetCharArray(int32_t nCharArray = 0)
     {
         m_nCharArray = nCharArray;
     }
-    void                                                                        SetAutoFontSize(FX_BOOL bAuto = TRUE)
+    void                                                                        SetAutoFontSize(bool bAuto = true)
     {
         m_bAutoFontSize = bAuto;
     }
-    void                                                                        SetRichText(FX_BOOL bRichText)
+    void                                                                        SetRichText(bool bRichText)
     {
         m_bRichText = bRichText;
     }
     void                                                                        SetLineLeading(FX_FLOAT fLineLeading)
     {
         m_fLineLeading = fLineLeading;
     }
     void                                                                        Initialize();
-    FX_BOOL                                                                     IsValid() const
+    bool                                                                        IsValid() const
     {
         return m_bInitial;
     }
-    FX_BOOL                                                                     IsRichText() const
+    bool                                                                        IsRichText() const
     {
         return m_bRichText;
     }
     void                                                                        RearrangeAll();
     void                                                                        RearrangePart(const CPVT_WordRange & PlaceRange);
     void                                                                        ResetAll();
     void                                                                        SetText(const FX_WCHAR* text, int32_t charset = 1, const CPVT_SecProps * pSecProps = NULL,
             const CPVT_WordProps * pWordProps = NULL);
     CPVT_WordPlace                                                      InsertWord(const CPVT_WordPlace & place, FX_WORD word, int32_t charset = 1,
             const CPVT_WordProps * pWordProps = NULL);
@@ skipping 19 matching lines @@
         return m_nAlignment;
     }
     int32_t                                                             GetCharArray() const
     {
         return m_nCharArray;
     }
     int32_t                                                             GetLimitChar() const
     {
         return m_nLimitChar;
     }
-    FX_BOOL                                                                     IsMultiLine() const
+    bool                                                                        IsMultiLine() const
     {
         return m_bMultiLine;
     }
     int32_t                                                             GetHorzScale() const
     {
         return m_nHorzScale;
     }
     FX_FLOAT                                                            GetCharSpace() const
     {
         return m_fCharSpace;
@@ skipping 20 matching lines @@
     FX_WORD                                                                     GetSubWord() const
     {
         return m_wSubWord;
     }
 private:
     int32_t                                                             GetCharWidth(int32_t nFontIndex, FX_WORD Word, FX_WORD SubWord, int32_t nWordStyle);
     int32_t                                                             GetTypeAscent(int32_t nFontIndex);
     int32_t                                                             GetTypeDescent(int32_t nFontIndex);
     int32_t                                                             GetWordFontIndex(FX_WORD word, int32_t charset, int32_t nFontIndex);
     int32_t                                                             GetDefaultFontIndex();
-    FX_BOOL                                                                     IsLatinWord(FX_WORD word);
+    bool                                                                        IsLatinWord(FX_WORD word);
 private:
 
     CPVT_WordPlace                                                      AddSection(const CPVT_WordPlace & place, const CPVT_SectionInfo & secinfo);
     CPVT_WordPlace                                                      AddLine(const CPVT_WordPlace & place, const CPVT_LineInfo & lineinfo);
     CPVT_WordPlace                                                      AddWord(const CPVT_WordPlace & place, const CPVT_WordInfo & wordinfo);
-    FX_BOOL                                                                     GetWordInfo(const CPVT_WordPlace & place, CPVT_WordInfo & wordinfo);
-    FX_BOOL                                                                     SetWordInfo(const CPVT_WordPlace & place, const CPVT_WordInfo & wordinfo);
-    FX_BOOL                                                                     GetLineInfo(const CPVT_WordPlace & place, CPVT_LineInfo & lineinfo);
-    FX_BOOL                                                                     GetSectionInfo(const CPVT_WordPlace & place, CPVT_SectionInfo & secinfo);
-    FX_FLOAT                                                            GetWordFontSize(const CPVT_WordInfo & WordInfo, FX_BOOL bFactFontSize = FALSE);
+    bool                                                                        GetWordInfo(const CPVT_WordPlace & place, CPVT_WordInfo & wordinfo);
+    bool                                                                        SetWordInfo(const CPVT_WordPlace & place, const CPVT_WordInfo & wordinfo);
+    bool                                                                        GetLineInfo(const CPVT_WordPlace & place, CPVT_LineInfo & lineinfo);
+    bool                                                                        GetSectionInfo(const CPVT_WordPlace & place, CPVT_SectionInfo & secinfo);
+    FX_FLOAT                                                            GetWordFontSize(const CPVT_WordInfo & WordInfo, bool bFactFontSize = false);
     FX_FLOAT                                                            GetWordWidth(int32_t nFontIndex, FX_WORD Word, FX_WORD SubWord,
             FX_FLOAT fCharSpace, int32_t nHorzScale,
             FX_FLOAT fFontSize, FX_FLOAT fWordTail, int32_t nWordStyle);
     FX_FLOAT                                                            GetWordWidth(const CPVT_WordInfo & WordInfo);
     FX_FLOAT                                                            GetWordAscent(const CPVT_WordInfo & WordInfo, FX_FLOAT fFontSize);
     FX_FLOAT                                                            GetWordDescent(const CPVT_WordInfo & WordInfo, FX_FLOAT fFontSize);
-    FX_FLOAT                                                            GetWordAscent(const CPVT_WordInfo & WordInfo, FX_BOOL bFactFontSize = FALSE);
-    FX_FLOAT                                                            GetWordDescent(const CPVT_WordInfo & WordInfo, FX_BOOL bFactFontSize = FALSE);
+    FX_FLOAT                                                            GetWordAscent(const CPVT_WordInfo & WordInfo, bool bFactFontSize = false);
+    FX_FLOAT                                                            GetWordDescent(const CPVT_WordInfo & WordInfo, bool bFactFontSize = false);
     FX_FLOAT                                                            GetLineAscent(const CPVT_SectionInfo & SecInfo);
     FX_FLOAT                                                            GetLineDescent(const CPVT_SectionInfo & SecInfo);
     FX_FLOAT                                                            GetFontAscent(int32_t nFontIndex, FX_FLOAT fFontSize);
     FX_FLOAT                                                            GetFontDescent(int32_t nFontIndex, FX_FLOAT fFontSize);
     int32_t                                                             GetWordFontIndex(const CPVT_WordInfo & WordInfo);
     FX_FLOAT                                                            GetCharSpace(const CPVT_WordInfo & WordInfo);
     int32_t                                                             GetHorzScale(const CPVT_WordInfo & WordInfo);
     FX_FLOAT                                                            GetLineLeading(const CPVT_SectionInfo & SecInfo);
     FX_FLOAT                                                            GetLineIndent(const CPVT_SectionInfo & SecInfo);
     int32_t                                                             GetAlignment(const CPVT_SectionInfo& SecInfo);
 
     void                                                                        ClearSectionRightWords(const CPVT_WordPlace & place);
-    CPVT_WordPlace                                                      AjustLineHeader(const CPVT_WordPlace & place, FX_BOOL bPrevOrNext) const;
-    FX_BOOL                                                                     ClearEmptySection(const CPVT_WordPlace & place);
+    CPVT_WordPlace                                                      AjustLineHeader(const CPVT_WordPlace & place, bool bPrevOrNext) const;
+    bool                                                                        ClearEmptySection(const CPVT_WordPlace & place);
     void                                                                        ClearEmptySections(const CPVT_WordRange & PlaceRange);
     void                                                                        LinkLatterSection(const CPVT_WordPlace & place);
     void                                                                        ClearWords(const CPVT_WordRange & PlaceRange);
     CPVT_WordPlace                                                      ClearLeftWord(const CPVT_WordPlace & place);
     CPVT_WordPlace                                                      ClearRightWord(const CPVT_WordPlace & place);
 private:
     CPVT_FloatRect                                                      Rearrange(const CPVT_WordRange & PlaceRange);
     FX_FLOAT                                                            GetAutoFontSize();
-    FX_BOOL                                                                     IsBigger(FX_FLOAT fFontSize);
+    bool                                                                        IsBigger(FX_FLOAT fFontSize);
     CPVT_FloatRect                                                      RearrangeSections(const CPVT_WordRange & PlaceRange);
 private:
     void                                                                        ResetSectionArray();
 private:
     CPVT_ArrayTemplate<CSection*>                       m_SectionArray;
     int32_t                                                             m_nLimitChar;
     int32_t                                                             m_nCharArray;
-    FX_BOOL                                                                     m_bMultiLine;
-    FX_BOOL                                                                     m_bLimitWidth;
-    FX_BOOL                                                                     m_bAutoFontSize;
+    bool                                                                        m_bMultiLine;
+    bool                                                                        m_bLimitWidth;
+    bool                                                                        m_bAutoFontSize;
     int32_t                                                             m_nAlignment;
     FX_FLOAT                                                            m_fLineLeading;
     FX_FLOAT                                                            m_fCharSpace;
     int32_t                                                             m_nHorzScale;
     FX_WORD                                                                     m_wSubWord;
     FX_FLOAT                                                            m_fFontSize;
 
 private:
-    FX_BOOL                                                                     m_bInitial;
-    FX_BOOL                                                                     m_bRichText;
+    bool                                                                        m_bInitial;
+    bool                                                                        m_bRichText;
     IPDF_VariableText_Provider *                        m_pVTProvider;
     CPDF_VariableText_Iterator *                        m_pVTIterator;
 };
 class CPDF_VariableText_Iterator : public IPDF_VariableText_Iterator
 {
 public:
     CPDF_VariableText_Iterator(CPDF_VariableText * pVT);
     virtual ~CPDF_VariableText_Iterator();
-    FX_BOOL                                                                     NextWord();
-    FX_BOOL                                                                     PrevWord();
-    FX_BOOL                                                                     NextLine();
-    FX_BOOL                                                                     PrevLine();
-    FX_BOOL                                                                     NextSection();
-    FX_BOOL                                                                     PrevSection();
-    FX_BOOL                                                                     SetWord(const CPVT_Word & word);
-    FX_BOOL                                                                     GetWord(CPVT_Word & word) const;
-    FX_BOOL                                                                     GetLine(CPVT_Line & line) const;
-    FX_BOOL                                                                     GetSection(CPVT_Section & section) const;
-    FX_BOOL                                                                     SetSection(const CPVT_Section & section);
+    bool                                                                        NextWord();
+    bool                                                                        PrevWord();
+    bool                                                                        NextLine();
+    bool                                                                        PrevLine();
+    bool                                                                        NextSection();
+    bool                                                                        PrevSection();
+    bool                                                                        SetWord(const CPVT_Word & word);
+    bool                                                                        GetWord(CPVT_Word & word) const;
+    bool                                                                        GetLine(CPVT_Line & line) const;
+    bool                                                                        GetSection(CPVT_Section & section) const;
+    bool                                                                        SetSection(const CPVT_Section & section);
     void                                                                        SetAt(int32_t nWordIndex);
     void                                                                        SetAt(const CPVT_WordPlace & place);
     const CPVT_WordPlace &                                      GetAt() const
     {
         return m_CurPos;
     };
 private:
     CPVT_WordPlace                                                      m_CurPos;
     CPDF_VariableText *                                         m_pVT;
 };
 
 #endif  // CORE_SRC_FPDFDOC_PDF_VT_H_