core/include/fxge/fpf.h - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fxge/fpf.h

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fxge/fpf.h

diff --git a/core/include/fxge/fpf.h b/core/include/fxge/fpf.h

index fb9bf4d111163b758ce6a20ebb165699bf5aebca..115ef55c4907b9af242c4b606d59e54e1dc432b7 100644

--- a/core/include/fxge/fpf.h

+++ b/core/include/fxge/fpf.h

@@ -41,8 +41,8 @@ public:

virtual int32_t GetAscent() const = 0;

virtual int32_t GetDescent() const = 0;

- virtual FX_BOOL GetGlyphBBox(int32_t iGlyphIndex, FX_RECT &rtBBox) = 0;

- virtual FX_BOOL GetBBox(FX_RECT &rtBBox) = 0;

+ virtual bool GetGlyphBBox(int32_t iGlyphIndex, FX_RECT &rtBBox) = 0;

+ virtual bool GetBBox(FX_RECT &rtBBox) = 0;

virtual int32_t GetHeight() const = 0;

virtual int32_t GetItalicAngle() const = 0;

« no previous file with comments | « core/include/fxcrt/fx_xml.h ('k') | core/include/fxge/fx_dib.h » ('j') | no next file with comments »