FX_BOOL considered harmful.

fpdfsdk/include/javascript/global.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FPDFSDK_INCLUDE_JAVASCRIPT_GLOBAL_H_
 #define FPDFSDK_INCLUDE_JAVASCRIPT_GLOBAL_H_
 
 #include "JS_Define.h"
 
 class CJS_GlobalData;
 class CJS_GlobalVariableArray;
 class CJS_KeyValue;
 
 struct js_global_data
 {
         js_global_data()
         {
                 nType = 0;
                 dData = 0;
-                bData = FALSE;
+                bData = false;
                 sData = "";
-                bPersistent = FALSE;
-                bDeleted = FALSE;
+                bPersistent = false;
+                bDeleted = false;
         }
 
         ~js_global_data()
         {
                 pData.Reset();
         }
         int                                     nType; //0:int 1:bool 2:string 3:obj
         double                          dData;
         bool                            bData;
         CFX_ByteString          sData;
         v8::Global<v8::Object>  pData;
         bool                            bPersistent;
         bool                            bDeleted;
 };
 
 class global_alternate : public CJS_EmbedObj
 {
 public:
         global_alternate(CJS_Object* pJSObject);
         virtual ~global_alternate();
 
 public:
-        FX_BOOL                                         setPersistent(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError);
+        bool                                            setPersistent(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError);
 
 public:
-        FX_BOOL                                         QueryProperty(const FX_WCHAR* propname);
-        FX_BOOL                                         DoProperty(IFXJS_Context* cc, const FX_WCHAR* propname, CJS_PropValue & vp, CFX_WideString & sError);
-        FX_BOOL                                         DelProperty(IFXJS_Context* cc, const FX_WCHAR* propname, CFX_WideString & sError);
+        bool                                            QueryProperty(const FX_WCHAR* propname);
+        bool                                            DoProperty(IFXJS_Context* cc, const FX_WCHAR* propname, CJS_PropValue & vp, CFX_WideString & sError);
+        bool                                            DelProperty(IFXJS_Context* cc, const FX_WCHAR* propname, CFX_WideString & sError);
 
         void                                            Initial(CPDFDoc_Environment* pApp);
 
 private:
         void                                            UpdateGlobalPersistentVariables();
         void                                            CommitGlobalPersisitentVariables();
         void                                            DestroyGlobalPersisitentVariables();
-        FX_BOOL                                         SetGlobalVariables(const FX_CHAR* propname, int nType,
+        bool                                            SetGlobalVariables(const FX_CHAR* propname, int nType,
                                                                         double dData, bool bData, const CFX_ByteString& sData, JSObject pData, bool bDefaultPersistent);
 
         void                                            ObjectToArray(v8::Local<v8::Object> pObj, CJS_GlobalVariableArray& array);
         void                                            PutObjectProperty(v8::Local<v8::Object> obj, CJS_KeyValue* pData);
 
 private:
         CFX_MapByteStringToPtr          m_mapGlobal;
         CFX_WideString                          m_sFilePath;
         CJS_GlobalData*                         m_pGlobalData;
         CPDFDoc_Environment*                            m_pApp;
 };
 
 
 class CJS_Global : public CJS_Object
 {
 public:
         CJS_Global(JSFXObject pObject) : CJS_Object(pObject) {};
         virtual ~CJS_Global(void){};
 
-        virtual FX_BOOL InitInstance(IFXJS_Context* cc);
+        virtual bool    InitInstance(IFXJS_Context* cc);
 
         DECLARE_SPECIAL_JS_CLASS(CJS_Global);
 
         JS_SPECIAL_STATIC_METHOD(setPersistent, global_alternate, global);
 
 };
 
 #endif  // FPDFSDK_INCLUDE_JAVASCRIPT_GLOBAL_H_