core/src/fxge/android/fpf_skiafontmgr.h - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/android/fpf_skiafontmgr.h

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/android/fpf_skiafontmgr.h

diff --git a/core/src/fxge/android/fpf_skiafontmgr.h b/core/src/fxge/android/fpf_skiafontmgr.h

index 8c721ff68ab78e279e00fd40b8d2f10a293e22a1..b4ebe9454a87c808cfedb0b4134db8b831482826 100644

--- a/core/src/fxge/android/fpf_skiafontmgr.h

+++ b/core/src/fxge/android/fpf_skiafontmgr.h

@@ -94,7 +94,7 @@ class CFPF_SkiaFontMgr : public IFPF_FontMgr

public:

CFPF_SkiaFontMgr();

virtual ~CFPF_SkiaFontMgr();

- FX_BOOL InitFTLibrary();

+ bool InitFTLibrary();

virtual void LoadSystemFonts();

virtual void LoadPrivateFont(IFX_FileRead* pFontFile);

virtual void LoadPrivateFont(const CFX_ByteStringC& bsFileName);

@@ -109,7 +109,7 @@ protected:

void ScanFile(const CFX_ByteStringC& file);

void ReportFace(FXFT_Face face, CFPF_SkiaFontDescriptor *pFontDesc);

void OutputSystemFonts();

- FX_BOOL m_bLoaded;

+ bool m_bLoaded;

CFX_PtrArray m_FontFaces;

FXFT_Library m_FTLibrary;

CFX_MapPtrToPtr m_FamilyFonts;

« no previous file with comments | « core/src/fxge/android/fpf_skiafont.cpp ('k') | core/src/fxge/android/fpf_skiafontmgr.cpp » ('j') | no next file with comments »