FX_BOOL considered harmful.

core/src/fpdfdoc/doc_utils.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfdoc/fpdf_doc.h"
 #include "doc_utils.h"
 
 static const int FPDFDOC_UTILS_MAXRECURSION = 32;
 
 CFX_WideString GetFullName(CPDF_Dictionary* pFieldDict)
 {
     CFX_WideString full_name;
     CPDF_Dictionary* pLevel = pFieldDict;
     while (pLevel) {
         CFX_WideString short_name = pLevel->GetUnicodeText("T");
         if (short_name != L"") {
             if (full_name == L"") {
                 full_name = short_name;
             } else {
                 full_name = short_name + L"." + full_name;
             }
         }
         pLevel = pLevel->GetDict("Parent");
     }
     return full_name;
 }
-FX_BOOL CPDF_DefaultAppearance::HasFont()
+bool CPDF_DefaultAppearance::HasFont()
 {
     if (m_csDA.IsEmpty()) {
-        return FALSE;
+        return false;
     }
     CPDF_SimpleParser syntax(m_csDA);
     return syntax.FindTagParam("Tf", 2);
 }
 CFX_ByteString CPDF_DefaultAppearance::GetFontString()
 {
     CFX_ByteString csFont;
     if (m_csDA.IsEmpty()) {
         return csFont;
     }
@@ skipping 15 matching lines @@
         return;
     }
     CPDF_SimpleParser syntax(m_csDA);
     if (syntax.FindTagParam("Tf", 2)) {
         csFontNameTag = (CFX_ByteString)syntax.GetWord();
         csFontNameTag.Delete(0, 1);
         fFontSize = FX_atof((CFX_ByteString)syntax.GetWord());
     }
     csFontNameTag = PDF_NameDecode(csFontNameTag);
 }
-FX_BOOL CPDF_DefaultAppearance::HasColor(FX_BOOL bStrokingOperation)
+bool CPDF_DefaultAppearance::HasColor(bool bStrokingOperation)
 {
     if (m_csDA.IsEmpty()) {
-        return FALSE;
+        return false;
     }
     CPDF_SimpleParser syntax(m_csDA);
     if (syntax.FindTagParam(bStrokingOperation ? "G" : "g", 1)) {
-        return TRUE;
+        return true;
     }
     syntax.SetPos(0);
     if (syntax.FindTagParam(bStrokingOperation ? "RG" : "rg", 3)) {
-        return TRUE;
+        return true;
     }
     syntax.SetPos(0);
     return syntax.FindTagParam(bStrokingOperation ? "K" : "k", 4);
 }
-CFX_ByteString CPDF_DefaultAppearance::GetColorString(FX_BOOL bStrokingOperation)
+CFX_ByteString CPDF_DefaultAppearance::GetColorString(bool bStrokingOperation)
 {
     CFX_ByteString csColor;
     if (m_csDA.IsEmpty()) {
         return csColor;
     }
     CPDF_SimpleParser syntax(m_csDA);
     if (syntax.FindTagParam(bStrokingOperation ? "G" : "g", 1)) {
         csColor += (CFX_ByteString)syntax.GetWord();
         csColor += " ";
         csColor += (CFX_ByteString)syntax.GetWord();
@@ skipping 17 matching lines @@
         csColor += (CFX_ByteString)syntax.GetWord();
         csColor += " ";
         csColor += (CFX_ByteString)syntax.GetWord();
         csColor += " ";
         csColor += (CFX_ByteString)syntax.GetWord();
         csColor += " ";
         csColor += (CFX_ByteString)syntax.GetWord();
     }
     return csColor;
 }
-void CPDF_DefaultAppearance::GetColor(int& iColorType, FX_FLOAT fc[4], FX_BOOL bStrokingOperation)
+void CPDF_DefaultAppearance::GetColor(int& iColorType, FX_FLOAT fc[4], bool bStrokingOperation)
 {
     iColorType = COLORTYPE_TRANSPARENT;
     for (int c = 0; c < 4; c ++) {
         fc[c] = 0;
     }
     if (m_csDA.IsEmpty()) {
         return;
     }
     CPDF_SimpleParser syntax(m_csDA);
     if (syntax.FindTagParam(bStrokingOperation ? "G" : "g", 1)) {
@@ skipping 11 matching lines @@
     }
     syntax.SetPos(0);
     if (syntax.FindTagParam(bStrokingOperation ? "K" : "k", 4)) {
         iColorType = COLORTYPE_CMYK;
         fc[0] = FX_atof((CFX_ByteString)syntax.GetWord());
         fc[1] = FX_atof((CFX_ByteString)syntax.GetWord());
         fc[2] = FX_atof((CFX_ByteString)syntax.GetWord());
         fc[3] = FX_atof((CFX_ByteString)syntax.GetWord());
     }
 }
-void CPDF_DefaultAppearance::GetColor(FX_ARGB& color, int& iColorType, FX_BOOL bStrokingOperation)
+void CPDF_DefaultAppearance::GetColor(FX_ARGB& color, int& iColorType, bool bStrokingOperation)
 {
     color = 0;
     iColorType = COLORTYPE_TRANSPARENT;
     if (m_csDA.IsEmpty()) {
         return;
     }
     CPDF_SimpleParser syntax(m_csDA);
     if (syntax.FindTagParam(bStrokingOperation ? "G" : "g", 1)) {
         iColorType = COLORTYPE_GRAY;
         FX_FLOAT g = FX_atof((CFX_ByteString)syntax.GetWord()) * 255 + 0.5f;
@@ skipping 15 matching lines @@
         FX_FLOAT c = FX_atof((CFX_ByteString)syntax.GetWord());
         FX_FLOAT m = FX_atof((CFX_ByteString)syntax.GetWord());
         FX_FLOAT y = FX_atof((CFX_ByteString)syntax.GetWord());
         FX_FLOAT k = FX_atof((CFX_ByteString)syntax.GetWord());
         FX_FLOAT r = 1.0f - FX_MIN(1.0f, c + k);
         FX_FLOAT g = 1.0f - FX_MIN(1.0f, m + k);
         FX_FLOAT b = 1.0f - FX_MIN(1.0f, y + k);
         color = ArgbEncode(255, (int)(r * 255 + 0.5f), (int)(g * 255 + 0.5f), (int)(b * 255 + 0.5f));
     }
 }
-FX_BOOL CPDF_DefaultAppearance::HasTextMatrix()
+bool CPDF_DefaultAppearance::HasTextMatrix()
 {
     if (m_csDA.IsEmpty()) {
-        return FALSE;
+        return false;
     }
     CPDF_SimpleParser syntax(m_csDA);
     return syntax.FindTagParam("Tm", 6);
 }
 CFX_ByteString CPDF_DefaultAppearance::GetTextMatrixString()
 {
     CFX_ByteString csTM;
     if (m_csDA.IsEmpty()) {
         return csTM;
     }
@@ skipping 257 matching lines @@
     CPDF_Font* pFont = GetDefaultInterFormFont(pFormDict, pDocument);
     if (pFont != NULL) {
         pSubst = (CFX_SubstFont*)pFont->GetSubstFont();
         if (pSubst != NULL && pSubst->m_Charset == (int)charSet) {
             FindInterFormFont(pFormDict, pFont, csNameTag);
             return pFont;
         }
     }
     return GetNativeInterFormFont(pFormDict, pDocument, charSet, csNameTag);
 }
-FX_BOOL FindInterFormFont(CPDF_Dictionary* pFormDict, const CPDF_Font* pFont, CFX_ByteString& csNameTag)
+bool FindInterFormFont(CPDF_Dictionary* pFormDict, const CPDF_Font* pFont, CFX_ByteString& csNameTag)
 {
     if (pFormDict == NULL || pFont == NULL) {
-        return FALSE;
+        return false;
     }
     CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
     if (pDR == NULL) {
-        return FALSE;
+        return false;
     }
     CPDF_Dictionary* pFonts = pDR->GetDict("Font");
     if (pFonts == NULL) {
-        return FALSE;
+        return false;
     }
     FX_POSITION pos = pFonts->GetStartPos();
     while (pos) {
         CPDF_Object* pObj = NULL;
         CFX_ByteString csKey;
         pObj = pFonts->GetNextElement(pos, csKey);
         if (pObj == NULL) {
             continue;
         }
         CPDF_Object* pDirect = pObj->GetDirect();
         if (pDirect == NULL || pDirect->GetType() != PDFOBJ_DICTIONARY) {
             continue;
         }
         CPDF_Dictionary* pElement = (CPDF_Dictionary*)pDirect;
         if (pElement->GetString("Type") != "Font") {
             continue;
         }
         if (pFont->GetFontDict() == pElement) {
             csNameTag = csKey;
-            return TRUE;
+            return true;
         }
     }
-    return FALSE;
+    return false;
 }
-FX_BOOL FindInterFormFont(CPDF_Dictionary* pFormDict, CPDF_Document* pDocument, CFX_ByteString csFontName, CPDF_Font*& pFont, CFX_ByteString& csNameTag)
+bool FindInterFormFont(CPDF_Dictionary* pFormDict, CPDF_Document* pDocument, CFX_ByteString csFontName, CPDF_Font*& pFont, CFX_ByteString& csNameTag)
 {
     if (pFormDict == NULL) {
-        return FALSE;
+        return false;
     }
     CPDF_Dictionary* pDR = pFormDict->GetDict("DR");
     if (pDR == NULL) {
-        return FALSE;
+        return false;
     }
     CPDF_Dictionary* pFonts = pDR->GetDict("Font");
     if (pFonts == NULL) {
-        return FALSE;
+        return false;
     }
     if (csFontName.GetLength() > 0) {
         csFontName.Remove(' ');
     }
     FX_POSITION pos = pFonts->GetStartPos();
     while (pos) {
         CPDF_Object* pObj = NULL;
         CFX_ByteString csKey, csTmp;
         pObj = pFonts->GetNextElement(pos, csKey);
         if (pObj == NULL) {
             continue;
         }
         CPDF_Object* pDirect = pObj->GetDirect();
         if (pDirect == NULL || pDirect->GetType() != PDFOBJ_DICTIONARY) {
             continue;
         }
         CPDF_Dictionary* pElement = (CPDF_Dictionary*)pDirect;
         if (pElement->GetString("Type") != "Font") {
             continue;
         }
         pFont = pDocument->LoadFont(pElement);
         if (pFont == NULL) {
             continue;
         }
         CFX_ByteString csBaseFont;
         csBaseFont = pFont->GetBaseFont();
         csBaseFont.Remove(' ');
         if (csBaseFont == csFontName) {
             csNameTag = csKey;
-            return TRUE;
+            return true;
         }
     }
-    return FALSE;
+    return false;
 }
 void AddInterFormFont(CPDF_Dictionary*& pFormDict, CPDF_Document* pDocument, const CPDF_Font* pFont, CFX_ByteString& csNameTag)
 {
     if (pFont == NULL) {
         return;
     }
     if (pFormDict == NULL) {
         InitInterFormDict(pFormDict, pDocument);
     }
     CFX_ByteString csTag;
@@ skipping 99 matching lines @@
     CFX_ByteString csSW = m_pDict->GetString("SW", "A");
     if (csSW == "B") {
         return Bigger;
     } else if (csSW == "S") {
         return Smaller;
     } else if (csSW == "N") {
         return Never;
     }
     return Always;
 }
-FX_BOOL CPDF_IconFit::IsProportionalScale()
+bool CPDF_IconFit::IsProportionalScale()
 {
     if (m_pDict == NULL) {
-        return TRUE;
+        return true;
     }
     return m_pDict->GetString("S", "P") != "A";
 }
 void CPDF_IconFit::GetIconPosition(FX_FLOAT& fLeft, FX_FLOAT& fBottom)
 {
     fLeft = fBottom = 0.5;
     if (m_pDict == NULL) {
         return;
     }
     CPDF_Array* pA = m_pDict->GetArray("A");
     if (pA != NULL) {
         FX_DWORD dwCount = pA->GetCount();
         if (dwCount > 0) {
             fLeft = pA->GetNumber(0);
         }
         if (dwCount > 1) {
             fBottom = pA->GetNumber(1);
         }
     }
 }
-FX_BOOL CPDF_IconFit::GetFittingBounds()
+bool CPDF_IconFit::GetFittingBounds()
 {
     if (m_pDict == NULL) {
-        return FALSE;
+        return false;
     }
     return m_pDict->GetBoolean("FB");
 }
 void SaveCheckedFieldStatus(CPDF_FormField* pField, CFX_ByteArray& statusArray)
 {
     int iCount = pField->CountControls();
     for (int i = 0; i < iCount; i ++) {
         CPDF_FormControl* pControl = pField->GetControl(i);
         if (pControl == NULL) {
             continue;
@@ skipping 12 matching lines @@
     CPDF_Object* pAttr = pFieldDict->GetElementValue(name);
     if (pAttr) {
         return pAttr;
     }
     CPDF_Dictionary* pParent = pFieldDict->GetDict("Parent");
     if (pParent == NULL) {
         return NULL;
     }
     return FPDF_GetFieldAttr(pParent, name, nLevel + 1);
 }