fpdfsdk/src/javascript/Icon.cpp - Issue 1252613002: FX_BOOL considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/Icon.cpp

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual edits. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/Icon.cpp

diff --git a/fpdfsdk/src/javascript/Icon.cpp b/fpdfsdk/src/javascript/Icon.cpp

index 6b3e02e1ec5dab9df31d1ca09cf83134c96b8126..27a9773235cc5d84d5d26c591452510f21cc1eb2 100644

--- a/fpdfsdk/src/javascript/Icon.cpp

+++ b/fpdfsdk/src/javascript/Icon.cpp

@@ -57,11 +57,11 @@ CFX_WideString Icon::GetIconName()

return m_swIconName;

}

-FX_BOOL Icon::name(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)

+bool Icon::name(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)

{

- if(!vp.IsGetting())return FALSE;

+ if(!vp.IsGetting())return false;

vp << m_swIconName;

- return TRUE;

+ return true;

}

« no previous file with comments | « fpdfsdk/src/javascript/Field.cpp ('k') | fpdfsdk/src/javascript/JS_Context.cpp » ('j') | no next file with comments »