Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Unified Diff: core/src/fxcrt/fx_basic_gcc.cpp

Issue 1252613002: FX_BOOL considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Manual edits. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/src/fxcrt/fx_basic_coords.cpp ('k') | core/src/fxcrt/fx_basic_maps.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fxcrt/fx_basic_gcc.cpp
diff --git a/core/src/fxcrt/fx_basic_gcc.cpp b/core/src/fxcrt/fx_basic_gcc.cpp
index e4416e95b518a1f31ef5f32076b231a4a8e8ec83..562f741d411a657de14ebe130f19c8afb63428a0 100644
--- a/core/src/fxcrt/fx_basic_gcc.cpp
+++ b/core/src/fxcrt/fx_basic_gcc.cpp
@@ -12,12 +12,12 @@
template <class T, class STR_T>
T FXSYS_StrToInt(STR_T str)
{
- FX_BOOL neg = FALSE;
+ bool neg = false;
if (str == NULL) {
return 0;
}
if (*str == '-') {
- neg = TRUE;
+ neg = true;
str ++;
}
T num = 0;
@@ -208,7 +208,7 @@ char* FXSYS_itoa(int value, char* string, int radix)
extern "C" {
#endif
int FXSYS_WideCharToMultiByte(FX_DWORD codepage, FX_DWORD dwFlags, const FX_WCHAR* wstr, int wlen,
- FX_CHAR* buf, int buflen, const FX_CHAR* default_str, FX_BOOL* pUseDefault)
+ FX_CHAR* buf, int buflen, const FX_CHAR* default_str, int* pUseDefault)
{
int len = 0;
for (int i = 0; i < wlen; i ++) {
« no previous file with comments | « core/src/fxcrt/fx_basic_coords.cpp ('k') | core/src/fxcrt/fx_basic_maps.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698